From: Christian Schoenebeck <qemu_oss@crudebyte.com>
To: qemu-devel@nongnu.org
Cc: Cornelia Huck <cohuck@redhat.com>,
Markus Armbruster <armbru@redhat.com>, Greg Kurz <groug@kaod.org>
Subject: Re: [PATCH] qemu-options.hx: 9p: clarify -virtfs vs. -fsdev
Date: Wed, 01 Apr 2020 11:08:56 +0200 [thread overview]
Message-ID: <2456463.xyXBBZaS1u@silver> (raw)
In-Reply-To: <20200331181033.01d16aa2.cohuck@redhat.com>
On Dienstag, 31. März 2020 18:10:33 CEST Cornelia Huck wrote:
> > >> Huh. This prompted me to try this on s390, and it actually creates a
> > >> virtio-9p-pci device there as well, not a virtio-9p-ccw device. A bit
> > >> surprising; but I don't see 9p used much (if at all) on s390 anyway.
> > >
> > > Yeah, "virtio-9p-pci" is currently hard coded in softmmu/vl.c [line
> > > 3352]:
> > > https://github.com/qemu/qemu/blob/17083d6d1e0635371418c26b613a6fa68d392f
> > > 49/softmmu/vl.c#L3352>
> > Should it be "virtio-9p" instead? It's an alias for "virtio-9p-pci",
> > except for s390x, where it's an alias for "virtio-9p-ccw".
>
> Seems like a reasonable change (although I'm not sure it matters too
> much).
It would be a minor change it seems, and yes there seems to be a virtio-9p-ccw
implementation, however as long as nobody complains I leave it untouched for
now. Especially since I have no idea about the s390 architecture, nor testing
it.
Best regards,
Christian Schoenebeck
next prev parent reply other threads:[~2020-04-01 9:09 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 13:23 [PATCH] qemu-options.hx: 9p: clarify -virtfs vs. -fsdev Christian Schoenebeck
2020-03-31 15:27 ` Cornelia Huck
2020-03-31 15:41 ` Christian Schoenebeck
2020-03-31 16:05 ` Markus Armbruster
2020-03-31 16:10 ` Cornelia Huck
2020-04-01 9:08 ` Christian Schoenebeck [this message]
2020-04-20 15:42 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2456463.xyXBBZaS1u@silver \
--to=qemu_oss@crudebyte.com \
--cc=armbru@redhat.com \
--cc=cohuck@redhat.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.