From: Markus Armbruster <armbru@redhat.com>
To: Christian Schoenebeck <qemu_oss@crudebyte.com>
Cc: Cornelia Huck <cohuck@redhat.com>,
qemu-devel@nongnu.org, Greg Kurz <groug@kaod.org>
Subject: Re: [PATCH] qemu-options.hx: 9p: clarify -virtfs vs. -fsdev
Date: Tue, 31 Mar 2020 18:05:08 +0200 [thread overview]
Message-ID: <87369otsqz.fsf@dusky.pond.sub.org> (raw)
In-Reply-To: <6318846.9qTBnWfJNl@silver> (Christian Schoenebeck's message of "Tue, 31 Mar 2020 17:41:08 +0200")
Christian Schoenebeck <qemu_oss@crudebyte.com> writes:
> On Dienstag, 31. März 2020 17:27:27 CEST Cornelia Huck wrote:
>> > diff --git a/qemu-options.hx b/qemu-options.hx
>> > index 962a5ebaa6..fd3830c6cd 100644
>> > --- a/qemu-options.hx
>> > +++ b/qemu-options.hx
>> > @@ -1542,9 +1542,17 @@ SRST
>> >
>> > ``-virtfs proxy,sock_fd=sock_fd,mount_tag=mount_tag
>> > [,writeout=writeout][,readonly]``>
>> > \
>> >
>> > ``-virtfs synth,mount_tag=mount_tag``
>> >
>> > - Define a new filesystem device and expose it to the guest using a
>> > - virtio-9p-device. The general form of a Virtual File system
>> > - pass-through options are:
>> > + Define a new virtual filesystem device and expose it to the guest
>> > using + a virtio-9p-device (a.k.a. 9pfs), which essentially means that
>> > a certain + directory on host is made directly accessible by guest as
>> > a pass-through + file system by using the 9P network protocol for
>> > communication between + host and guests, if desired even accessible,
>> > shared by several guests + simultaniously.
>> > +
>> > + Note that ``-virtfs`` is actually just a convenience shortcut for its
>> > + generalized form ``-fsdev -device virtio-9p-pci``.
>>
>> Huh. This prompted me to try this on s390, and it actually creates a
>> virtio-9p-pci device there as well, not a virtio-9p-ccw device. A bit
>> surprising; but I don't see 9p used much (if at all) on s390 anyway.
>
> Yeah, "virtio-9p-pci" is currently hard coded in softmmu/vl.c [line 3352]:
> https://github.com/qemu/qemu/blob/17083d6d1e0635371418c26b613a6fa68d392f49/softmmu/vl.c#L3352
Should it be "virtio-9p" instead? It's an alias for "virtio-9p-pci",
except for s390x, where it's an alias for "virtio-9p-ccw".
next prev parent reply other threads:[~2020-03-31 16:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-31 13:23 [PATCH] qemu-options.hx: 9p: clarify -virtfs vs. -fsdev Christian Schoenebeck
2020-03-31 15:27 ` Cornelia Huck
2020-03-31 15:41 ` Christian Schoenebeck
2020-03-31 16:05 ` Markus Armbruster [this message]
2020-03-31 16:10 ` Cornelia Huck
2020-04-01 9:08 ` Christian Schoenebeck
2020-04-20 15:42 ` Greg Kurz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87369otsqz.fsf@dusky.pond.sub.org \
--to=armbru@redhat.com \
--cc=cohuck@redhat.com \
--cc=groug@kaod.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.