All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Heiko Stübner" <heiko@sntech.de>
To: Robin Murphy <robin.murphy@arm.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: robh@kernel.org, arnd@linaro.org, ulf.hansson@linaro.org,
	rjw@rjwysocki.net, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	lukasz.luba@arm.com, Rob Herring <robh+dt@kernel.org>,
	Johan Jonker <jbx6244@gmail.com>,
	"moderated list:ARM/Rockchip SoC support" 
	<linux-arm-kernel@lists.infradead.org>,
	"open list:ARM/Rockchip SoC support" 
	<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH 2/5] arm64: dts: rockchip: Add powerzones definition for rock960
Date: Wed, 24 Nov 2021 17:52:14 +0100	[thread overview]
Message-ID: <2457824.5MrYSl4YA0@diego> (raw)
In-Reply-To: <f2609d56-f014-3713-8f73-c7ca9c7cba60@linaro.org>

Am Mittwoch, 24. November 2021, 17:41:34 CET schrieb Daniel Lezcano:
> On 24/11/2021 14:49, Robin Murphy wrote:
> > On 2021-11-24 12:55, Daniel Lezcano wrote:
> >> Add the powerzones description. This first step introduces the big,
> >> the little and the gpu as a powerzone place.
> > 
> > These look more like SoC-level properties than board-level ones - should
> > they be in rk3399.dtsi?
> 
> Yes, it makes sense
> 
> If Heiko is fine with that I can add this description in the rk3399.dtsi
> file

Sure. Robin's suggestion sounds very sensible as these properties are
quite specific to the soc itself.


Heiko

> 
> >> ---
> >>   .../boot/dts/rockchip/rk3399-rock960.dts      | 45 +++++++++++++++++++
> >>   1 file changed, 45 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> >> b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> >> index 1a23e8f3cdf6..83540bdb64cd 100644
> >> --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> >> @@ -61,6 +61,51 @@ bt_active_led: led-6 {
> >>           };
> >>       };
> >>   +    powerzones {
> >> +
> >> +        PKG_PZ: pkg {
> >> +            #powerzone-cells = <0>;
> >> +                        powerzone = <&SOC_PZ>;
> >> +        };
> >> +
> >> +        SOC_PZ: soc {
> >> +        };
> >> +    };
> >> +};
> >> +
> >> +&cpu_b0 {
> >> +    #powerzone-cells = <0>;
> >> +    powerzone = <&PKG_PZ>;
> >> +};
> >> +
> >> +&cpu_b1 {
> >> +    #powerzone-cells = <0>;
> >> +    powerzone = <&PKG_PZ>;
> >> +};
> >> +
> >> +&cpu_l0 {
> >> +    #powerzone-cells = <0>;
> >> +    powerzone = <&PKG_PZ>;
> >> +};
> >> +
> >> +&cpu_l1 {
> >> +    #powerzone-cells = <0>;
> >> +    powerzone = <&PKG_PZ>;
> >> +};
> >> +
> >> +&cpu_l2 {
> >> +    #powerzone-cells = <0>;
> >> +    powerzone = <&PKG_PZ>;
> >> +};
> >> +
> >> +&cpu_l3 {
> >> +    #powerzone-cells = <0>;
> >> +    powerzone = <&PKG_PZ>;
> >> +};
> >> +
> >> +&gpu {
> >> +    #powerzone-cells = <0>;
> >> +    powerzone = <&PKG_PZ>;
> >>   };
> >>     &cpu_alert0 {
> >>
> 
> 
> 





WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Robin Murphy <robin.murphy@arm.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: robh@kernel.org, arnd@linaro.org, ulf.hansson@linaro.org,
	rjw@rjwysocki.net, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	lukasz.luba@arm.com, Rob Herring <robh+dt@kernel.org>,
	Johan Jonker <jbx6244@gmail.com>,
	"moderated list:ARM/Rockchip SoC support"
	<linux-arm-kernel@lists.infradead.org>,
	"open list:ARM/Rockchip SoC support"
	<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH 2/5] arm64: dts: rockchip: Add powerzones definition for rock960
Date: Wed, 24 Nov 2021 17:52:14 +0100	[thread overview]
Message-ID: <2457824.5MrYSl4YA0@diego> (raw)
In-Reply-To: <f2609d56-f014-3713-8f73-c7ca9c7cba60@linaro.org>

Am Mittwoch, 24. November 2021, 17:41:34 CET schrieb Daniel Lezcano:
> On 24/11/2021 14:49, Robin Murphy wrote:
> > On 2021-11-24 12:55, Daniel Lezcano wrote:
> >> Add the powerzones description. This first step introduces the big,
> >> the little and the gpu as a powerzone place.
> > 
> > These look more like SoC-level properties than board-level ones - should
> > they be in rk3399.dtsi?
> 
> Yes, it makes sense
> 
> If Heiko is fine with that I can add this description in the rk3399.dtsi
> file

Sure. Robin's suggestion sounds very sensible as these properties are
quite specific to the soc itself.


Heiko

> 
> >> ---
> >>   .../boot/dts/rockchip/rk3399-rock960.dts      | 45 +++++++++++++++++++
> >>   1 file changed, 45 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> >> b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> >> index 1a23e8f3cdf6..83540bdb64cd 100644
> >> --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> >> @@ -61,6 +61,51 @@ bt_active_led: led-6 {
> >>           };
> >>       };
> >>   +    powerzones {
> >> +
> >> +        PKG_PZ: pkg {
> >> +            #powerzone-cells = <0>;
> >> +                        powerzone = <&SOC_PZ>;
> >> +        };
> >> +
> >> +        SOC_PZ: soc {
> >> +        };
> >> +    };
> >> +};
> >> +
> >> +&cpu_b0 {
> >> +    #powerzone-cells = <0>;
> >> +    powerzone = <&PKG_PZ>;
> >> +};
> >> +
> >> +&cpu_b1 {
> >> +    #powerzone-cells = <0>;
> >> +    powerzone = <&PKG_PZ>;
> >> +};
> >> +
> >> +&cpu_l0 {
> >> +    #powerzone-cells = <0>;
> >> +    powerzone = <&PKG_PZ>;
> >> +};
> >> +
> >> +&cpu_l1 {
> >> +    #powerzone-cells = <0>;
> >> +    powerzone = <&PKG_PZ>;
> >> +};
> >> +
> >> +&cpu_l2 {
> >> +    #powerzone-cells = <0>;
> >> +    powerzone = <&PKG_PZ>;
> >> +};
> >> +
> >> +&cpu_l3 {
> >> +    #powerzone-cells = <0>;
> >> +    powerzone = <&PKG_PZ>;
> >> +};
> >> +
> >> +&gpu {
> >> +    #powerzone-cells = <0>;
> >> +    powerzone = <&PKG_PZ>;
> >>   };
> >>     &cpu_alert0 {
> >>
> 
> 
> 





_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Robin Murphy <robin.murphy@arm.com>,
	Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: robh@kernel.org, arnd@linaro.org, ulf.hansson@linaro.org,
	rjw@rjwysocki.net, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
	lukasz.luba@arm.com, Rob Herring <robh+dt@kernel.org>,
	Johan Jonker <jbx6244@gmail.com>,
	"moderated list:ARM/Rockchip SoC support"
	<linux-arm-kernel@lists.infradead.org>,
	"open list:ARM/Rockchip SoC support"
	<linux-rockchip@lists.infradead.org>
Subject: Re: [PATCH 2/5] arm64: dts: rockchip: Add powerzones definition for rock960
Date: Wed, 24 Nov 2021 17:52:14 +0100	[thread overview]
Message-ID: <2457824.5MrYSl4YA0@diego> (raw)
In-Reply-To: <f2609d56-f014-3713-8f73-c7ca9c7cba60@linaro.org>

Am Mittwoch, 24. November 2021, 17:41:34 CET schrieb Daniel Lezcano:
> On 24/11/2021 14:49, Robin Murphy wrote:
> > On 2021-11-24 12:55, Daniel Lezcano wrote:
> >> Add the powerzones description. This first step introduces the big,
> >> the little and the gpu as a powerzone place.
> > 
> > These look more like SoC-level properties than board-level ones - should
> > they be in rk3399.dtsi?
> 
> Yes, it makes sense
> 
> If Heiko is fine with that I can add this description in the rk3399.dtsi
> file

Sure. Robin's suggestion sounds very sensible as these properties are
quite specific to the soc itself.


Heiko

> 
> >> ---
> >>   .../boot/dts/rockchip/rk3399-rock960.dts      | 45 +++++++++++++++++++
> >>   1 file changed, 45 insertions(+)
> >>
> >> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> >> b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> >> index 1a23e8f3cdf6..83540bdb64cd 100644
> >> --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> >> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dts
> >> @@ -61,6 +61,51 @@ bt_active_led: led-6 {
> >>           };
> >>       };
> >>   +    powerzones {
> >> +
> >> +        PKG_PZ: pkg {
> >> +            #powerzone-cells = <0>;
> >> +                        powerzone = <&SOC_PZ>;
> >> +        };
> >> +
> >> +        SOC_PZ: soc {
> >> +        };
> >> +    };
> >> +};
> >> +
> >> +&cpu_b0 {
> >> +    #powerzone-cells = <0>;
> >> +    powerzone = <&PKG_PZ>;
> >> +};
> >> +
> >> +&cpu_b1 {
> >> +    #powerzone-cells = <0>;
> >> +    powerzone = <&PKG_PZ>;
> >> +};
> >> +
> >> +&cpu_l0 {
> >> +    #powerzone-cells = <0>;
> >> +    powerzone = <&PKG_PZ>;
> >> +};
> >> +
> >> +&cpu_l1 {
> >> +    #powerzone-cells = <0>;
> >> +    powerzone = <&PKG_PZ>;
> >> +};
> >> +
> >> +&cpu_l2 {
> >> +    #powerzone-cells = <0>;
> >> +    powerzone = <&PKG_PZ>;
> >> +};
> >> +
> >> +&cpu_l3 {
> >> +    #powerzone-cells = <0>;
> >> +    powerzone = <&PKG_PZ>;
> >> +};
> >> +
> >> +&gpu {
> >> +    #powerzone-cells = <0>;
> >> +    powerzone = <&PKG_PZ>;
> >>   };
> >>     &cpu_alert0 {
> >>
> 
> 
> 





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-11-24 16:52 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-24 12:55 [PATCH 1/5] dt-bindings: Powerzone new bindings Daniel Lezcano
2021-11-24 12:55 ` [PATCH 2/5] arm64: dts: rockchip: Add powerzones definition for rock960 Daniel Lezcano
2021-11-24 12:55   ` Daniel Lezcano
2021-11-24 12:55   ` Daniel Lezcano
2021-11-24 13:49   ` Robin Murphy
2021-11-24 13:49     ` Robin Murphy
2021-11-24 13:49     ` Robin Murphy
2021-11-24 16:41     ` Daniel Lezcano
2021-11-24 16:41       ` Daniel Lezcano
2021-11-24 16:41       ` Daniel Lezcano
2021-11-24 16:52       ` Heiko Stübner [this message]
2021-11-24 16:52         ` Heiko Stübner
2021-11-24 16:52         ` Heiko Stübner
2021-11-24 12:55 ` [PATCH 3/5] powercap/drivers/dtpm: Add DT initialization support Daniel Lezcano
2021-11-24 12:55 ` [PATCH 4/5] powercap/drivers/dtpm: Add CPU " Daniel Lezcano
2021-11-24 12:55 ` [PATCH 5/5] powercap/drivers/dtpm: Add dtpm devfreq with energy model support Daniel Lezcano
2021-11-26  1:45   ` kernel test robot
2021-11-24 14:54 ` [PATCH 1/5] dt-bindings: Powerzone new bindings Ulf Hansson
2021-11-24 16:26   ` Daniel Lezcano
2021-11-24 19:17     ` Ulf Hansson
2021-11-25 21:26 ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2457824.5MrYSl4YA0@diego \
    --to=heiko@sntech.de \
    --cc=arnd@linaro.org \
    --cc=daniel.lezcano@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=jbx6244@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=lukasz.luba@arm.com \
    --cc=rjw@rjwysocki.net \
    --cc=robh+dt@kernel.org \
    --cc=robh@kernel.org \
    --cc=robin.murphy@arm.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.