From: Ian Jackson <iwj@xenproject.org>
To: Manuel Bouyer <bouyer@netbsd.org>
Cc: xen-devel@lists.xenproject.org, "Wei Liu" <wl@xen.org>,
"Anthony PERARD" <anthony.perard@citrix.com>,
"Roger Pau Monn�" <roger.pau@citrix.com>
Subject: Re: [PATCH v3 1/2] libs/light: pass some infos to qemu
Date: Mon, 1 Feb 2021 14:56:42 +0000 [thread overview]
Message-ID: <24600.5802.791792.705035@mariner.uk.xensource.com> (raw)
In-Reply-To: <20210130230300.11664-1-bouyer@netbsd.org>
Manuel Bouyer writes ("[PATCH v3 1/2] libs/light: pass some infos to qemu"):
> Pass bridge name to qemu as command line option
> When starting qemu, set an environnement variable XEN_DOMAIN_ID,
> to be used by qemu helper scripts
> The only functional difference of using the br parameter is that the
> bridge name gets passed to the QEMU script.
> NetBSD doesn't have the ioctl to rename network interfaces implemented, and
> thus cannot rename the interface from tapX to vifX.Y-emu. Only qemu knowns
> the tap interface name, so we need to use the qemu script from qemu itself.
>
> Signed-off-by: Manuel Bouyer <bouyer@netbsd.org>
> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
I think this is a bugfix but it has implications for non-NetBSD
systems and I think it would be best for it to get (or not get) an
explicit release-ack.
I think it is sufficiently low risk to take it now. We don't think
this will cause trouble for other platforms but if it proves to, that
should be fairly obvious and caught in our testing. So:
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
Ian.
prev parent reply other threads:[~2021-02-01 14:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-30 23:02 [PATCH v3 1/2] libs/light: pass some infos to qemu Manuel Bouyer
2021-01-30 23:03 ` [PATCH v3 2/2] Document qemu-ifup on NetBSD Manuel Bouyer
2021-02-01 8:21 ` Roger Pau Monné
2021-02-01 9:37 ` Manuel Bouyer
2021-02-01 10:58 ` Roger Pau Monné
2021-02-01 14:59 ` Ian Jackson
2021-02-01 14:56 ` Ian Jackson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24600.5802.791792.705035@mariner.uk.xensource.com \
--to=iwj@xenproject.org \
--cc=anthony.perard@citrix.com \
--cc=bouyer@netbsd.org \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.