From: Ian Jackson <iwj@xenproject.org>
To: "Roger Pau Monné" <roger.pau@citrix.com>
Cc: Manuel Bouyer <bouyer@antioche.eu.org>,
<xen-devel@lists.xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v3 2/2] Document qemu-ifup on NetBSD
Date: Mon, 1 Feb 2021 14:59:35 +0000 [thread overview]
Message-ID: <24600.5975.179890.232213@mariner.uk.xensource.com> (raw)
In-Reply-To: <YBfevtNorE5OtQVR@Air-de-Roger>
Roger Pau Monné writes ("Re: [PATCH v3 2/2] Document qemu-ifup on NetBSD"):
> On Mon, Feb 01, 2021 at 10:37:47AM +0100, Manuel Bouyer wrote:
> > Well, as a user, I want to know how the scripts are called, so that I can
> > tune them ...
>
> Isn't that information on the header of the script? I would expect
> users that want to modify such script will open it and then the header
> should already lists the parameters.
>
> IMO I would leave the parameters out of this document because we don't
> list them for any other script, so it seems odd to list them for the
> qemu-ifup script only.
I think it is shown there, indeed. That may not be the best place for
this information. But maybe putting it somewhere else should be done
systematically rather than ad hoc. IOW with my maintainer hat on I
don't feel I have a strong opinion.
OTOH from my RM hat
Release-Acked-by: Ian Jackson <iwj@xenproject.org>
since this is a documentation change.
Ian.
next prev parent reply other threads:[~2021-02-01 14:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-30 23:02 [PATCH v3 1/2] libs/light: pass some infos to qemu Manuel Bouyer
2021-01-30 23:03 ` [PATCH v3 2/2] Document qemu-ifup on NetBSD Manuel Bouyer
2021-02-01 8:21 ` Roger Pau Monné
2021-02-01 9:37 ` Manuel Bouyer
2021-02-01 10:58 ` Roger Pau Monné
2021-02-01 14:59 ` Ian Jackson [this message]
2021-02-01 14:56 ` [PATCH v3 1/2] libs/light: pass some infos to qemu Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24600.5975.179890.232213@mariner.uk.xensource.com \
--to=iwj@xenproject.org \
--cc=bouyer@antioche.eu.org \
--cc=roger.pau@citrix.com \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.