All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
To: heiko@sntech.de, linux-rockchip@lists.infradead.org
Cc: robh+dt@kernel.org, kishon@ti.com, vkoul@kernel.org,
	p.zabel@pengutronix.de, yifeng.zhao@rock-chips.com,
	kever.yang@rock-chips.com, cl@rock-chips.com,
	linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Johan Jonker <jbx6244@gmail.com>
Subject: Re: [RFC PATCH v4 0/4] Add Naneng combo PHY support for RK3568
Date: Sat, 11 Dec 2021 20:18:47 +0100	[thread overview]
Message-ID: <2461932.fyNAqVaUXx@archbook> (raw)
In-Reply-To: <20211208185449.16763-1-jbx6244@gmail.com>

On Mittwoch, 8. Dezember 2021 19:54:45 CET Johan Jonker wrote:
> This phy can be used as pcie-phy, usb3-phy, sata-phy or sgmii-phy.
> 
> =============================================
> 
> Changed V4 by Johan Jonker:
>   TEST COMPILED ONLY!
>   Driver not verified with hardware!
>   Produced in the hope that we can get some review progress
>   with this serie for the documents and driver.
>   Use at your own risk!
> 
>   restyle
>   add devm_reset_control_array_get()
>   remove clk structure
>   change refclk DT parse
>   change dev_err message
>   add dot to phrase
>   add ext_refclk variable
>   add enable_ssc variable
>   rename rockchip_combphy_param_write
>   remove param_read
>   replace rockchip-naneng-combphy driver name
> 
>   rename node name
>   remove reset-names
>   move #phy-cells
>   add rockchip,rk3568-pipe-grf
>   add rockchip,rk3568-pipe-phy-grf
> 
> =============================================
> 

Tested-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>

Applied this on top of 5.16-rc4, added the necessary device tree
changes to rk356x.dtsi and rk3566-quartz64-a.dts and ran it on
my Quartz64. I tested PCIe2x1 on the one combphy and SATA on the
other, simultaneously. Devices were detected correctly (with some
hiccups on SATA due to a Quartz64 Model A design issue, but it
was detected eventually) and some transfers were done to ensure
it's stable. It is stable.

Regards,
Nicolas Frattaroli



-- 
linux-phy mailing list
linux-phy@lists.infradead.org
https://lists.infradead.org/mailman/listinfo/linux-phy

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
To: heiko@sntech.de, linux-rockchip@lists.infradead.org
Cc: robh+dt@kernel.org, kishon@ti.com, vkoul@kernel.org,
	p.zabel@pengutronix.de, yifeng.zhao@rock-chips.com,
	kever.yang@rock-chips.com, cl@rock-chips.com,
	linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Johan Jonker <jbx6244@gmail.com>
Subject: Re: [RFC PATCH v4 0/4] Add Naneng combo PHY support for RK3568
Date: Sat, 11 Dec 2021 20:18:47 +0100	[thread overview]
Message-ID: <2461932.fyNAqVaUXx@archbook> (raw)
In-Reply-To: <20211208185449.16763-1-jbx6244@gmail.com>

On Mittwoch, 8. Dezember 2021 19:54:45 CET Johan Jonker wrote:
> This phy can be used as pcie-phy, usb3-phy, sata-phy or sgmii-phy.
> 
> =============================================
> 
> Changed V4 by Johan Jonker:
>   TEST COMPILED ONLY!
>   Driver not verified with hardware!
>   Produced in the hope that we can get some review progress
>   with this serie for the documents and driver.
>   Use at your own risk!
> 
>   restyle
>   add devm_reset_control_array_get()
>   remove clk structure
>   change refclk DT parse
>   change dev_err message
>   add dot to phrase
>   add ext_refclk variable
>   add enable_ssc variable
>   rename rockchip_combphy_param_write
>   remove param_read
>   replace rockchip-naneng-combphy driver name
> 
>   rename node name
>   remove reset-names
>   move #phy-cells
>   add rockchip,rk3568-pipe-grf
>   add rockchip,rk3568-pipe-phy-grf
> 
> =============================================
> 

Tested-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>

Applied this on top of 5.16-rc4, added the necessary device tree
changes to rk356x.dtsi and rk3566-quartz64-a.dts and ran it on
my Quartz64. I tested PCIe2x1 on the one combphy and SATA on the
other, simultaneously. Devices were detected correctly (with some
hiccups on SATA due to a Quartz64 Model A design issue, but it
was detected eventually) and some transfers were done to ensure
it's stable. It is stable.

Regards,
Nicolas Frattaroli



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
To: heiko@sntech.de, linux-rockchip@lists.infradead.org
Cc: robh+dt@kernel.org, kishon@ti.com, vkoul@kernel.org,
	p.zabel@pengutronix.de, yifeng.zhao@rock-chips.com,
	kever.yang@rock-chips.com, cl@rock-chips.com,
	linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Johan Jonker <jbx6244@gmail.com>
Subject: Re: [RFC PATCH v4 0/4] Add Naneng combo PHY support for RK3568
Date: Sat, 11 Dec 2021 20:18:47 +0100	[thread overview]
Message-ID: <2461932.fyNAqVaUXx@archbook> (raw)
In-Reply-To: <20211208185449.16763-1-jbx6244@gmail.com>

On Mittwoch, 8. Dezember 2021 19:54:45 CET Johan Jonker wrote:
> This phy can be used as pcie-phy, usb3-phy, sata-phy or sgmii-phy.
> 
> =============================================
> 
> Changed V4 by Johan Jonker:
>   TEST COMPILED ONLY!
>   Driver not verified with hardware!
>   Produced in the hope that we can get some review progress
>   with this serie for the documents and driver.
>   Use at your own risk!
> 
>   restyle
>   add devm_reset_control_array_get()
>   remove clk structure
>   change refclk DT parse
>   change dev_err message
>   add dot to phrase
>   add ext_refclk variable
>   add enable_ssc variable
>   rename rockchip_combphy_param_write
>   remove param_read
>   replace rockchip-naneng-combphy driver name
> 
>   rename node name
>   remove reset-names
>   move #phy-cells
>   add rockchip,rk3568-pipe-grf
>   add rockchip,rk3568-pipe-phy-grf
> 
> =============================================
> 

Tested-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>

Applied this on top of 5.16-rc4, added the necessary device tree
changes to rk356x.dtsi and rk3566-quartz64-a.dts and ran it on
my Quartz64. I tested PCIe2x1 on the one combphy and SATA on the
other, simultaneously. Devices were detected correctly (with some
hiccups on SATA due to a Quartz64 Model A design issue, but it
was detected eventually) and some transfers were done to ensure
it's stable. It is stable.

Regards,
Nicolas Frattaroli



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>
To: heiko@sntech.de, linux-rockchip@lists.infradead.org
Cc: robh+dt@kernel.org, kishon@ti.com, vkoul@kernel.org,
	p.zabel@pengutronix.de, yifeng.zhao@rock-chips.com,
	kever.yang@rock-chips.com, cl@rock-chips.com,
	linux-phy@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Johan Jonker <jbx6244@gmail.com>
Subject: Re: [RFC PATCH v4 0/4] Add Naneng combo PHY support for RK3568
Date: Sat, 11 Dec 2021 20:18:47 +0100	[thread overview]
Message-ID: <2461932.fyNAqVaUXx@archbook> (raw)
In-Reply-To: <20211208185449.16763-1-jbx6244@gmail.com>

On Mittwoch, 8. Dezember 2021 19:54:45 CET Johan Jonker wrote:
> This phy can be used as pcie-phy, usb3-phy, sata-phy or sgmii-phy.
> 
> =============================================
> 
> Changed V4 by Johan Jonker:
>   TEST COMPILED ONLY!
>   Driver not verified with hardware!
>   Produced in the hope that we can get some review progress
>   with this serie for the documents and driver.
>   Use at your own risk!
> 
>   restyle
>   add devm_reset_control_array_get()
>   remove clk structure
>   change refclk DT parse
>   change dev_err message
>   add dot to phrase
>   add ext_refclk variable
>   add enable_ssc variable
>   rename rockchip_combphy_param_write
>   remove param_read
>   replace rockchip-naneng-combphy driver name
> 
>   rename node name
>   remove reset-names
>   move #phy-cells
>   add rockchip,rk3568-pipe-grf
>   add rockchip,rk3568-pipe-phy-grf
> 
> =============================================
> 

Tested-by: Nicolas Frattaroli <frattaroli.nicolas@gmail.com>

Applied this on top of 5.16-rc4, added the necessary device tree
changes to rk356x.dtsi and rk3566-quartz64-a.dts and ran it on
my Quartz64. I tested PCIe2x1 on the one combphy and SATA on the
other, simultaneously. Devices were detected correctly (with some
hiccups on SATA due to a Quartz64 Model A design issue, but it
was detected eventually) and some transfers were done to ensure
it's stable. It is stable.

Regards,
Nicolas Frattaroli



  parent reply	other threads:[~2021-12-11 19:18 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-08 18:54 [RFC PATCH v4 0/4] Add Naneng combo PHY support for RK3568 Johan Jonker
2021-12-08 18:54 ` Johan Jonker
2021-12-08 18:54 ` Johan Jonker
2021-12-08 18:54 ` Johan Jonker
2021-12-08 18:54 ` [RFC PATCH v4 1/4] dt-bindings: mfd: syscon: add naneng combo phy register compatible Johan Jonker
2021-12-08 18:54   ` Johan Jonker
2021-12-08 18:54   ` Johan Jonker
2021-12-08 18:54   ` Johan Jonker
2021-12-10 22:05   ` Rob Herring
2021-12-10 22:05     ` Rob Herring
2021-12-10 22:05     ` Rob Herring
2021-12-10 22:05     ` Rob Herring
2021-12-08 18:54 ` [RFC PATCH v4 2/4] dt-bindings: phy: rockchip: Add Naneng combo PHY bindings Johan Jonker
2021-12-08 18:54   ` Johan Jonker
2021-12-08 18:54   ` Johan Jonker
2021-12-08 18:54   ` Johan Jonker
2021-12-10 22:05   ` Rob Herring
2021-12-10 22:05     ` Rob Herring
2021-12-10 22:05     ` Rob Herring
2021-12-10 22:05     ` Rob Herring
2021-12-14  8:58   ` Vinod Koul
2021-12-14  8:58     ` Vinod Koul
2021-12-14  8:58     ` Vinod Koul
2021-12-14  8:58     ` Vinod Koul
2021-12-14 12:20     ` Johan Jonker
2021-12-14 12:20       ` Johan Jonker
2021-12-14 12:20       ` Johan Jonker
2021-12-14 12:20       ` Johan Jonker
2021-12-08 18:54 ` [RFC PATCH v4 3/4] phy: rockchip: add naneng combo phy for RK3568 Johan Jonker
2021-12-08 18:54   ` Johan Jonker
2021-12-08 18:54   ` Johan Jonker
2021-12-08 18:54   ` Johan Jonker
2021-12-11 14:06   ` Johan Jonker
2021-12-11 14:06     ` Johan Jonker
2021-12-11 14:06     ` Johan Jonker
2021-12-11 14:06     ` Johan Jonker
2021-12-15 11:06     ` 赵仪峰
2021-12-15 11:06       ` 赵仪峰
2021-12-15 11:06       ` 赵仪峰
2021-12-14  9:11   ` Vinod Koul
2021-12-14  9:11     ` Vinod Koul
2021-12-14  9:11     ` Vinod Koul
2021-12-14  9:11     ` Vinod Koul
2021-12-08 18:54 ` [RFC PATCH v4 4/4] arm64: dts: rockchip: add naneng combo phy nodes for rk3568 Johan Jonker
2021-12-08 18:54   ` Johan Jonker
2021-12-08 18:54   ` Johan Jonker
2021-12-08 18:54   ` Johan Jonker
2021-12-11 19:18 ` Nicolas Frattaroli [this message]
2021-12-11 19:18   ` [RFC PATCH v4 0/4] Add Naneng combo PHY support for RK3568 Nicolas Frattaroli
2021-12-11 19:18   ` Nicolas Frattaroli
2021-12-11 19:18   ` Nicolas Frattaroli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2461932.fyNAqVaUXx@archbook \
    --to=frattaroli.nicolas@gmail.com \
    --cc=cl@rock-chips.com \
    --cc=devicetree@vger.kernel.org \
    --cc=heiko@sntech.de \
    --cc=jbx6244@gmail.com \
    --cc=kever.yang@rock-chips.com \
    --cc=kishon@ti.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-phy@lists.infradead.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=p.zabel@pengutronix.de \
    --cc=robh+dt@kernel.org \
    --cc=vkoul@kernel.org \
    --cc=yifeng.zhao@rock-chips.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.