[XCI] build.git does not work! fails patch apply

[XCI] build.git does not work! fails patch apply

[Tim Moore]

Hi,

Recently noticed that the xenclient git repository has been updated by the guys from Citrix, so I downloaded a fresh copy to try it out:

It seems that the xenclient-xen.pq patchqueue does not match the xenclient-xen tree .. what happened here ?

/usr/bin/make -j1 xenclient-xen
make[1]: Entering directory `/usr/src/build.git'
mkdir -p /usr/src/build.git/repo
git clone  "http://xenbits.xen.org/git-http"/xenclient/xen.git /usr/src/build.git/repo/xenclient-xen
Initialized empty Git repository in /usr/src/build.git/repo/xenclient-xen/.git/
Getting alternates list for http://xenbits.xen.org/git-http/xenclient/xen.git
Getting pack list for http://xenbits.xen.org/git-http/xenclient/xen.git
.....got/walk/got/walk .....
"/usr/src/build.git/scripts/git_checkout.sh" xenclient-xen /usr/src/build.git/repo
master
Initialized empty Git repository in /usr/src/build.git/repo/xenclient-xen-pq/.git/
Getting alternates list for http://xenbits.xen.org/git-http/xenclient/xen-pq.git
got 06011497d8406a37729f53f27a474380eaa912f9
walk 06011497d8406a37729f53f27a474380eaa912f9
Getting pack list for http://xenbits.xen.org/git-http/xenclient/xen-pq.git
.....got/walk/got/walk .....
master
ln: target `' is not a directory: No such file or directory
Applying patch..check-open-pv-log-file
error: patch failed: tools/libxc/xc_dom_core.c:30
error: tools/libxc/xc_dom_core.c: patch does not apply
To force apply this patch, use 'guilt push -f'
make[1]: *** [/usr/src/build.git/repo/xenclient-xen] Error 1
make[1]: Leaving directory `/usr/src/build.git'
make: *** [/usr/src/build.git/build_i686/xenclient-xen-tip/.installed] Error 2

Any help would be appreciated..

Tim

RE: [XCI] build.git does not work! fails patch apply

[Tim Moore]

[-- Attachment #1.1: Type: text/plain, Size: 2906 bytes --]

Hi Daniel,

These problems are still unresolved, it looks like the patchqueue needs re-basing against the source trees.. but unfortunately I've never done this before so wouldn't know where to start. Plus, it's not my code so I am unfamiliar with the conventions ...

I have asked the list for help, just waiting for one of the XCI dev`s to take some time to reply, or even fix it so we can all perform some invaluable testing!

Cheers,
Tim
________________________________
From: Daniel Barden [mailto:daniel.barden@gmail.com]
Sent: 21 July 2009 17:30
To: Tim Moore
Subject: Re: [Xen-devel] [XCI] build.git does not work! fails patch apply

Hi Mr. Moore,

     I just got the same problems that you described on the xen-devel list (both of them, the patch and the ioemu patch)

     Did you perform any workaround to solve these problems or are they still unsolved?

Best Regards,
Daniel Barden
On Sat, Jul 18, 2009 at 3:53 PM, Tim Moore <timothy.moore@expidas.net<mailto:timothy.moore@expidas.net>> wrote:
Hi,

Recently noticed that the xenclient git repository has been updated by the guys from Citrix, so I downloaded a fresh copy to try it out:

It seems that the xenclient-xen.pq patchqueue does not match the xenclient-xen tree .. what happened here ?

/usr/bin/make -j1 xenclient-xen
make[1]: Entering directory `/usr/src/build.git'
mkdir -p /usr/src/build.git/repo
git clone  "http://xenbits.xen.org/git-http"/xenclient/xen.git /usr/src/build.git/repo/xenclient-xen
Initialized empty Git repository in /usr/src/build.git/repo/xenclient-xen/.git/
Getting alternates list for http://xenbits.xen.org/git-http/xenclient/xen.git
Getting pack list for http://xenbits.xen.org/git-http/xenclient/xen.git
.....got/walk/got/walk .....
"/usr/src/build.git/scripts/git_checkout.sh" xenclient-xen /usr/src/build.git/repo
master
Initialized empty Git repository in /usr/src/build.git/repo/xenclient-xen-pq/.git/
Getting alternates list for http://xenbits.xen.org/git-http/xenclient/xen-pq.git
got 06011497d8406a37729f53f27a474380eaa912f9
walk 06011497d8406a37729f53f27a474380eaa912f9
Getting pack list for http://xenbits.xen.org/git-http/xenclient/xen-pq.git
.....got/walk/got/walk .....
master
ln: target `' is not a directory: No such file or directory
Applying patch..check-open-pv-log-file
error: patch failed: tools/libxc/xc_dom_core.c:30
error: tools/libxc/xc_dom_core.c: patch does not apply
To force apply this patch, use 'guilt push -f'
make[1]: *** [/usr/src/build.git/repo/xenclient-xen] Error 1
make[1]: Leaving directory `/usr/src/build.git'
make: *** [/usr/src/build.git/build_i686/xenclient-xen-tip/.installed] Error 2

Any help would be appreciated..

Tim
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com<mailto:Xen-devel@lists.xensource.com>
http://lists.xensource.com/xen-devel


[-- Attachment #1.2: Type: text/html, Size: 7733 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [XCI] build.git does not work! fails patch apply

[Vincent Hanquez]

Tim Moore wrote:
>
> Hi Daniel,
>
>  
>
> These problems are still unresolved, it looks like the patchqueue 
> needs re-basing against the source trees.. but unfortunately I’ve 
> never done this before so wouldn’t know where to start. Plus, it’s not 
> my code so I am unfamiliar with the conventions …
>
>  
>
> I have asked the list for help, just waiting for one of the XCI dev`s 
> to take some time to reply, or even fix it so we can all perform some 
> invaluable testing!
>
Tim, Daniel,

I just pushed all sorts of fixes and change to the trees, can you guys 
try updating and let me know if it does solve the problems you are having.

Also please make sure you do have the latest guilt installed on the 
machine. for example the one shipping
with debian lenny is too old. I think the build required (unfortunately) 
guilt 0.32.

-- 
Vincent

Re: [XCI] build.git does not work! fails patch apply

[Daniel Barden]

[-- Attachment #1.1: Type: text/plain, Size: 758 bytes --]

Hi Vincent,


> I just pushed all sorts of fixes and change to the trees, can you guys try
> updating and let me know if it does solve the problems you are having.


I cloned a fresh copy of XCI, I'm still getting the same error:

    ln: target `' is not a directory: No such file or directory
    Applying patch..check-open-pv-log-file
    error: patch failed: tools/libxc/xc_dom_core.c:30
    error: tools/libxc/xc_dom_core.c: patch does not apply
    To force apply this patch, use 'guilt push -f'

Also please make sure you do have the latest guilt installed on the machine.
> for example the one shipping
> with debian lenny is too old. I think the build required (unfortunately)
> guilt 0.32.


My guilt version is 0.32.1

Best Regards,
Daniel Barden

[-- Attachment #1.2: Type: text/html, Size: 1170 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

RE: [XCI] build.git does not work! fails patch apply

[Tim Moore]

Hi Vincent,

My guilt version is also 0.32.1 

The first problem is with the buildroot .. (Daniel, do you have this problem also?)

########### snippet ##########
mv -f .deps/dbus-bash-completion-helper.Tpo .deps/dbus-bash-completion-helper.Po
grep: /usr/src/build.git/build_i686/staging_dir/usr/src/build.git/build_i686/libglib2-2.15.4/glib/libglib-2.0.la: No such file or directory
/usr/src/build.git/toolchain_build_i686/bin/sed: can't read /usr/src/build.git/build_i686/staging_dir/usr/src/build.git/build_i686/libglib2-2.15.4/glib/libglib-2.0.la: No such file or directory
libtool: link: `/usr/src/build.git/build_i686/staging_dir/usr/src/build.git/build_i686/libglib2-2.15.4/glib/libglib-2.0.la' is not a valid libtool archive
make[5]: *** [libdbus-glib-1.la] Error 1
make[5]: *** Waiting for unfinished jobs....
mv -f .deps/dbus-binding-tool-glib.Tpo .deps/dbus-binding-tool-glib.Po
mv -f .deps/dbus-gparser.Tpo .deps/dbus-gparser.Plo
make[5]: Leaving directory `/usr/src/build.git/build_i686/dbus-glib-0.80/dbus'
make[4]: *** [all-recursive] Error 1
make[4]: Leaving directory `/usr/src/build.git/build_i686/dbus-glib-0.80/dbus'
make[3]: *** [all] Error 2
make[3]: Leaving directory `/usr/src/build.git/build_i686/dbus-glib-0.80/dbus'
make[2]: *** [all-recursive] Error 1
make[2]: Leaving directory `/usr/src/build.git/build_i686/dbus-glib-0.80'
make[1]: *** [all] Error 2
make[1]: Leaving directory `/usr/src/build.git/build_i686/dbus-glib-0.80'
make: *** [/usr/src/build.git/build_i686/dbus-glib-0.80/.compiled] Error 2
########### end snippet ##########

The problem seems to be a duplicated path reference, see:
/usr/src/build.git/build_i686/staging_dir/usr/src/build.git/build_i686/libglib2-2.15.4/glib/libglib-2.0.la

Which can be worked around with:
ln -s /usr/src /usr/src/build.git/build_i686/staging_dir/usr/src
(and then removed immediately)

2) But then same problem with compiling xenclient-xen-tip detailed here: (same problem Daniel is getting)

http://lists.xensource.com/archives/html/xen-devel/2009-07/msg00673.html

3) also xenclient-ioemu fails with exactly the same problem detailed here:

http://lists.xensource.com/archives/html/xen-devel/2009-07/msg00674.html

Hope you can find a resolution to these problems, and thanks for your help!

Cheers,
Tim


________________________________________
From: Vincent Hanquez [vincent.hanquez@eu.citrix.com]
Sent: 22 July 2009 16:06
To: Tim Moore
Cc: 'Daniel Barden'; xen-devel@lists.xensource.com
Subject: Re: [Xen-devel] [XCI] build.git does not work! fails patch apply

Tim Moore wrote:
>
> Hi Daniel,
>
>
>
> These problems are still unresolved, it looks like the patchqueue
> needs re-basing against the source trees.. but unfortunately I’ve
> never done this before so wouldn’t know where to start. Plus, it’s not
> my code so I am unfamiliar with the conventions …
>
>
>
> I have asked the list for help, just waiting for one of the XCI dev`s
> to take some time to reply, or even fix it so we can all perform some
> invaluable testing!
>
Tim, Daniel,

I just pushed all sorts of fixes and change to the trees, can you guys
try updating and let me know if it does solve the problems you are having.

Also please make sure you do have the latest guilt installed on the
machine. for example the one shipping
with debian lenny is too old. I think the build required (unfortunately)
guilt 0.32.

--
Vincent

Re: [XCI] build.git does not work! fails patch apply

[Vincent Hanquez]

Tim Moore wrote:
> Hi Vincent,
> 
> My guilt version is also 0.32.1 
> 
> The first problem is with the buildroot .. (Daniel, do you have this problem also?)
> 
> ########### snippet ##########
> mv -f .deps/dbus-bash-completion-helper.Tpo .deps/dbus-bash-completion-helper.Po
> grep: /usr/src/build.git/build_i686/staging_dir/usr/src/build.git/build_i686/libglib2-2.15.4/glib/libglib-2.0.la: No such file or directory
> /usr/src/build.git/toolchain_build_i686/bin/sed: can't read /usr/src/build.git/build_i686/staging_dir/usr/src/build.git/build_i686/libglib2-2.15.4/glib/libglib-2.0.la: No such file or directory
> libtool: link: `/usr/src/build.git/build_i686/staging_dir/usr/src/build.git/build_i686/libglib2-2.15.4/glib/libglib-2.0.la' is not a valid libtool archive
> make[5]: *** [libdbus-glib-1.la] Error 1
> make[5]: *** Waiting for unfinished jobs....
> mv -f .deps/dbus-binding-tool-glib.Tpo .deps/dbus-binding-tool-glib.Po
> mv -f .deps/dbus-gparser.Tpo .deps/dbus-gparser.Plo
> make[5]: Leaving directory `/usr/src/build.git/build_i686/dbus-glib-0.80/dbus'
> make[4]: *** [all-recursive] Error 1
> make[4]: Leaving directory `/usr/src/build.git/build_i686/dbus-glib-0.80/dbus'
> make[3]: *** [all] Error 2
> make[3]: Leaving directory `/usr/src/build.git/build_i686/dbus-glib-0.80/dbus'
> make[2]: *** [all-recursive] Error 1
> make[2]: Leaving directory `/usr/src/build.git/build_i686/dbus-glib-0.80'
> make[1]: *** [all] Error 2
> make[1]: Leaving directory `/usr/src/build.git/build_i686/dbus-glib-0.80'
> make: *** [/usr/src/build.git/build_i686/dbus-glib-0.80/.compiled] Error 2
> ########### end snippet ##########
> 
> The problem seems to be a duplicated path reference, see:
> /usr/src/build.git/build_i686/staging_dir/usr/src/build.git/build_i686/libglib2-2.15.4/glib/libglib-2.0.la
> 
> Which can be worked around with:
> ln -s /usr/src /usr/src/build.git/build_i686/staging_dir/usr/src
> (and then removed immediately)

this is quite ugly. I'll have a look this morning, but i'm not sure why 
we're not seeing this one.

> 2) But then same problem with compiling xenclient-xen-tip detailed here: (same problem Daniel is getting)
> 
> http://lists.xensource.com/archives/html/xen-devel/2009-07/msg00673.html

see my reply to daniel and col sanders. hopefully once and for all fixed 
now.

> 3) also xenclient-ioemu fails with exactly the same problem detailed here:
> 
> http://lists.xensource.com/archives/html/xen-devel/2009-07/msg00674.html

same problems than with the xen repo. patchqueue applied to the main 
repository by mistake, and fixed manually only in one place.

also want to mentions that since yesterday night, we have an automated 
building daemon now on XCI, which hopefully means that we will catch any 
glitches before any of you experience it.

-- 
Vincent

Re: [XCI] build.git does not work! fails patch apply

[Daniel Barden]

[-- Attachment #1.1: Type: text/plain, Size: 2444 bytes --]

Hi Vincent, Tim

On Thu, Jul 23, 2009 at 6:01 AM, Vincent Hanquez <
vincent.hanquez@eu.citrix.com> wrote:

> Tim Moore wrote:
>
>> Hi Vincent,
>>
>> My guilt version is also 0.32.1
>> The first problem is with the buildroot .. (Daniel, do you have this
>> problem also?)
>>
>> ########### snippet ##########
>> mv -f .deps/dbus-bash-completion-helper.Tpo
>> .deps/dbus-bash-completion-helper.Po
>> grep:
>> /usr/src/build.git/build_i686/staging_dir/usr/src/build.git/build_i686/libglib2-2.15.4/glib/
>> libglib-2.0.la: No such file or directory
>> /usr/src/build.git/toolchain_build_i686/bin/sed: can't read
>> /usr/src/build.git/build_i686/staging_dir/usr/src/build.git/build_i686/libglib2-2.15.4/glib/
>> libglib-2.0.la: No such file or directory
>> libtool: link:
>> `/usr/src/build.git/build_i686/staging_dir/usr/src/build.git/build_i686/libglib2-2.15.4/glib/
>> libglib-2.0.la' is not a valid libtool archive
>> make[5]: *** [libdbus-glib-1.la] Error 1
>> make[5]: *** Waiting for unfinished jobs....
>> mv -f .deps/dbus-binding-tool-glib.Tpo .deps/dbus-binding-tool-glib.Po
>> mv -f .deps/dbus-gparser.Tpo .deps/dbus-gparser.Plo
>> make[5]: Leaving directory
>> `/usr/src/build.git/build_i686/dbus-glib-0.80/dbus'
>> make[4]: *** [all-recursive] Error 1
>> make[4]: Leaving directory
>> `/usr/src/build.git/build_i686/dbus-glib-0.80/dbus'
>> make[3]: *** [all] Error 2
>> make[3]: Leaving directory
>> `/usr/src/build.git/build_i686/dbus-glib-0.80/dbus'
>> make[2]: *** [all-recursive] Error 1
>> make[2]: Leaving directory `/usr/src/build.git/build_i686/dbus-glib-0.80'
>> make[1]: *** [all] Error 2
>> make[1]: Leaving directory `/usr/src/build.git/build_i686/dbus-glib-0.80'
>> make: *** [/usr/src/build.git/build_i686/dbus-glib-0.80/.compiled] Error 2
>> ########### end snippet ##########
>>
>>
> this is quite ugly. I'll have a look this morning, but i'm not sure why
> we're not seeing this one.


I didn't get this one. I had some problems with uClibc that I'm working now
("architecture doesn't seem to support mmap", but it's uClibc stuff).

I've already done some other builds and don't recall this problem
specifically. If I get this one, I'll let you know.

also want to mentions that since yesterday night, we have an automated
> building daemon now on XCI, which hopefully means that we will catch any
> glitches before any of you experience it.
>
>
That's very good news. Thank you very much.

Best Regards,
Daniel Barden

[-- Attachment #1.2: Type: text/html, Size: 3431 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [XCI] build.git does not work! fails patch apply

[iicolsandersii]

Perfectly compiled.  

Thanks for all the hard work Vincent.

--
Col. Sanders


Vincent Hanquez-5 wrote:
> 
> 
> same problems than with the xen repo. patchqueue applied to the main 
> repository by mistake, and fixed manually only in one place.
> 
> also want to mentions that since yesterday night, we have an automated 
> building daemon now on XCI, which hopefully means that we will catch any 
> glitches before any of you experience it.
> 
> -- 
> Vincent
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
> 
> 

-- 
View this message in context: http://www.nabble.com/-XCI--build.git-does-not-work%21-fails-patch-apply-tp24550804p24629854.html
Sent from the Xen - Dev mailing list archive at Nabble.com.

Re: [XCI] build.git does not work! fails patch apply

[Vincent Hanquez]

iicolsandersii wrote:
> Perfectly compiled.  
>   
that's good to hear.
> Thanks for all the hard work Vincent.
>   
you're welcome. although i want to mention i'm not the only one fixing 
the build, so i'll extend the thanks to other people in my team working 
on it too.

-- 
Vincent

Re: [XCI] build.git does not work! fails patch apply

[iicolsandersii]

Vincent,

I did the following... 

# cp config/xenclient_config ./.config
# make menuconfig ---- I do not make any changes in the menuconfig
# make

Everything is perfect till I get this error...

ln: target `' is not a directory: No such file or directory
Applying patch..check-open-pv-log-file
error: patch failed: tools/libxc/xc_dom_core.c:30
error: tools/libxc/xc_dom_core.c: patch does not apply
To force apply this patch, use 'guilt push -f'
make[1]: *** [/root/build/repo/xenclient-xen] Error 1
make[1]: Leaving directory `/root/build'
make: *** [/root/build/build_i686/xenclient-xen-tip/.installed] Error 2

Any help would be great.

Thanks in advanced.

--
Col. Sanders


Vincent Hanquez-5 wrote:
> 
> Tim Moore wrote:
>>
>> Hi Daniel,
>>
>>  
>>
>> These problems are still unresolved, it looks like the patchqueue 
>> needs re-basing against the source trees.. but unfortunately I’ve 
>> never done this before so wouldn’t know where to start. Plus, it’s not 
>> my code so I am unfamiliar with the conventions …
>>
>>  
>>
>> I have asked the list for help, just waiting for one of the XCI dev`s 
>> to take some time to reply, or even fix it so we can all perform some 
>> invaluable testing!
>>
> Tim, Daniel,
> 
> I just pushed all sorts of fixes and change to the trees, can you guys 
> try updating and let me know if it does solve the problems you are having.
> 
> Also please make sure you do have the latest guilt installed on the 
> machine. for example the one shipping
> with debian lenny is too old. I think the build required (unfortunately) 
> guilt 0.32.
> 
> -- 
> Vincent
> 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
> 
> 

-- 
View this message in context: http://www.nabble.com/-XCI--build.git-does-not-work%21-fails-patch-apply-tp24550804p24611864.html
Sent from the Xen - Dev mailing list archive at Nabble.com.

Re: [XCI] build.git does not work! fails patch apply

[Vincent Hanquez]

iicolsandersii wrote:
> Vincent,
> 
> I did the following... 
> 
> # cp config/xenclient_config ./.config
> # make menuconfig ---- I do not make any changes in the menuconfig
> # make
> 
> Everything is perfect till I get this error...
> 
> ln: target `' is not a directory: No such file or directory
> Applying patch..check-open-pv-log-file
> error: patch failed: tools/libxc/xc_dom_core.c:30
> error: tools/libxc/xc_dom_core.c: patch does not apply
> To force apply this patch, use 'guilt push -f'
> make[1]: *** [/root/build/repo/xenclient-xen] Error 1
> make[1]: Leaving directory `/root/build'
> make: *** [/root/build/build_i686/xenclient-xen-tip/.installed] Error 2

Ok, this one should be fixed. we pushed the patchqueue by mistake from 
xen-pq to xen tree, but it was fixed manually in only one place, and the 
other copies we had didn't want to update to a previous commit unless 
forced to do so (git doesn't lose data). we checked manually that xen is 
now at the correct revision.

-- 
Vincent

Re: [XCI] build.git does not work! fails patch apply

[Daniel Barden]

[-- Attachment #1.1: Type: text/plain, Size: 1031 bytes --]

Hi,

About the following error:

>
> ln: target `' is not a directory: No such file or directory
> Applying patch..check-open-pv-log-file
> error: patch failed: tools/libxc/xc_dom_core.c:30
> error: tools/libxc/xc_dom_core.c: patch does not apply
> To force apply this patch, use 'guilt push -f'
> make[1]: *** [/root/build/repo/xenclient-xen] Error 1
> make[1]: Leaving directory `/root/build'
> make: *** [/root/build/build_i686/xenclient-xen-tip/.installed] Error 2
>

First of all, the patches are now working, they are being applied. Thanks.

About the 'ln' message (ln: target `' is not a directory: No such file or
directory), it is generated by a script located at
"scripts/git_checkout.sh". There is a function "git_get_pq" that has a
undefined variable $checkout, that is used in the 'ln' command (line 101).

I didn't take my time to solve it, but, in a first glance (I haven't
finished my build yet) caused me no problems. Probably this $checkout should
contain "master", but I'm not sure.

Best regards,
Daniel Barden

[-- Attachment #1.2: Type: text/html, Size: 1407 bytes --]

[-- Attachment #2: Type: text/plain, Size: 138 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xensource.com
http://lists.xensource.com/xen-devel

Re: [XCI] build.git does not work! fails patch apply

[Jean Guyader]

2009/7/23 Daniel Barden <daniel.barden@gmail.com>:
> Hi,
>
> About the following error:
>>
>> ln: target `' is not a directory: No such file or directory
>> Applying patch..check-open-pv-log-file
>> error: patch failed: tools/libxc/xc_dom_core.c:30
>> error: tools/libxc/xc_dom_core.c: patch does not apply
>> To force apply this patch, use 'guilt push -f'
>> make[1]: *** [/root/build/repo/xenclient-xen] Error 1
>> make[1]: Leaving directory `/root/build'
>> make: *** [/root/build/build_i686/xenclient-xen-tip/.installed] Error 2
>
> First of all, the patches are now working, they are being applied. Thanks.
>
> About the 'ln' message (ln: target `' is not a directory: No such file or
> directory), it is generated by a script located at
> "scripts/git_checkout.sh". There is a function "git_get_pq" that has a
> undefined variable $checkout, that is used in the 'ln' command (line 101).
>
> I didn't take my time to solve it, but, in a first glance (I haven't
> finished my build yet) caused me no problems. Probably this $checkout should
> contain "master", but I'm not sure.
>

This is not a fatal error, I should probably fix that one.

Jean