From: "Andreas K. Hüttel" <dilfridge@gentoo.org>
To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Cc: palmer@dabbelt.com, bmeng.cn@gmail.com,
Alistair Francis <alistair.francis@wdc.com>,
alistair23@gmail.com
Subject: Re: [PATCH v2 1/1] linux-user/signal: Decode waitid si_code
Date: Wed, 20 Jan 2021 22:12:30 +0200 [thread overview]
Message-ID: <24791910.1r3eYUQgxm@farino> (raw)
In-Reply-To: <1fb2d56aa23a81f4473e638abe9e2d78c09a3d5b.1611080607.git.alistair.francis@wdc.com>
[-- Attachment #1: Type: text/plain, Size: 1506 bytes --]
>
> This patch just passes the waitid status directly back to the guest.
>
This works at least as well as the previous versions, so ++ from me.
Will do more testing over the next days to see if it maybe also improves the
additional oddities I observed.
Tested-by: Andreas K. Hüttel <dilfridge@gentoo.org>
> Buglink: https://bugs.launchpad.net/qemu/+bug/1906193
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
> v2:
> - Set tinfo->_sifields._sigchld._status directly from status
>
> linux-user/signal.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/linux-user/signal.c b/linux-user/signal.c
> index 73de934c65..7eecec46c4 100644
> --- a/linux-user/signal.c
> +++ b/linux-user/signal.c
> @@ -349,8 +349,7 @@ static inline void
> host_to_target_siginfo_noswap(target_siginfo_t *tinfo, case TARGET_SIGCHLD:
> tinfo->_sifields._sigchld._pid = info->si_pid;
> tinfo->_sifields._sigchld._uid = info->si_uid;
> - tinfo->_sifields._sigchld._status
> - = host_to_target_waitstatus(info->si_status);
> + tinfo->_sifields._sigchld._status = info->si_status;
> tinfo->_sifields._sigchld._utime = info->si_utime;
> tinfo->_sifields._sigchld._stime = info->si_stime;
> si_type = QEMU_SI_CHLD;
--
Andreas K. Hüttel
dilfridge@gentoo.org
Gentoo Linux developer
(council, qa, toolchain, base-system, perl, libreoffice)
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 963 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: "Andreas K. Hüttel" <dilfridge@gentoo.org>
To: qemu-devel@nongnu.org, qemu-riscv@nongnu.org
Cc: alistair.francis@wdc.com, bmeng.cn@gmail.com, palmer@dabbelt.com,
alistair23@gmail.com, Alistair Francis <alistair.francis@wdc.com>
Subject: Re: [PATCH v2 1/1] linux-user/signal: Decode waitid si_code
Date: Wed, 20 Jan 2021 22:12:30 +0200 [thread overview]
Message-ID: <24791910.1r3eYUQgxm@farino> (raw)
In-Reply-To: <1fb2d56aa23a81f4473e638abe9e2d78c09a3d5b.1611080607.git.alistair.francis@wdc.com>
[-- Attachment #1: Type: text/plain, Size: 1506 bytes --]
>
> This patch just passes the waitid status directly back to the guest.
>
This works at least as well as the previous versions, so ++ from me.
Will do more testing over the next days to see if it maybe also improves the
additional oddities I observed.
Tested-by: Andreas K. Hüttel <dilfridge@gentoo.org>
> Buglink: https://bugs.launchpad.net/qemu/+bug/1906193
> Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
> ---
> v2:
> - Set tinfo->_sifields._sigchld._status directly from status
>
> linux-user/signal.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/linux-user/signal.c b/linux-user/signal.c
> index 73de934c65..7eecec46c4 100644
> --- a/linux-user/signal.c
> +++ b/linux-user/signal.c
> @@ -349,8 +349,7 @@ static inline void
> host_to_target_siginfo_noswap(target_siginfo_t *tinfo, case TARGET_SIGCHLD:
> tinfo->_sifields._sigchld._pid = info->si_pid;
> tinfo->_sifields._sigchld._uid = info->si_uid;
> - tinfo->_sifields._sigchld._status
> - = host_to_target_waitstatus(info->si_status);
> + tinfo->_sifields._sigchld._status = info->si_status;
> tinfo->_sifields._sigchld._utime = info->si_utime;
> tinfo->_sifields._sigchld._stime = info->si_stime;
> si_type = QEMU_SI_CHLD;
--
Andreas K. Hüttel
dilfridge@gentoo.org
Gentoo Linux developer
(council, qa, toolchain, base-system, perl, libreoffice)
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 963 bytes --]
next prev parent reply other threads:[~2021-01-20 20:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-19 18:24 [PATCH v2 1/1] linux-user/signal: Decode waitid si_code Alistair Francis
2021-01-19 18:24 ` Alistair Francis
2021-01-20 20:12 ` Andreas K. Hüttel [this message]
2021-01-20 20:12 ` Andreas K. Hüttel
2021-01-21 15:15 ` Andreas K. Hüttel
2021-01-21 15:15 ` Andreas K. Hüttel
2021-02-12 21:44 ` Alistair Francis
2021-02-12 21:44 ` Alistair Francis
2021-02-13 16:08 ` Laurent Vivier
2021-02-13 16:08 ` Laurent Vivier
2021-02-13 16:15 ` Laurent Vivier
2021-02-13 16:15 ` Laurent Vivier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24791910.1r3eYUQgxm@farino \
--to=dilfridge@gentoo.org \
--cc=alistair.francis@wdc.com \
--cc=alistair23@gmail.com \
--cc=bmeng.cn@gmail.com \
--cc=palmer@dabbelt.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.