* [PATCH] drm/amdkfd: use max() and min() to make code cleaner
@ 2021-12-15 8:52 ` cgel.zte
0 siblings, 0 replies; 5+ messages in thread
From: cgel.zte @ 2021-12-15 8:52 UTC (permalink / raw)
To: Felix.Kuehling
Cc: airlied, Zeal Robot, Xinhui.Pan, linux-kernel, amd-gfx,
Changcheng Deng, dri-devel, daniel, alexander.deucher,
christian.koenig
From: Changcheng Deng <deng.changcheng@zte.com.cn>
Use max() and min() in order to make code cleaner.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
---
drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
index 7e92dcea4ce8..c6d3555b5be6 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
@@ -2254,8 +2254,8 @@ svm_range_cpu_invalidate_pagetables(struct mmu_interval_notifier *mni,
start = mni->interval_tree.start;
last = mni->interval_tree.last;
- start = (start > range->start ? start : range->start) >> PAGE_SHIFT;
- last = (last < (range->end - 1) ? last : range->end - 1) >> PAGE_SHIFT;
+ start = max(start, range->start) >> PAGE_SHIFT;
+ last = min(last, range->end - 1) >> PAGE_SHIFT;
pr_debug("[0x%lx 0x%lx] range[0x%lx 0x%lx] notifier[0x%lx 0x%lx] %d\n",
start, last, range->start >> PAGE_SHIFT,
(range->end - 1) >> PAGE_SHIFT,
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] drm/amdkfd: use max() and min() to make code cleaner
@ 2021-12-15 8:52 ` cgel.zte
0 siblings, 0 replies; 5+ messages in thread
From: cgel.zte @ 2021-12-15 8:52 UTC (permalink / raw)
To: Felix.Kuehling
Cc: airlied, Zeal Robot, Xinhui.Pan, linux-kernel, amd-gfx,
Changcheng Deng, dri-devel, alexander.deucher, christian.koenig
From: Changcheng Deng <deng.changcheng@zte.com.cn>
Use max() and min() in order to make code cleaner.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
---
drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
index 7e92dcea4ce8..c6d3555b5be6 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
@@ -2254,8 +2254,8 @@ svm_range_cpu_invalidate_pagetables(struct mmu_interval_notifier *mni,
start = mni->interval_tree.start;
last = mni->interval_tree.last;
- start = (start > range->start ? start : range->start) >> PAGE_SHIFT;
- last = (last < (range->end - 1) ? last : range->end - 1) >> PAGE_SHIFT;
+ start = max(start, range->start) >> PAGE_SHIFT;
+ last = min(last, range->end - 1) >> PAGE_SHIFT;
pr_debug("[0x%lx 0x%lx] range[0x%lx 0x%lx] notifier[0x%lx 0x%lx] %d\n",
start, last, range->start >> PAGE_SHIFT,
(range->end - 1) >> PAGE_SHIFT,
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] drm/amdkfd: use max() and min() to make code cleaner
@ 2021-12-15 8:52 ` cgel.zte
0 siblings, 0 replies; 5+ messages in thread
From: cgel.zte @ 2021-12-15 8:52 UTC (permalink / raw)
To: Felix.Kuehling
Cc: alexander.deucher, christian.koenig, Xinhui.Pan, airlied, daniel,
amd-gfx, dri-devel, linux-kernel, Changcheng Deng, Zeal Robot
From: Changcheng Deng <deng.changcheng@zte.com.cn>
Use max() and min() in order to make code cleaner.
Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Changcheng Deng <deng.changcheng@zte.com.cn>
---
drivers/gpu/drm/amd/amdkfd/kfd_svm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
index 7e92dcea4ce8..c6d3555b5be6 100644
--- a/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
+++ b/drivers/gpu/drm/amd/amdkfd/kfd_svm.c
@@ -2254,8 +2254,8 @@ svm_range_cpu_invalidate_pagetables(struct mmu_interval_notifier *mni,
start = mni->interval_tree.start;
last = mni->interval_tree.last;
- start = (start > range->start ? start : range->start) >> PAGE_SHIFT;
- last = (last < (range->end - 1) ? last : range->end - 1) >> PAGE_SHIFT;
+ start = max(start, range->start) >> PAGE_SHIFT;
+ last = min(last, range->end - 1) >> PAGE_SHIFT;
pr_debug("[0x%lx 0x%lx] range[0x%lx 0x%lx] notifier[0x%lx 0x%lx] %d\n",
start, last, range->start >> PAGE_SHIFT,
(range->end - 1) >> PAGE_SHIFT,
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amdkfd: use max() and min() to make code cleaner
2021-12-15 8:52 ` cgel.zte
@ 2021-12-16 14:52 ` philip yang
-1 siblings, 0 replies; 5+ messages in thread
From: philip yang @ 2021-12-16 14:52 UTC (permalink / raw)
To: cgel.zte, Felix.Kuehling
Cc: airlied, Zeal Robot, Xinhui.Pan, linux-kernel, amd-gfx,
Changcheng Deng, dri-devel, daniel, alexander.deucher,
christian.koenig
[-- Attachment #1: Type: text/html, Size: 2217 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drm/amdkfd: use max() and min() to make code cleaner
@ 2021-12-16 14:52 ` philip yang
0 siblings, 0 replies; 5+ messages in thread
From: philip yang @ 2021-12-16 14:52 UTC (permalink / raw)
To: cgel.zte, Felix.Kuehling
Cc: airlied, Zeal Robot, Xinhui.Pan, linux-kernel, amd-gfx,
Changcheng Deng, dri-devel, alexander.deucher, christian.koenig
[-- Attachment #1: Type: text/html, Size: 2217 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2021-12-16 14:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-12-15 8:52 [PATCH] drm/amdkfd: use max() and min() to make code cleaner cgel.zte
2021-12-15 8:52 ` cgel.zte
2021-12-15 8:52 ` cgel.zte
2021-12-16 14:52 ` philip yang
2021-12-16 14:52 ` philip yang
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.