From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Timo Sigurdsson <public_timo.s@silentcreek.de>,
axboe@kernel.dk, mripard@kernel.org, wens@csie.org,
jernej.skrabec@siol.net, linux-ide@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: oliver@schinagl.nl, stable@vger.kernel.org
Subject: Re: [PATCH] ata: ahci_sunxi: Disable DIPM
Date: Wed, 28 Apr 2021 11:40:44 +0300 [thread overview]
Message-ID: <24eb672c-9772-4e3f-e3de-0fe3390c659f@gmail.com> (raw)
In-Reply-To: <20210427230537.21423-1-public_timo.s@silentcreek.de>
Hello!
On 28.04.2021 2:05, Timo Sigurdsson wrote:
> DIPM is unsupported or broken on sunxi. Trying to enable the power
> management policy med_power_with_dipm on an Allwinner A20 SoC based board
> leads to immediate I/O errors and the attached SATA disk disappears from
> the /dev filesystem. A reset (power cycle) is required to make the SATA
> controller or disk work again. The A10 and A20 SoC data sheets and manuals
> don't mention DIPM at all [1], so it's fair to assume that it's simply not
> supported. But even if it were, it should be considered broken and best be
^ was
> disabled in the ahci_sunxi driver.
>
> Fixes: c5754b5220f0 ("ARM: sunxi: Add support for Allwinner SUNXi SoCs sata to ahci_platform")
The "Fixes:" tag should immediately precede the signoff tag...
> [1] https://github.com/allwinner-zh/documents/tree/master/
And this line should be immediately after the patch description.
> Signed-off-by: Timo Sigurdsson <public_timo.s@silentcreek.de>
> Tested-by: Timo Sigurdsson <public_timo.s@silentcreek.de>
[...]
MBR, Sergei
WARNING: multiple messages have this Message-ID (diff)
From: Sergei Shtylyov <sergei.shtylyov@gmail.com>
To: Timo Sigurdsson <public_timo.s@silentcreek.de>,
axboe@kernel.dk, mripard@kernel.org, wens@csie.org,
jernej.skrabec@siol.net, linux-ide@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org
Cc: oliver@schinagl.nl, stable@vger.kernel.org
Subject: Re: [PATCH] ata: ahci_sunxi: Disable DIPM
Date: Wed, 28 Apr 2021 11:40:44 +0300 [thread overview]
Message-ID: <24eb672c-9772-4e3f-e3de-0fe3390c659f@gmail.com> (raw)
In-Reply-To: <20210427230537.21423-1-public_timo.s@silentcreek.de>
Hello!
On 28.04.2021 2:05, Timo Sigurdsson wrote:
> DIPM is unsupported or broken on sunxi. Trying to enable the power
> management policy med_power_with_dipm on an Allwinner A20 SoC based board
> leads to immediate I/O errors and the attached SATA disk disappears from
> the /dev filesystem. A reset (power cycle) is required to make the SATA
> controller or disk work again. The A10 and A20 SoC data sheets and manuals
> don't mention DIPM at all [1], so it's fair to assume that it's simply not
> supported. But even if it were, it should be considered broken and best be
^ was
> disabled in the ahci_sunxi driver.
>
> Fixes: c5754b5220f0 ("ARM: sunxi: Add support for Allwinner SUNXi SoCs sata to ahci_platform")
The "Fixes:" tag should immediately precede the signoff tag...
> [1] https://github.com/allwinner-zh/documents/tree/master/
And this line should be immediately after the patch description.
> Signed-off-by: Timo Sigurdsson <public_timo.s@silentcreek.de>
> Tested-by: Timo Sigurdsson <public_timo.s@silentcreek.de>
[...]
MBR, Sergei
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-04-28 8:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-27 23:05 [PATCH] ata: ahci_sunxi: Disable DIPM Timo Sigurdsson
2021-04-27 23:05 ` Timo Sigurdsson
2021-04-28 5:59 ` Greg KH
2021-04-28 5:59 ` Greg KH
2021-04-28 8:40 ` Sergei Shtylyov [this message]
2021-04-28 8:40 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24eb672c-9772-4e3f-e3de-0fe3390c659f@gmail.com \
--to=sergei.shtylyov@gmail.com \
--cc=axboe@kernel.dk \
--cc=jernej.skrabec@siol.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=mripard@kernel.org \
--cc=oliver@schinagl.nl \
--cc=public_timo.s@silentcreek.de \
--cc=stable@vger.kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.