All of lore.kernel.org
 help / color / mirror / Atom feed
From: Roger Quadros <rogerq@kernel.org>
To: "Nori, Sekhar" <nsekhar@ti.com>
Cc: bgolaszewski@baylibre.com, lokeshvutla@ti.com,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH v2] ARM: dts: da850-evm: Change aemif node status from "ok" to "okay"
Date: Mon, 25 Oct 2021 10:37:27 +0300	[thread overview]
Message-ID: <24f15759-62a8-e341-b03c-348e7e3cd295@kernel.org> (raw)
In-Reply-To: <20210825161502.ap2clalwfljezoqk@perfume>

Hi Sekhar,

On 25/08/2021 19:15, Nishanth Menon wrote:
> On 13:55-20210824, Roger Quadros wrote:
>> As per Device Tree Specification [1], the status parameter of nodes can
>> be "okay", "disabled", etc. "ok" is not a valid parameter.
>>
>> U-boot Driver Model does not recognize status="ok" either and treats
>> the node as disabled.
> 
> ^^ the above comment might be fine to indicate the side effect of
> non-compliance
> 
>>
>> [1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3
>>
>> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> 
> Reviewed-by: Nishanth Menon <nm@ti.com>

Could you please pick this one if not too late for -next. Thanks.

> 
>> ---
>> Changelog:
>> v2
>> -refer to DT spec instead of schema in commit log.
>>
>>  arch/arm/boot/dts/da850-evm.dts | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
>> index 87c517d65f62..9dc79b5977bf 100644
>> --- a/arch/arm/boot/dts/da850-evm.dts
>> +++ b/arch/arm/boot/dts/da850-evm.dts
>> @@ -415,7 +415,7 @@
>>  &aemif {
>>  	pinctrl-names = "default";
>>  	pinctrl-0 = <&nand_pins>;
>> -	status = "ok";
>> +	status = "okay";
>>  	cs3 {
>>  		#address-cells = <2>;
>>  		#size-cells = <1>;
>> -- 
>> 2.17.1
>>
> 

--
cheers,
-roger

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Roger Quadros <rogerq@kernel.org>
To: "Nori, Sekhar" <nsekhar@ti.com>
Cc: bgolaszewski@baylibre.com, lokeshvutla@ti.com,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH v2] ARM: dts: da850-evm: Change aemif node status from "ok" to "okay"
Date: Mon, 25 Oct 2021 10:37:27 +0300	[thread overview]
Message-ID: <24f15759-62a8-e341-b03c-348e7e3cd295@kernel.org> (raw)
In-Reply-To: <20210825161502.ap2clalwfljezoqk@perfume>

Hi Sekhar,

On 25/08/2021 19:15, Nishanth Menon wrote:
> On 13:55-20210824, Roger Quadros wrote:
>> As per Device Tree Specification [1], the status parameter of nodes can
>> be "okay", "disabled", etc. "ok" is not a valid parameter.
>>
>> U-boot Driver Model does not recognize status="ok" either and treats
>> the node as disabled.
> 
> ^^ the above comment might be fine to indicate the side effect of
> non-compliance
> 
>>
>> [1] https://github.com/devicetree-org/devicetree-specification/releases/tag/v0.3
>>
>> Signed-off-by: Roger Quadros <rogerq@kernel.org>
> 
> Reviewed-by: Nishanth Menon <nm@ti.com>

Could you please pick this one if not too late for -next. Thanks.

> 
>> ---
>> Changelog:
>> v2
>> -refer to DT spec instead of schema in commit log.
>>
>>  arch/arm/boot/dts/da850-evm.dts | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/da850-evm.dts b/arch/arm/boot/dts/da850-evm.dts
>> index 87c517d65f62..9dc79b5977bf 100644
>> --- a/arch/arm/boot/dts/da850-evm.dts
>> +++ b/arch/arm/boot/dts/da850-evm.dts
>> @@ -415,7 +415,7 @@
>>  &aemif {
>>  	pinctrl-names = "default";
>>  	pinctrl-0 = <&nand_pins>;
>> -	status = "ok";
>> +	status = "okay";
>>  	cs3 {
>>  		#address-cells = <2>;
>>  		#size-cells = <1>;
>> -- 
>> 2.17.1
>>
> 

--
cheers,
-roger

  reply	other threads:[~2021-10-25  7:38 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-24 10:55 [PATCH v2] ARM: dts: da850-evm: Change aemif node status from "ok" to "okay" Roger Quadros
2021-08-24 10:55 ` Roger Quadros
2021-08-25 16:15 ` Nishanth Menon
2021-08-25 16:15   ` Nishanth Menon
2021-10-25  7:37   ` Roger Quadros [this message]
2021-10-25  7:37     ` Roger Quadros

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24f15759-62a8-e341-b03c-348e7e3cd295@kernel.org \
    --to=rogerq@kernel.org \
    --cc=bgolaszewski@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lokeshvutla@ti.com \
    --cc=nm@ti.com \
    --cc=nsekhar@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.