From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: linux-sunxi@googlegroups.com, Pablo Greco <pgreco@centosproject.org>
Cc: devicetree@vger.kernel.org,
Pablo Greco <pgreco@centosproject.org>,
Maxime Ripard <mripard@kernel.org>,
linux-kernel@vger.kernel.org, Hans de Goede <hdegoede@redhat.com>,
Chen-Yu Tsai <wens@csie.org>, Rob Herring <robh+dt@kernel.org>,
linux-arm-kernel@lists.infradead.org,
Icenowy Zheng <icenowy@aosc.io>
Subject: Re: [PATCH] ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY
Date: Sun, 01 Nov 2020 08:34:41 +0100 [thread overview]
Message-ID: <2511553.tmk64t66L6@kista> (raw)
In-Reply-To: <1604190857-3078-1-git-send-email-pgreco@centosproject.org>
Dne nedelja, 01. november 2020 ob 01:34:15 CET je Pablo Greco napisal(a):
> The Ethernet PHY on the Bananapi M1 has the RX and TX delays enabled on
> the PHY, using pull-ups on the RXDLY and TXDLY pins.
>
> Fix the phy-mode description to correct reflect this so that the
> implementation doesn't reconfigure the delays incorrectly. This
> happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e
> rx/tx delay config").
>
> Fixes: 8a5b272fbf44 ("ARM: dts: sun7i: Add Banana Pi board")
> Signed-off-by: Pablo Greco <pgreco@centosproject.org>
Acked-by: Jernej Skrabec <jernej.skrabec@siol.net>
Thanks!
Jernej
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: "Jernej Škrabec" <jernej.skrabec@siol.net>
To: linux-sunxi@googlegroups.com, Pablo Greco <pgreco@centosproject.org>
Cc: Pablo Greco <pgreco@centosproject.org>,
Rob Herring <robh+dt@kernel.org>,
Maxime Ripard <mripard@kernel.org>, Chen-Yu Tsai <wens@csie.org>,
Hans de Goede <hdegoede@redhat.com>,
Icenowy Zheng <icenowy@aosc.io>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY
Date: Sun, 01 Nov 2020 08:34:41 +0100 [thread overview]
Message-ID: <2511553.tmk64t66L6@kista> (raw)
In-Reply-To: <1604190857-3078-1-git-send-email-pgreco@centosproject.org>
Dne nedelja, 01. november 2020 ob 01:34:15 CET je Pablo Greco napisal(a):
> The Ethernet PHY on the Bananapi M1 has the RX and TX delays enabled on
> the PHY, using pull-ups on the RXDLY and TXDLY pins.
>
> Fix the phy-mode description to correct reflect this so that the
> implementation doesn't reconfigure the delays incorrectly. This
> happened with commit bbc4d71d6354 ("net: phy: realtek: fix rtl8211e
> rx/tx delay config").
>
> Fixes: 8a5b272fbf44 ("ARM: dts: sun7i: Add Banana Pi board")
> Signed-off-by: Pablo Greco <pgreco@centosproject.org>
Acked-by: Jernej Skrabec <jernej.skrabec@siol.net>
Thanks!
Jernej
next prev parent reply other threads:[~2020-11-01 7:32 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-01 0:34 [PATCH] ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY Pablo Greco
2020-11-01 0:34 ` Pablo Greco
2020-11-01 0:34 ` [PATCH] ARM: dts: sun8i: r40: bananapi-m2-berry: Fix dcdc1 regulator Pablo Greco
2020-11-01 0:34 ` Pablo Greco
2020-11-01 7:31 ` Jernej Škrabec
2020-11-01 7:31 ` Jernej Škrabec
2020-11-01 0:34 ` [PATCH] ARM: dts: sun8i: v40: bananapi-m2-berry: Fix ethernet node Pablo Greco
2020-11-01 0:34 ` Pablo Greco
2020-11-01 7:29 ` Jernej Škrabec
2020-11-01 7:29 ` Jernej Škrabec
2020-11-01 7:34 ` Jernej Škrabec [this message]
2020-11-01 7:34 ` [PATCH] ARM: dts: sun7i: bananapi: Enable RGMII RX/TX delay on Ethernet PHY Jernej Škrabec
2020-11-02 14:07 ` Maxime Ripard
2020-11-02 14:07 ` Maxime Ripard
2020-11-02 14:21 ` Pablo Sebastián Greco
2020-11-02 14:21 ` Pablo Sebastián Greco
-- strict thread matches above, loose matches on Subject: below --
2020-11-02 14:16 Pablo Greco
2020-11-02 14:16 ` Pablo Greco
2020-11-02 17:06 ` Maxime Ripard
2020-11-02 17:06 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2511553.tmk64t66L6@kista \
--to=jernej.skrabec@siol.net \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=icenowy@aosc.io \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mripard@kernel.org \
--cc=pgreco@centosproject.org \
--cc=robh+dt@kernel.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.