All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ASoC: Ensure DAPM widgets are set up before we sync jacks
@ 2011-10-06 12:31 Mark Brown
  2011-10-06 12:51 ` Péter Ujfalusi
  0 siblings, 1 reply; 2+ messages in thread
From: Mark Brown @ 2011-10-06 12:31 UTC (permalink / raw)
  To: Liam Girdwood; +Cc: alsa-devel, patches, Mark Brown

We synchronise jack state on startup - when we do that make sure that we
have set up all the DAPM widgets first in case we end up touching any of
the partially set up widgets when syncing the jack pins.

Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
 sound/soc/soc-jack.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/sound/soc/soc-jack.c b/sound/soc/soc-jack.c
index 02f95aa..6c5ebd3 100644
--- a/sound/soc/soc-jack.c
+++ b/sound/soc/soc-jack.c
@@ -189,6 +189,8 @@ int snd_soc_jack_add_pins(struct snd_soc_jack *jack, int count,
 		list_add(&(pins[i].list), &jack->pins);
 	}
 
+	snd_soc_dapm_new_widgets(&jack->codec->card->dapm);
+
 	/* Update to reflect the last reported status; canned jack
 	 * implementations are likely to set their state before the
 	 * card has an opportunity to associate pins.
-- 
1.7.6.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ASoC: Ensure DAPM widgets are set up before we sync jacks
  2011-10-06 12:31 [PATCH] ASoC: Ensure DAPM widgets are set up before we sync jacks Mark Brown
@ 2011-10-06 12:51 ` Péter Ujfalusi
  0 siblings, 0 replies; 2+ messages in thread
From: Péter Ujfalusi @ 2011-10-06 12:51 UTC (permalink / raw)
  To: alsa-devel; +Cc: Mark Brown, Liam Girdwood, patches

On Thursday 06 October 2011 13:31:24 Mark Brown wrote:
> We synchronise jack state on startup - when we do that make sure that we
> have set up all the DAPM widgets first in case we end up touching any of
> the partially set up widgets when syncing the jack pins.
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

Tested-by: Peter Ujfalusi <peter.ujfalusi@ti.com>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-10-06 12:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-06 12:31 [PATCH] ASoC: Ensure DAPM widgets are set up before we sync jacks Mark Brown
2011-10-06 12:51 ` Péter Ujfalusi

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.