From: "Péter Ujfalusi" <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org, Dmitry Torokhov <dtor@mail.ru>,
linux-kernel@vger.kernel.org,
Samuel Ortiz <samuel.ortiz@intel.com>,
Misael Lopez Cruz <misael.lopez@ti.com>,
Liam Girdwood <lrg@ti.com>
Subject: Re: [PATCH 07/17] ASoC: twl6040: Lower the initial gains
Date: Wed, 21 Sep 2011 16:03:49 +0300 [thread overview]
Message-ID: <25343507.X6coeDXaUn@barack> (raw)
In-Reply-To: <20110921123931.GD4374@opensource.wolfsonmicro.com>
On Wednesday 21 September 2011 13:39:31 Mark Brown wrote:
> The key problem here is that you sent a change saying "change the
> default volume" with no other context in either the changelog or the
> code. If you've got code that's actively managing the volume register
> while presenting a nice view to the application layer so that the
> register value isn't directly seen in the way it is for standard ASoC
> controls that's a very different thing to standard code. I'm not going
> to remember the details of everything in every CODEC driver.
>
> > We do have other scenarios covered, but this initialization was missing.
> > This resulted that the _first_ playback has pop noise, but all
> > subsequent playbacks were fine, since we had the runtime fix for this.
>
> So what you're doing here is really a bug fix for the ramping code.
I will update the commit message, and I'll also put a comment to the code to
explain it clearly.
--
Péter
WARNING: multiple messages have this Message-ID (diff)
From: "Péter Ujfalusi" <peter.ujfalusi@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: Samuel Ortiz <samuel.ortiz@intel.com>,
Dmitry Torokhov <dtor@mail.ru>, Liam Girdwood <lrg@ti.com>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Misael Lopez Cruz <misael.lopez@ti.com>
Subject: Re: Re: Re: Re: [PATCH 07/17] ASoC: twl6040: Lower the initial gains
Date: Wed, 21 Sep 2011 16:03:49 +0300 [thread overview]
Message-ID: <25343507.X6coeDXaUn@barack> (raw)
In-Reply-To: <20110921123931.GD4374@opensource.wolfsonmicro.com>
On Wednesday 21 September 2011 13:39:31 Mark Brown wrote:
> The key problem here is that you sent a change saying "change the
> default volume" with no other context in either the changelog or the
> code. If you've got code that's actively managing the volume register
> while presenting a nice view to the application layer so that the
> register value isn't directly seen in the way it is for standard ASoC
> controls that's a very different thing to standard code. I'm not going
> to remember the details of everything in every CODEC driver.
>
> > We do have other scenarios covered, but this initialization was missing.
> > This resulted that the _first_ playback has pop noise, but all
> > subsequent playbacks were fine, since we had the runtime fix for this.
>
> So what you're doing here is really a bug fix for the ramping code.
I will update the commit message, and I'll also put a comment to the code to
explain it clearly.
--
Péter
next prev parent reply other threads:[~2011-09-21 13:03 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-09-15 12:39 [PATCH 00/17] ASoC: twl6040: Cleanups and fixes Peter Ujfalusi
2011-09-15 12:39 ` [PATCH 01/17] MFD: twl6040: Remove global pointer for platform_device Peter Ujfalusi
2011-09-18 16:37 ` Samuel Ortiz
2011-09-19 22:17 ` [alsa-devel] " Mark Brown
2011-09-15 12:39 ` [PATCH 02/17] MFD: twl6040: Add accessor for revision ID Peter Ujfalusi
2011-09-18 16:37 ` Samuel Ortiz
2011-09-19 22:16 ` Mark Brown
2011-09-19 22:16 ` [alsa-devel] " Mark Brown
2011-09-15 12:39 ` [PATCH 03/17] Input: twl6040-vibra: Use accessor to get revision information Peter Ujfalusi
2011-09-19 22:16 ` [alsa-devel] " Mark Brown
2011-09-15 12:39 ` [PATCH 04/17] MFD: twl6040: Fix power on GPIO handling Peter Ujfalusi
2011-09-18 16:39 ` Samuel Ortiz
2011-09-19 22:16 ` [alsa-devel] " Mark Brown
2011-09-15 12:39 ` [PATCH 05/17] ASoC: twl6040: Chip initialization cleanup Peter Ujfalusi
2011-09-19 22:16 ` [alsa-devel] " Mark Brown
2011-09-15 12:39 ` [PATCH 06/17] ASoC: twl6040: Use chip defaults in the initial reg_cache Peter Ujfalusi
2011-09-19 22:17 ` [alsa-devel] " Mark Brown
2011-09-15 12:39 ` [PATCH 07/17] ASoC: twl6040: Lower the initial gains Peter Ujfalusi
2011-09-19 11:00 ` Mark Brown
2011-09-19 11:00 ` Mark Brown
2011-09-19 11:26 ` Péter Ujfalusi
2011-09-19 11:26 ` Péter Ujfalusi
2011-09-19 11:40 ` Mark Brown
2011-09-19 11:40 ` Mark Brown
2011-09-21 9:22 ` Péter Ujfalusi
2011-09-21 12:39 ` Mark Brown
2011-09-21 13:03 ` Péter Ujfalusi [this message]
2011-09-21 13:03 ` Péter Ujfalusi
2011-09-21 13:14 ` Péter Ujfalusi
2011-09-21 13:14 ` Re: Re: Re: " Péter Ujfalusi
2011-09-21 13:17 ` Mark Brown
2011-09-21 13:17 ` Re: Re: Re: " Mark Brown
2011-09-21 13:25 ` Péter Ujfalusi
2011-09-21 13:33 ` Mark Brown
2011-09-21 13:33 ` Re: Re: Re: Re: " Mark Brown
2011-09-15 12:39 ` [PATCH 08/17] ASoC: twl6040: Fix comments for register names Peter Ujfalusi
2011-09-15 12:39 ` [PATCH 09/17] ASoC: twl6040: Remove strings "NULL" from DAPM route Peter Ujfalusi
2011-09-15 12:39 ` [PATCH 10/17] ASoC: twl6040: Introduce SW only shadow register Peter Ujfalusi
2011-09-15 12:39 ` [PATCH 11/17] ASoC: twl6040: Earphone path correction Peter Ujfalusi
2011-09-15 12:39 ` [PATCH 12/17] ASoC: twl6040: Use consistent names for Handsfree path Peter Ujfalusi
2011-09-15 12:39 ` [PATCH 13/17] ASoC: twl6040: Use consistent names for Headset path Peter Ujfalusi
2011-09-15 12:39 ` [PATCH 14/17] ASoC: twl6040: Support for AUX L/R output Peter Ujfalusi
2011-09-15 12:39 ` [PATCH 15/17] ASoC: twl6040/sdp4430: Change legacy DAI name Peter Ujfalusi
2011-09-15 12:39 ` [PATCH 16/17] ASoC/MFD: twl6040: Combine bit definitions for Headset control registers Peter Ujfalusi
2011-09-15 12:39 ` [PATCH 17/17] ASoC: twl6040: Workaround for headset DC offset caused pop noise Peter Ujfalusi
2011-09-16 9:19 ` [PATCH 00/17] ASoC: twl6040: Cleanups and fixes Liam Girdwood
2011-09-18 16:41 ` Samuel Ortiz
2011-09-19 10:12 ` Mark Brown
2011-09-19 10:12 ` [alsa-devel] " Mark Brown
2011-09-19 11:32 ` Péter Ujfalusi
2011-09-19 11:32 ` Re: [alsa-devel] " Péter Ujfalusi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25343507.X6coeDXaUn@barack \
--to=peter.ujfalusi@ti.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=dtor@mail.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
--cc=misael.lopez@ti.com \
--cc=samuel.ortiz@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.