All of lore.kernel.org
 help / color / mirror / Atom feed
From: zhoucm1 <zhoucm1@amd.com>
To: "Koenig, Christian" <Christian.Koenig@amd.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	"Zhou, David(ChunMing)" <David1.Zhou@amd.com>,
	Julia Lawall <julia.lawall@lip6.fr>
Cc: David Airlie <airlied@linux.ie>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"kbuild-all@01.org" <kbuild-all@01.org>,
	Sean Paul <sean@poorly.run>
Subject: Re: [PATCH] drm: fix call_kern.cocci warnings (fwd)
Date: Thu, 25 Oct 2018 16:31:47 +0800	[thread overview]
Message-ID: <2538e7eb-d71d-2c19-a1eb-57701dee03ef@amd.com> (raw)
In-Reply-To: <1b153270-c73f-ea6f-6573-b742b81d6c42@amd.com>

will send a fix soon.


Thanks,

David


On 2018年10月25日 15:57, Koenig, Christian wrote:
> Am 25.10.18 um 09:51 schrieb Maarten Lankhorst:
>> Op 25-10-18 om 08:53 schreef Christian König:
>>> Am 25.10.18 um 03:28 schrieb Zhou, David(ChunMing):
>>>> Reviewed-by: Chunming Zhou <david1.zhou@amd.com>
>>> NAK, GFP_ATOMIC should be avoided.
>>>
>>> The correct solution is to move the allocation out of the spinlock or drop the lock and reacquire.
>> Yeah +1. Especially in a case like this where it's obvious to prevent. :)
> Another possibility would to not allocate the dummy fence at all.
>
> E.g. we just need a global instance of that which is always signaled and
> has a reference count of +1.
>
> Christian.

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel

WARNING: multiple messages have this Message-ID (diff)
From: zhoucm1 <zhoucm1@amd.com>
To: "Koenig, Christian" <Christian.Koenig@amd.com>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	"Zhou, David(ChunMing)" <David1.Zhou@amd.com>,
	Julia Lawall <julia.lawall@lip6.fr>
Cc: "kbuild-all@01.org" <kbuild-all@01.org>,
	"intel-gfx@lists.freedesktop.org"
	<intel-gfx@lists.freedesktop.org>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	Gustavo Padovan <gustavo@padovan.org>,
	Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm: fix call_kern.cocci warnings (fwd)
Date: Thu, 25 Oct 2018 16:31:47 +0800	[thread overview]
Message-ID: <2538e7eb-d71d-2c19-a1eb-57701dee03ef@amd.com> (raw)
In-Reply-To: <1b153270-c73f-ea6f-6573-b742b81d6c42@amd.com>

will send a fix soon.


Thanks,

David


On 2018年10月25日 15:57, Koenig, Christian wrote:
> Am 25.10.18 um 09:51 schrieb Maarten Lankhorst:
>> Op 25-10-18 om 08:53 schreef Christian König:
>>> Am 25.10.18 um 03:28 schrieb Zhou, David(ChunMing):
>>>> Reviewed-by: Chunming Zhou <david1.zhou@amd.com>
>>> NAK, GFP_ATOMIC should be avoided.
>>>
>>> The correct solution is to move the allocation out of the spinlock or drop the lock and reacquire.
>> Yeah +1. Especially in a case like this where it's obvious to prevent. :)
> Another possibility would to not allocate the dummy fence at all.
>
> E.g. we just need a global instance of that which is always signaled and
> has a reference count of +1.
>
> Christian.


  reply	other threads:[~2018-10-25  8:31 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-24 18:57 [PATCH] drm: fix call_kern.cocci warnings (fwd) Julia Lawall
2018-10-24 18:57 ` Julia Lawall
2018-10-24 19:19 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2018-10-24 19:47 ` ✓ Fi.CI.BAT: success " Patchwork
2018-10-25  1:24 ` ✓ Fi.CI.IGT: " Patchwork
2018-10-25  1:28 ` [PATCH] " Zhou, David(ChunMing)
2018-10-25  1:28   ` Zhou, David(ChunMing)
2018-10-25  6:53   ` Christian König
2018-10-25  7:51     ` Maarten Lankhorst
2018-10-25  7:57       ` Koenig, Christian
2018-10-25  7:57         ` Koenig, Christian
2018-10-25  8:31         ` zhoucm1 [this message]
2018-10-25  8:31           ` zhoucm1
2018-10-25  7:50 ` Maarten Lankhorst
2018-10-25  7:50   ` Maarten Lankhorst
2018-10-25  7:55   ` Christian König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2538e7eb-d71d-2c19-a1eb-57701dee03ef@amd.com \
    --to=zhoucm1@amd.com \
    --cc=Christian.Koenig@amd.com \
    --cc=David1.Zhou@amd.com \
    --cc=airlied@linux.ie \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=julia.lawall@lip6.fr \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=sean@poorly.run \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.