plymouth_24.004.60 causes to not pop up login prompt

plymouth_24.004.60 causes to not pop up login prompt

[Piotr Łobacz]

[-- Attachment #1: Type: text/plain, Size: 508 bytes --]

Hi all,
I'm working on scarthgap branch, as i have recentlly updated from kirkstone and encountered a strange issue.

As in subject I'm not getting login prompt when using plymouth as splash utility, but only a message like 'Starting systemd-udevd version 255.13`. When I hit alt+f2 I will switch to tty2 and than again alt+f1 i'm getting tty1 so that is fine but for some reason plymouth is casuing this screen hangup and I do not know what is causing it. Maybe some of you encountered it?

BR
Piotr

[-- Attachment #2: Type: text/html, Size: 597 bytes --]

ODP: [oe] plymouth_24.004.60 causes to not pop up login prompt

[Piotr Łobacz]

[-- Attachment #1: Type: text/plain, Size: 1818 bytes --]

OK I have discovered the issue. The problem is that there is the patch https://git.openembedded.org/meta-openembedded/tree/meta-oe/recipes-core/plymouth/plymouth/0001-plymouth-start-service-in-add-related-kernel-paramet.patch?h=scarthgap and according to this merge request in upstream https://gitlab.freedesktop.org/plymouth/plymouth/-/merge_requests/157 it is wrong. Also Ray Strode in his comment has explaind it clearly that with that option it would login prompt would never be run, which exactly happens in my case. Deleting this parameter fixes the issue.

IMHO this patch 0001-plymouth-Add-the-retain-splash-option.patch should be removed. In addition this one 0001-plymouth-start-service-in-add-related-kernel-paramet.patch should be deleted as well as it forces to be the default behaviour of plymouth. Developers should decide this on their own...

BR
Piotr

________________________________
Od: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> w imieniu użytkownika Piotr Łobacz via lists.openembedded.org <p.lobacz=welotec.com@lists.openembedded.org>
Wysłane: wtorek, 21 stycznia 2025 23:45
Do: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org>
Temat: [oe] plymouth_24.004.60 causes to not pop up login prompt

Hi all,
I'm working on scarthgap branch, as i have recentlly updated from kirkstone and encountered a strange issue.

As in subject I'm not getting login prompt when using plymouth as splash utility, but only a message like 'Starting systemd-udevd version 255.13`. When I hit alt+f2 I will switch to tty2 and than again alt+f1 i'm getting tty1 so that is fine but for some reason plymouth is casuing this screen hangup and I do not know what is causing it. Maybe some of you encountered it?

BR
Piotr

[-- Attachment #2: Type: text/html, Size: 3537 bytes --]

Re: [oe] plymouth_24.004.60 causes to not pop up login prompt

[Khem Raj]

On Thu, Jan 23, 2025 at 12:17 PM Piotr Łobacz via
lists.openembedded.org <p.lobacz=welotec.com@lists.openembedded.org>
wrote:
>
> OK I have discovered the issue. The problem is that there is the patch https://git.openembedded.org/meta-openembedded/tree/meta-oe/recipes-core/plymouth/plymouth/0001-plymouth-start-service-in-add-related-kernel-paramet.patch?h=scarthgap and according to this merge request in upstream https://gitlab.freedesktop.org/plymouth/plymouth/-/merge_requests/157 it is wrong. Also Ray Strode in his comment has explaind it clearly that with that option it would login prompt would never be run, which exactly happens in my case. Deleting this parameter fixes the issue.
>
> IMHO this patch 0001-plymouth-Add-the-retain-splash-option.patch should be removed. In addition this one 0001-plymouth-start-service-in-add-related-kernel-paramet.patch should be deleted as well as it forces to be the default behaviour of plymouth. Developers should decide this on their own...
>

Thanks for reporting and drilling down, would you mind sending a patch
to remove it? Since the patch is rejected upstream and does not have
alternative way to handle the original issue, it's better to remove it.

> BR
> Piotr
>
> ________________________________
> Od: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> w imieniu użytkownika Piotr Łobacz via lists.openembedded.org <p.lobacz=welotec.com@lists.openembedded.org>
> Wysłane: wtorek, 21 stycznia 2025 23:45
> Do: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org>
> Temat: [oe] plymouth_24.004.60 causes to not pop up login prompt
>
> Hi all,
> I'm working on scarthgap branch, as i have recentlly updated from kirkstone and encountered a strange issue.
>
> As in subject I'm not getting login prompt when using plymouth as splash utility, but only a message like 'Starting systemd-udevd version 255.13`. When I hit alt+f2 I will switch to tty2 and than again alt+f1 i'm getting tty1 so that is fine but for some reason plymouth is casuing this screen hangup and I do not know what is causing it. Maybe some of you encountered it?
>
> BR
> Piotr
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#115036): https://lists.openembedded.org/g/openembedded-devel/message/115036
> Mute This Topic: https://lists.openembedded.org/mt/110778733/1997914
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://lists.openembedded.org/g/openembedded-devel/unsub [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

Re: [oe] plymouth_24.004.60 causes to not pop up login prompt

[Piotr Łobacz]

[-- Attachment #1: Type: text/plain, Size: 5531 bytes --]

Hi Khem,
Yes i will do that in the morning.

BR
Piotr

Wysyłane z aplikacji Outlook dla systemu iOS<https://aka.ms/o0ukef>
________________________________
Od: Khem Raj <raj.khem@gmail.com>
Wysłane: Thursday, January 23, 2025 10:22:06 PM
Do: Piotr Łobacz <p.lobacz@welotec.com>
DW: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org>
Temat: Re: [oe] plymouth_24.004.60 causes to not pop up login prompt

On Thu, Jan 23, 2025 at 12:17 PM Piotr Łobacz via
lists.openembedded.org <p.lobacz=welotec.com@lists.openembedded.org>
wrote:
>
> OK I have discovered the issue. The problem is that there is the patch https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.openembedded.org%2Fmeta-openembedded%2Ftree%2Fmeta-oe%2Frecipes-core%2Fplymouth%2Fplymouth%2F0001-plymouth-start-service-in-add-related-kernel-paramet.patch%3Fh%3Dscarthgap&data=05%7C02%7Cp.lobacz%40welotec.com%7C75b007ec72534066166b08dd3bf40d81%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638732641566989964%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=NTyN5mDsEEFW0b2Q7bP9nfLvjRHFZYmKTiLpCwX4qVs%3D&reserved=0<https://git.openembedded.org/meta-openembedded/tree/meta-oe/recipes-core/plymouth/plymouth/0001-plymouth-start-service-in-add-related-kernel-paramet.patch?h=scarthgap> and according to this merge request in upstream https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fplymouth%2Fplymouth%2F-%2Fmerge_requests%2F157&data=05%7C02%7Cp.lobacz%40welotec.com%7C75b007ec72534066166b08dd3bf40d81%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638732641567006658%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=MIl3r8bkJY0zX4sp9C4uxgOvCD%2FOFCWLOcSyYSGxN1s%3D&reserved=0<https://gitlab.freedesktop.org/plymouth/plymouth/-/merge_requests/157> it is wrong. Also Ray Strode in his comment has explaind it clearly that with that option it would login prompt would never be run, which exactly happens in my case. Deleting this parameter fixes the issue.
>
> IMHO this patch 0001-plymouth-Add-the-retain-splash-option.patch should be removed. In addition this one 0001-plymouth-start-service-in-add-related-kernel-paramet.patch should be deleted as well as it forces to be the default behaviour of plymouth. Developers should decide this on their own...
>

Thanks for reporting and drilling down, would you mind sending a patch
to remove it? Since the patch is rejected upstream and does not have
alternative way to handle the original issue, it's better to remove it.

> BR
> Piotr
>
> ________________________________
> Od: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org> w imieniu użytkownika Piotr Łobacz via lists.openembedded.org <p.lobacz=welotec.com@lists.openembedded.org>
> Wysłane: wtorek, 21 stycznia 2025 23:45
> Do: openembedded-devel@lists.openembedded.org <openembedded-devel@lists.openembedded.org>
> Temat: [oe] plymouth_24.004.60 causes to not pop up login prompt
>
> Hi all,
> I'm working on scarthgap branch, as i have recentlly updated from kirkstone and encountered a strange issue.
>
> As in subject I'm not getting login prompt when using plymouth as splash utility, but only a message like 'Starting systemd-udevd version 255.13`. When I hit alt+f2 I will switch to tty2 and than again alt+f1 i'm getting tty1 so that is fine but for some reason plymouth is casuing this screen hangup and I do not know what is causing it. Maybe some of you encountered it?
>
> BR
> Piotr
>
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#115036): https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fg%2Fopenembedded-devel%2Fmessage%2F115036&data=05%7C02%7Cp.lobacz%40welotec.com%7C75b007ec72534066166b08dd3bf40d81%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638732641567018251%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=QHlZl2iTyoMgJJ7P43lQbHJRg6JG3Kt%2FU8I9UZFaH7A%3D&reserved=0<https://lists.openembedded.org/g/openembedded-devel/message/115036>
> Mute This Topic: https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fmt%2F110778733%2F1997914&data=05%7C02%7Cp.lobacz%40welotec.com%7C75b007ec72534066166b08dd3bf40d81%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638732641567029511%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=YLOpokmmqHO4DIAP7Gwe%2FRhCPgZwg7HEsy2nJkfgaJ8%3D&reserved=0<https://lists.openembedded.org/mt/110778733/1997914>
> Group Owner: openembedded-devel+owner@lists.openembedded.org
> Unsubscribe: https://eur04.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.openembedded.org%2Fg%2Fopenembedded-devel%2Funsub&data=05%7C02%7Cp.lobacz%40welotec.com%7C75b007ec72534066166b08dd3bf40d81%7C25111a7f1d5a4c51a4ca7f8e44011b39%7C0%7C0%7C638732641567040483%7CUnknown%7CTWFpbGZsb3d8eyJFbXB0eU1hcGkiOnRydWUsIlYiOiIwLjAuMDAwMCIsIlAiOiJXaW4zMiIsIkFOIjoiTWFpbCIsIldUIjoyfQ%3D%3D%7C0%7C%7C%7C&sdata=a3Mg3GC6jU9hztJ4uv0aEVi%2BoJdy%2FSXRksi53BYhYw4%3D&reserved=0<https://lists.openembedded.org/g/openembedded-devel/unsub> [raj.khem@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
>

[-- Attachment #2: Type: text/html, Size: 6647 bytes --]

Re: plymouth_24.004.60 causes to not pop up login prompt

[Piotr Łobacz]

[-- Attachment #1: Type: text/plain, Size: 3219 bytes --]

From b2c23a43cde6090322d3161accce47b74d8a6602 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Piotr=20=C5=81obacz?= <p.lobacz@welotec.com>
Date: Fri, 24 Jan 2025 11:49:40 +0100
Subject: [meta-oe][scarthgap][PATCH 1/2] plymouth: remove patch causing issue
with no login prompt
Setting `--retain-splash` isn't right, plymouth-quit gets used for instance
when switching to a getty or something that isn't graphical [1].
[1] https://gitlab.freedesktop.org/plymouth/plymouth/-/merge_requests/157
---
...lymouth-Add-the-retain-splash-option.patch | 35 -------------------
.../plymouth/plymouth_24.004.60.bb            |  1 -
2 files changed, 36 deletions(-)
delete mode 100644 meta-oe/recipes-core/plymouth/plymouth/0001-plymouth-Add-the-retain-splash-option.patch
diff --git a/meta-oe/recipes-core/plymouth/plymouth/0001-plymouth-Add-the-retain-splash-option.patch b/meta-oe/recipes-core/plymouth/plymouth/0001-plymouth-Add-the-retain-splash-option.patch
deleted file mode 100644
index 58838500bf..0000000000
--- a/meta-oe/recipes-core/plymouth/plymouth/0001-plymouth-Add-the-retain-splash-option.patch
+++ /dev/null
@@ -1,35 +0,0 @@
-From f270f80d4c36a22a0f7b8de8fb6b1abef6f7b183 Mon Sep 17 00:00:00 2001
-From: Mingli Yu <mingli.yu@windriver.com>
-Date: Tue, 15 Feb 2022 16:23:10 +0800
-Subject: [PATCH] plymouth : Add the retain-splash option
-MIME-Version: 1.0
-Content-Type: text/plain; charset=UTF-8
-Content-Transfer-Encoding: 8bit
-
-Adding the "retain-splash” option to tell plymouth to keep the boot
-splash’s contents on screen even after plymouth exits to make the
-splash screen show more friendly on the system which boots so fast.
-
-Upstream-Status: Inappropriate [embedded specific]
-
-Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
----
- systemd-units/plymouth-quit.service.in | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/systemd-units/plymouth-quit.service.in b/systemd-units/plymouth-quit.service.in
-index ed9f9b9..147e9ee 100644
---- a/systemd-units/plymouth-quit.service.in
-+++ b/systemd-units/plymouth-quit.service.in
-@@ -3,7 +3,7 @@ Description=Terminate Plymouth Boot Screen
- After=rc-local.service plymouth-start.service systemd-user-sessions.service
-
- [Service]
--ExecStart=-@PLYMOUTH_CLIENT_DIR@/plymouth quit
-+ExecStart=-@PLYMOUTH_CLIENT_DIR@/plymouth quit --retain-splash
- Type=oneshot
- RemainAfterExit=yes
- TimeoutSec=20
---
-2.17.1
-
diff --git a/meta-oe/recipes-core/plymouth/plymouth_24.004.60.bb b/meta-oe/recipes-core/plymouth/plymouth_24.004.60.bb
index cdf24477a7..c161c20ee9 100644
--- a/meta-oe/recipes-core/plymouth/plymouth_24.004.60.bb
+++ b/meta-oe/recipes-core/plymouth/plymouth_24.004.60.bb
@@ -12,7 +12,6 @@ SRC_URI = " \
http://www.freedesktop.org/software/plymouth/releases/${BPN}-${PV}.tar.xz \
file://0001-Make-full-path-to-systemd-tty-ask-password-agent-con.patch \
file://0001-plymouth-start-service-in-add-related-kernel-paramet.patch \
-    file://0001-plymouth-Add-the-retain-splash-option.patch \
file://0001-Drop-libdl-references.patch \
file://0001-Avoid-linking-to-plymouth_logo_file.patch \
file://0001-Make-themes-build-optional.patch \
--
2.48.1

[-- Attachment #2: Type: text/html, Size: 3783 bytes --]

Re: plymouth_24.004.60 causes to not pop up login prompt

[Piotr Łobacz]

[-- Attachment #1: Type: text/plain, Size: 3303 bytes --]

From 3850e79c641a8f942400a566c36f716fc7a542a9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Piotr=20=C5=81obacz?= <p.lobacz@welotec.com>
Date: Fri, 24 Jan 2025 11:54:22 +0100
Subject: [meta-oe][scarthgap][PATCH 2/2] plymouth: remove extra kernel
parameter
Setting `--kernel-command-line` in systemd service is unmodifiable
from the bootloader kernel parameters.
`splash` together with `plymouth.ignore-serial-consoles` should be
added by the user to e.g. bootloader configuration file instead.
---
...ervice-in-add-related-kernel-paramet.patch | 31 -------------------
.../plymouth/plymouth_24.004.60.bb            |  1 -
2 files changed, 32 deletions(-)
delete mode 100644 meta-oe/recipes-core/plymouth/plymouth/0001-plymouth-start-service-in-add-related-kernel-paramet.patch
diff --git a/meta-oe/recipes-core/plymouth/plymouth/0001-plymouth-start-service-in-add-related-kernel-paramet.patch b/meta-oe/recipes-core/plymouth/plymouth/0001-plymouth-start-service-in-add-related-kernel-paramet.patch
deleted file mode 100644
index 7ba1034e93..0000000000
--- a/meta-oe/recipes-core/plymouth/plymouth/0001-plymouth-start-service-in-add-related-kernel-paramet.patch
+++ /dev/null
@@ -1,31 +0,0 @@
-From 658eac007d14d836cb002a5675487bac63d50324 Mon Sep 17 00:00:00 2001
-From: Mingli Yu <mingli.yu@windriver.com>
-Date: Mon, 7 Feb 2022 03:22:12 +0000
-Subject: [PATCH] plymouth-start.service.in: add related kernel parameter
-
-Add extra kernel parameter to make the plymouth splash screen
-display during boot.
-
-Upstream-Status: Submitted [https://gitlab.freedesktop.org/plymouth/plymouth/-/merge_requests/156]
-
-Signed-off-by: Mingli Yu <mingli.yu@windriver.com>
----
- systemd-units/plymouth-start.service.in | 2 +-
- 1 file changed, 1 insertion(+), 1 deletion(-)
-
-diff --git a/systemd-units/plymouth-start.service.in b/systemd-units/plymouth-start.service.in
-index 830a62d..c20aabe 100644
---- a/systemd-units/plymouth-start.service.in
-+++ b/systemd-units/plymouth-start.service.in
-@@ -9,7 +9,7 @@ ConditionVirtualization=!container
- IgnoreOnIsolate=true
-
- [Service]
--ExecStart=@PLYMOUTH_DAEMON_DIR@/plymouthd --mode=boot --pid-file=@plymouthruntimedir@/pid --attach-to-session
-+ExecStart=@PLYMOUTH_DAEMON_DIR@/plymouthd --mode=boot  --kernel-command-line="splash plymouth.ignore-serial-consoles" --pid-file=@plymouthruntimedir@/pid --attach-to-session
- ExecStartPost=-@PLYMOUTH_CLIENT_DIR@/plymouth show-splash
- Type=forking
- RemainAfterExit=yes
---
-2.31.1
-
diff --git a/meta-oe/recipes-core/plymouth/plymouth_24.004.60.bb b/meta-oe/recipes-core/plymouth/plymouth_24.004.60.bb
index c161c20ee9..05fe5c51e7 100644
--- a/meta-oe/recipes-core/plymouth/plymouth_24.004.60.bb
+++ b/meta-oe/recipes-core/plymouth/plymouth_24.004.60.bb
@@ -11,7 +11,6 @@ LIC_FILES_CHKSUM = "file://COPYING;md5=94d55d512a9ba36caa9b7df079bae19f"
SRC_URI = " \
http://www.freedesktop.org/software/plymouth/releases/${BPN}-${PV}.tar.xz \
file://0001-Make-full-path-to-systemd-tty-ask-password-agent-con.patch \
-    file://0001-plymouth-start-service-in-add-related-kernel-paramet.patch \
file://0001-Drop-libdl-references.patch \
file://0001-Avoid-linking-to-plymouth_logo_file.patch \
file://0001-Make-themes-build-optional.patch \
--
2.48.1

[-- Attachment #2: Type: text/html, Size: 3837 bytes --]