wip-libcephfs-firefly-rb

wip-libcephfs-firefly-rb

[Matt W. Benjamin]

Hi Sage and Ceph devs,

Casey over here root-caused and we believe fixed the refcounting problem on our wip-libcephfs branch, and
a rebase to firefly is in progress.

The fix is on wip-libcephfs-firefly-rb :

"""
fuse: fix for missing ll_ref on create
when the 'Inode **outp' argument was added to ll_create(), it was
changed to only take the ll_ref if outp was not NULL. fuse_ll_create()
was calling ll_create() with outp=NULL, and subsequently calling
fuse_reply_create() (which causes fuse to increment the lookup count)
without registering the initial ll_ref

this patch adds a dummy inode pointer i2 to the ll_create() call to
claim our initial reference

Signed-off-by: Casey Bodley <casey@linuxbox.com>
"""

We're still finishing up the rebase, but I expect to have one tested by some time tomorrow am.

Thanks,

Matt

-- 
Matt Benjamin
The Linux Box
206 South Fifth Ave. Suite 150
Ann Arbor, MI  48104

http://linuxbox.com

tel.  734-761-4689 
fax.  734-769-8938 
cel.  734-216-5309 

Re: wip-libcephfs-firefly-rb

[Sage Weil]

Hey Matt, Casey,

This is great news!  Please let me know as soon as the rebase is ready and 
there is a pull-request so I get this run through the test suite.  This is 
the last week before the firefly freeze and it would be great to get this 
libcephfs API update into that release.

sage

On Fri, 7 Feb 2014, Matt W. Benjamin wrote:

> Hi Sage and Ceph devs,
> 
> Casey over here root-caused and we believe fixed the refcounting problem on our wip-libcephfs branch, and
> a rebase to firefly is in progress.
> 
> The fix is on wip-libcephfs-firefly-rb :
> 
> """
> fuse: fix for missing ll_ref on create
> when the 'Inode **outp' argument was added to ll_create(), it was
> changed to only take the ll_ref if outp was not NULL. fuse_ll_create()
> was calling ll_create() with outp=NULL, and subsequently calling
> fuse_reply_create() (which causes fuse to increment the lookup count)
> without registering the initial ll_ref
> 
> this patch adds a dummy inode pointer i2 to the ll_create() call to
> claim our initial reference
> 
> Signed-off-by: Casey Bodley <casey@linuxbox.com>
> """
> 
> We're still finishing up the rebase, but I expect to have one tested by some time tomorrow am.
> 
> Thanks,
> 
> Matt
> 
> -- 
> Matt Benjamin
> The Linux Box
> 206 South Fifth Ave. Suite 150
> Ann Arbor, MI  48104
> 
> http://linuxbox.com
> 
> tel.  734-761-4689 
> fax.  734-769-8938 
> cel.  734-216-5309 
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

Re: wip-libcephfs-firefly-rb

[Matt W. Benjamin]

Hi,

It looks to me like the rebase was already done--I thought Casey needed me to finish that up,
but everything just built for me.

Matt

----- "Sage Weil" <sage@inktank.com> wrote:

> Hey Matt, Casey,
> 
> This is great news!  Please let me know as soon as the rebase is ready
> and 
> there is a pull-request so I get this run through the test suite. 
> This is 
> the last week before the firefly freeze and it would be great to get
> this 
> libcephfs API update into that release.
> 
> sage
> 
> On Fri, 7 Feb 2014, Matt W. Benjamin wrote:
> 
> > Hi Sage and Ceph devs,
> > 
> > Casey over here root-caused and we believe fixed the refcounting
> problem on our wip-libcephfs branch, and
> > a rebase to firefly is in progress.
> > 
> > The fix is on wip-libcephfs-firefly-rb :
> > 
> > """
> > fuse: fix for missing ll_ref on create
> > when the 'Inode **outp' argument was added to ll_create(), it was
> > changed to only take the ll_ref if outp was not NULL.
> fuse_ll_create()
> > was calling ll_create() with outp=NULL, and subsequently calling
> > fuse_reply_create() (which causes fuse to increment the lookup
> count)
> > without registering the initial ll_ref
> > 
> > this patch adds a dummy inode pointer i2 to the ll_create() call to
> > claim our initial reference
> > 
> > Signed-off-by: Casey Bodley <casey@linuxbox.com>
> > """
> > 
> > We're still finishing up the rebase, but I expect to have one tested
> by some time tomorrow am.
> > 
> > Thanks,
> > 
> > Matt
> > 
> > -- 
> > Matt Benjamin
> > The Linux Box
> > 206 South Fifth Ave. Suite 150
> > Ann Arbor, MI  48104
> > 
> > http://linuxbox.com
> > 
> > tel.  734-761-4689 
> > fax.  734-769-8938 
> > cel.  734-216-5309 
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> ceph-devel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> > 
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel"
> in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Matt Benjamin
The Linux Box
206 South Fifth Ave. Suite 150
Ann Arbor, MI  48104

http://linuxbox.com

tel.  734-761-4689 
fax.  734-769-8938 
cel.  734-216-5309 

Re: wip-libcephfs-firefly-rb

[Sage Weil]

On Sat, 8 Feb 2014, Matt W. Benjamin wrote:
> Hi,
> 
> It looks to me like the rebase was already done--I thought Casey needed me to finish that up,
> but everything just built for me.

What is the URL for the posted branch?  

Thanks!
sage

> 
> Matt
> 
> ----- "Sage Weil" <sage@inktank.com> wrote:
> 
> > Hey Matt, Casey,
> > 
> > This is great news!  Please let me know as soon as the rebase is ready
> > and 
> > there is a pull-request so I get this run through the test suite. 
> > This is 
> > the last week before the firefly freeze and it would be great to get
> > this 
> > libcephfs API update into that release.
> > 
> > sage
> > 
> > On Fri, 7 Feb 2014, Matt W. Benjamin wrote:
> > 
> > > Hi Sage and Ceph devs,
> > > 
> > > Casey over here root-caused and we believe fixed the refcounting
> > problem on our wip-libcephfs branch, and
> > > a rebase to firefly is in progress.
> > > 
> > > The fix is on wip-libcephfs-firefly-rb :
> > > 
> > > """
> > > fuse: fix for missing ll_ref on create
> > > when the 'Inode **outp' argument was added to ll_create(), it was
> > > changed to only take the ll_ref if outp was not NULL.
> > fuse_ll_create()
> > > was calling ll_create() with outp=NULL, and subsequently calling
> > > fuse_reply_create() (which causes fuse to increment the lookup
> > count)
> > > without registering the initial ll_ref
> > > 
> > > this patch adds a dummy inode pointer i2 to the ll_create() call to
> > > claim our initial reference
> > > 
> > > Signed-off-by: Casey Bodley <casey@linuxbox.com>
> > > """
> > > 
> > > We're still finishing up the rebase, but I expect to have one tested
> > by some time tomorrow am.
> > > 
> > > Thanks,
> > > 
> > > Matt
> > > 
> > > -- 
> > > Matt Benjamin
> > > The Linux Box
> > > 206 South Fifth Ave. Suite 150
> > > Ann Arbor, MI  48104
> > > 
> > > http://linuxbox.com
> > > 
> > > tel.  734-761-4689 
> > > fax.  734-769-8938 
> > > cel.  734-216-5309 
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe
> > ceph-devel" in
> > > the body of a message to majordomo@vger.kernel.org
> > > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > > 
> > > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe ceph-devel"
> > in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> -- 
> Matt Benjamin
> The Linux Box
> 206 South Fifth Ave. Suite 150
> Ann Arbor, MI  48104
> 
> http://linuxbox.com
> 
> tel.  734-761-4689 
> fax.  734-769-8938 
> cel.  734-216-5309 
> --
> To unsubscribe from this list: send the line "unsubscribe ceph-devel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> 

Re: wip-libcephfs-firefly-rb

[Matt W. Benjamin]

This should be it:

    https://github.com/linuxbox2/linuxbox-ceph/tree/wip-libcephfs-firefly-rb

Matt

----- "Sage Weil" <sage@inktank.com> wrote:

> On Sat, 8 Feb 2014, Matt W. Benjamin wrote:
> > Hi,
> > 
> > It looks to me like the rebase was already done--I thought Casey
> needed me to finish that up,
> > but everything just built for me.
> 
> What is the URL for the posted branch?  
> 
> Thanks!
> sage
> 
> > 
> > Matt
> > 
> > ----- "Sage Weil" <sage@inktank.com> wrote:
> > 
> > > Hey Matt, Casey,
> > > 
> > > This is great news!  Please let me know as soon as the rebase is
> ready
> > > and 
> > > there is a pull-request so I get this run through the test suite.
> 
> > > This is 
> > > the last week before the firefly freeze and it would be great to
> get
> > > this 
> > > libcephfs API update into that release.
> > > 
> > > sage
> > > 
> > > On Fri, 7 Feb 2014, Matt W. Benjamin wrote:
> > > 
> > > > Hi Sage and Ceph devs,
> > > > 
> > > > Casey over here root-caused and we believe fixed the
> refcounting
> > > problem on our wip-libcephfs branch, and
> > > > a rebase to firefly is in progress.
> > > > 
> > > > The fix is on wip-libcephfs-firefly-rb :
> > > > 
> > > > """
> > > > fuse: fix for missing ll_ref on create
> > > > when the 'Inode **outp' argument was added to ll_create(), it
> was
> > > > changed to only take the ll_ref if outp was not NULL.
> > > fuse_ll_create()
> > > > was calling ll_create() with outp=NULL, and subsequently
> calling
> > > > fuse_reply_create() (which causes fuse to increment the lookup
> > > count)
> > > > without registering the initial ll_ref
> > > > 
> > > > this patch adds a dummy inode pointer i2 to the ll_create() call
> to
> > > > claim our initial reference
> > > > 
> > > > Signed-off-by: Casey Bodley <casey@linuxbox.com>
> > > > """
> > > > 
> > > > We're still finishing up the rebase, but I expect to have one
> tested
> > > by some time tomorrow am.
> > > > 
> > > > Thanks,
> > > > 
> > > > Matt
> > > > 
> > > > -- 
> > > > Matt Benjamin
> > > > The Linux Box
> > > > 206 South Fifth Ave. Suite 150
> > > > Ann Arbor, MI  48104
> > > > 
> > > > http://linuxbox.com
> > > > 
> > > > tel.  734-761-4689 
> > > > fax.  734-769-8938 
> > > > cel.  734-216-5309 
> > > > --
> > > > To unsubscribe from this list: send the line "unsubscribe
> > > ceph-devel" in
> > > > the body of a message to majordomo@vger.kernel.org
> > > > More majordomo info at 
> http://vger.kernel.org/majordomo-info.html
> > > > 
> > > > 
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe
> ceph-devel"
> > > in
> > > the body of a message to majordomo@vger.kernel.org
> > > More majordomo info at 
> http://vger.kernel.org/majordomo-info.html
> > 
> > -- 
> > Matt Benjamin
> > The Linux Box
> > 206 South Fifth Ave. Suite 150
> > Ann Arbor, MI  48104
> > 
> > http://linuxbox.com
> > 
> > tel.  734-761-4689 
> > fax.  734-769-8938 
> > cel.  734-216-5309 
> > --
> > To unsubscribe from this list: send the line "unsubscribe
> ceph-devel" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > 
> >

-- 
Matt Benjamin
The Linux Box
206 South Fifth Ave. Suite 150
Ann Arbor, MI  48104

http://linuxbox.com

tel.  734-761-4689 
fax.  734-769-8938 
cel.  734-216-5309