All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>,
	"Yigit, Ferruh" <Ferruh.Yigit@amd.com>,
	"Varghese, Vipin" <Vipin.Varghese@amd.com>
Cc: "david.marchand@redhat.com" <david.marchand@redhat.com>,
	"Tummala, Sivaprasad" <Sivaprasad.Tummala@amd.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [PATCH] usertools: enhance logic to display NUMA
Date: Tue, 18 Jul 2023 16:45:36 +0200	[thread overview]
Message-ID: <2586124.g5d078U9FE@thomas> (raw)
In-Reply-To: <MN2PR12MB3085A96FF15A79D15F27166E8238A@MN2PR12MB3085.namprd12.prod.outlook.com>

18/07/2023 12:37, Varghese, Vipin:
> > 14/07/2023 11:14, Varghese, Vipin:
> > > From: Thomas Monjalon <thomas@monjalon.net>
> > > > 11/07/2023 17:42, Stephen Hemminger:
> > > > > On Sat, 26 Mar 2022 00:32:07 -0700 Vipin Varghese
> > > > > <vipin.varghese@amd.com> wrote:
> > > > >
> 
> <<Snipped>>
> 
> > > > >
> > > > > Git complains because you added new blank line at end of file.
> > > > >
> > > > > One wording suggestion would be to use the term "Node" instead of
> > > > "Numa" in the table.
> > > > > And fix heading alignment. The new headings don't look right.
> > > > >
> > > > > For the case with only single socket, single node, some of the
> > > > > headings could be dropped as well.
> > > >
> > > > I don't understand why we continue working on this script.
> > > > I thought we agreed it should be removed in favor of lstopo.
> > > >
> > >
> > > Sorry Thomas, I did not follow your ` I don't understand why we
> > > continue working on this script. I thought we agreed it should be
> > > removed in favor of lstopo.`
> > >
> > > From last email from my end `we should promote and document the
> > changes provided the existing tool is phased out and use lstopo`.
> > >
> > > Note:
> > > 1. This is with assumption that both Linux and Windows `lstopo` is modified
> > and handles `ACPI L3 SRAT NUMA` and `Node per Socket NUMA`.
> > > 2. I have not seen a depreciation notice for cpu_layout.py too.
> >
> > My take is that we should stop working on this script.
> > It is better to contribute to lstopo. Did you try?
> >
> > We probably won't deprecate cpu_layout.py easily.
> > The first step would be to add a message when running the script,
> > recommending to use lstopo.
> > Vipin would you like to write such a patch?
> 
> Sure, we can do this. Based on the discussion with Ferruh, we as AMD find a need to update documentation for ` Platform Specific Guides`, which will help to capture various combinations of `NPS` and `L3 for Compute Tiles` using lstopo and other tools as required.

OK thanks




  reply	other threads:[~2023-07-18 14:45 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-26  7:32 [PATCH] usertools: enhance logic to display NUMA Vipin Varghese
2022-03-26  9:46 ` Thomas Monjalon
2022-03-28  2:56   ` Varghese, Vipin
2022-03-28  7:44     ` Tummala, Sivaprasad
2023-06-14 10:48     ` Ferruh Yigit
2023-06-14 11:25       ` Dmitry Kozlyuk
2023-06-14 14:30       ` Thomas Monjalon
2023-07-11  6:38         ` Varghese, Vipin
2023-07-11 15:42 ` Stephen Hemminger
2023-07-11 16:26   ` Thomas Monjalon
2023-07-14  9:14     ` Varghese, Vipin
2023-07-17 15:07       ` Thomas Monjalon
2023-07-18 10:37         ` Varghese, Vipin
2023-07-18 14:45           ` Thomas Monjalon [this message]
2023-08-12 11:39             ` Varghese, Vipin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2586124.g5d078U9FE@thomas \
    --to=thomas@monjalon.net \
    --cc=Ferruh.Yigit@amd.com \
    --cc=Sivaprasad.Tummala@amd.com \
    --cc=Vipin.Varghese@amd.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.