Re: [PATCH] usertools: enhance logic to display NUMA

[Thomas Monjalon <thomas@monjalon.net>]

11/07/2023 17:42, Stephen Hemminger:
> On Sat, 26 Mar 2022 00:32:07 -0700
> Vipin Varghese <vipin.varghese@amd.com> wrote:
> 
> > +
> > +  output = " Socket " + str(socket).ljust(3, ' ') + " Numa " + str(numa).zfill(1) + " "
> > +  #output = " Socket " + str(socket).zfill(1) + " Numa " + str(numa).zfill(1) + " "
> > +  print(output)
> > +  print(format("-" * len(output)))
> > +
> > +  for index,coreSibling in enumerate(numa_map[keys]):
> > +      print ("Core " + str(index).ljust(3, ' ') + "    " + str(coreSibling))
> > +      #print ("Core " + str(index).zfill(3) + "    " + str(coreSibling))
> > +print("")
> > +
> 
> Git complains because you added new blank line at end of file.
> 
> One wording suggestion would be to use the term "Node" instead of "Numa" in the table.
> And fix heading alignment. The new headings don't look right.
> 
> For the case with only single socket, single node, some of the headings could be
> dropped as well.

I don't understand why we continue working on this script.
I thought we agreed it should be removed in favor of lstopo.