* [Intel-wired-lan] [PATCH net v1 0/2] igc: Fix Pause Frame Advertising
@ 2021-02-19 16:36 Muhammad Husaini Zulkifli
2021-02-19 16:36 ` [Intel-wired-lan] [PATCH net v1 1/2] " Muhammad Husaini Zulkifli
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Muhammad Husaini Zulkifli @ 2021-02-19 16:36 UTC (permalink / raw)
To: intel-wired-lan
Hi,
Kindly help to review below patches.
Summary of each patches as per below:
Patch 1: To fix "Advertised pause frame use" advertising when tx and rx are in off state with AutoNegotiate off.
Patch 2: To fix "Supported pause frame use" output via ethtool where the bit is not set.
Tested with Intel? Ethernet Controller I225(Rev4).
Thanks.
Muhammad Husaini Zulkifli (2):
igc: Fix Pause Frame Advertising
igc: Fix Supported Pause Frame Link Setting
drivers/net/ethernet/intel/igc/igc_ethtool.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
--
2.17.1
^ permalink raw reply [flat|nested] 8+ messages in thread* [Intel-wired-lan] [PATCH net v1 1/2] igc: Fix Pause Frame Advertising
2021-02-19 16:36 [Intel-wired-lan] [PATCH net v1 0/2] igc: Fix Pause Frame Advertising Muhammad Husaini Zulkifli
@ 2021-02-19 16:36 ` Muhammad Husaini Zulkifli
2021-02-20 17:31 ` Neftin, Sasha
2021-03-03 8:08 ` Dvora Fuxbrumer
2021-02-19 16:36 ` [Intel-wired-lan] [PATCH net v1 2/2] igc: Fix Supported Pause Frame Link Setting Muhammad Husaini Zulkifli
2021-03-03 8:08 ` [Intel-wired-lan] [PATCH net v1 0/2] igc: Fix Pause Frame Advertising Dvora Fuxbrumer
2 siblings, 2 replies; 8+ messages in thread
From: Muhammad Husaini Zulkifli @ 2021-02-19 16:36 UTC (permalink / raw)
To: intel-wired-lan
Fix Pause Frame Advertising when getting the advertisement via ethtool.
Remove setting the "advertising" bit in link_ksettings during default
case when tx and rx are in off state with Auto Negotiatiate off.
Below is the original output of advertisement link during tx and rx off:
Advertised pause frame use: Symmetric Receive-only
Expected output:
Advertised pause frame use: No
Fixes: 8c5ad0dae93c ("igc: Add ethtool support")
Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
Reviewed-by: Malli C <mallikarjuna.chilakala@intel.com>
---
drivers/net/ethernet/intel/igc/igc_ethtool.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
index 824a6c454bca..67a4aed45fc2 100644
--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
@@ -1725,9 +1725,7 @@ static int igc_ethtool_get_link_ksettings(struct net_device *netdev,
Asym_Pause);
break;
default:
- ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause);
- ethtool_link_ksettings_add_link_mode(cmd, advertising,
- Asym_Pause);
+ break;
}
status = pm_runtime_suspended(&adapter->pdev->dev) ?
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Intel-wired-lan] [PATCH net v1 1/2] igc: Fix Pause Frame Advertising
2021-02-19 16:36 ` [Intel-wired-lan] [PATCH net v1 1/2] " Muhammad Husaini Zulkifli
@ 2021-02-20 17:31 ` Neftin, Sasha
2021-03-03 8:08 ` Dvora Fuxbrumer
1 sibling, 0 replies; 8+ messages in thread
From: Neftin, Sasha @ 2021-02-20 17:31 UTC (permalink / raw)
To: intel-wired-lan
On 2/19/2021 18:36, Muhammad Husaini Zulkifli wrote:
> Fix Pause Frame Advertising when getting the advertisement via ethtool.
> Remove setting the "advertising" bit in link_ksettings during default
> case when tx and rx are in off state with Auto Negotiatiate off.
>
> Below is the original output of advertisement link during tx and rx off:
> Advertised pause frame use: Symmetric Receive-only
>
> Expected output:
> Advertised pause frame use: No
>
> Fixes: 8c5ad0dae93c ("igc: Add ethtool support")
> Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
> Reviewed-by: Malli C <mallikarjuna.chilakala@intel.com>
> ---
> drivers/net/ethernet/intel/igc/igc_ethtool.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> index 824a6c454bca..67a4aed45fc2 100644
> --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
> +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> @@ -1725,9 +1725,7 @@ static int igc_ethtool_get_link_ksettings(struct net_device *netdev,
> Asym_Pause);
> break;
> default:
> - ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause);
> - ethtool_link_ksettings_add_link_mode(cmd, advertising,
> - Asym_Pause);
> + break;
> }
>
> status = pm_runtime_suspended(&adapter->pdev->dev) ?
>
Acked-by: Sasha Neftin <sasha.neftin@intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* [Intel-wired-lan] [PATCH net v1 1/2] igc: Fix Pause Frame Advertising
2021-02-19 16:36 ` [Intel-wired-lan] [PATCH net v1 1/2] " Muhammad Husaini Zulkifli
2021-02-20 17:31 ` Neftin, Sasha
@ 2021-03-03 8:08 ` Dvora Fuxbrumer
1 sibling, 0 replies; 8+ messages in thread
From: Dvora Fuxbrumer @ 2021-03-03 8:08 UTC (permalink / raw)
To: intel-wired-lan
On 19/02/2021 18:36, Muhammad Husaini Zulkifli wrote:
> Fix Pause Frame Advertising when getting the advertisement via ethtool.
> Remove setting the "advertising" bit in link_ksettings during default
> case when tx and rx are in off state with Auto Negotiatiate off.
>
> Below is the original output of advertisement link during tx and rx off:
> Advertised pause frame use: Symmetric Receive-only
>
> Expected output:
> Advertised pause frame use: No
>
> Fixes: 8c5ad0dae93c ("igc: Add ethtool support")
> Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
> Reviewed-by: Malli C <mallikarjuna.chilakala@intel.com>
> ---
> drivers/net/ethernet/intel/igc/igc_ethtool.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> index 824a6c454bca..67a4aed45fc2 100644
> --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
> +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> @@ -1725,9 +1725,7 @@ static int igc_ethtool_get_link_ksettings(struct net_device *netdev,
> Asym_Pause);
> break;
> default:
> - ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause);
> - ethtool_link_ksettings_add_link_mode(cmd, advertising,
> - Asym_Pause);
> + break;
> }
>
> status = pm_runtime_suspended(&adapter->pdev->dev) ?
>
Tested-by: Dvora Fuxbrumer <dvorax.fuxbrumer@linux.intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-wired-lan] [PATCH net v1 2/2] igc: Fix Supported Pause Frame Link Setting
2021-02-19 16:36 [Intel-wired-lan] [PATCH net v1 0/2] igc: Fix Pause Frame Advertising Muhammad Husaini Zulkifli
2021-02-19 16:36 ` [Intel-wired-lan] [PATCH net v1 1/2] " Muhammad Husaini Zulkifli
@ 2021-02-19 16:36 ` Muhammad Husaini Zulkifli
2021-03-03 8:09 ` Dvora Fuxbrumer
2021-03-03 8:08 ` [Intel-wired-lan] [PATCH net v1 0/2] igc: Fix Pause Frame Advertising Dvora Fuxbrumer
2 siblings, 1 reply; 8+ messages in thread
From: Muhammad Husaini Zulkifli @ 2021-02-19 16:36 UTC (permalink / raw)
To: intel-wired-lan
The Supported Pause Frame always display "No" eventhough the Advertised
pause frame showing the correct setting based on the pause parameters via
ethtool. Set bit in link_ksettings to "Supported" for Pause Frame.
Before output:
Supported pause frame use: No
Expected output:
Supported pause frame use: Symmetric
Fixes: 8c5ad0dae93c ("igc: Add ethtool support")
Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
Reviewed-by: Malli C <mallikarjuna.chilakala@intel.com>
---
drivers/net/ethernet/intel/igc/igc_ethtool.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
index 67a4aed45fc2..8722294ab90c 100644
--- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
+++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
@@ -1711,6 +1711,9 @@ static int igc_ethtool_get_link_ksettings(struct net_device *netdev,
Autoneg);
}
+ /* Set pause flow control settings */
+ ethtool_link_ksettings_add_link_mode(cmd, supported, Pause);
+
switch (hw->fc.requested_mode) {
case igc_fc_full:
ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause);
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread* [Intel-wired-lan] [PATCH net v1 2/2] igc: Fix Supported Pause Frame Link Setting
2021-02-19 16:36 ` [Intel-wired-lan] [PATCH net v1 2/2] igc: Fix Supported Pause Frame Link Setting Muhammad Husaini Zulkifli
@ 2021-03-03 8:09 ` Dvora Fuxbrumer
2021-03-03 9:26 ` Neftin, Sasha
0 siblings, 1 reply; 8+ messages in thread
From: Dvora Fuxbrumer @ 2021-03-03 8:09 UTC (permalink / raw)
To: intel-wired-lan
On 19/02/2021 18:36, Muhammad Husaini Zulkifli wrote:
> The Supported Pause Frame always display "No" eventhough the Advertised
> pause frame showing the correct setting based on the pause parameters via
> ethtool. Set bit in link_ksettings to "Supported" for Pause Frame.
>
> Before output:
> Supported pause frame use: No
>
> Expected output:
> Supported pause frame use: Symmetric
>
> Fixes: 8c5ad0dae93c ("igc: Add ethtool support")
> Signed-off-by: Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@intel.com>
> Reviewed-by: Malli C <mallikarjuna.chilakala@intel.com>
> ---
> drivers/net/ethernet/intel/igc/igc_ethtool.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> index 67a4aed45fc2..8722294ab90c 100644
> --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
> +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
> @@ -1711,6 +1711,9 @@ static int igc_ethtool_get_link_ksettings(struct net_device *netdev,
> Autoneg);
> }
>
> + /* Set pause flow control settings */
> + ethtool_link_ksettings_add_link_mode(cmd, supported, Pause);
> +
> switch (hw->fc.requested_mode) {
> case igc_fc_full:
> ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause);
>
Tested-by: Dvora Fuxbrumer <dvorax.fuxbrumer@linux.intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread* [Intel-wired-lan] [PATCH net v1 2/2] igc: Fix Supported Pause Frame Link Setting
2021-03-03 8:09 ` Dvora Fuxbrumer
@ 2021-03-03 9:26 ` Neftin, Sasha
0 siblings, 0 replies; 8+ messages in thread
From: Neftin, Sasha @ 2021-03-03 9:26 UTC (permalink / raw)
To: intel-wired-lan
On 3/3/2021 10:09, Dvora Fuxbrumer wrote:
> On 19/02/2021 18:36, Muhammad Husaini Zulkifli wrote:
>> The Supported Pause Frame always display "No" eventhough the Advertised
>> pause frame showing the correct setting based on the pause parameters via
>> ethtool. Set bit in link_ksettings to "Supported" for Pause Frame.
>>
>> Before output:
>> Supported pause frame use: No
>>
>> Expected output:
>> Supported pause frame use: Symmetric
>>
>> Fixes: 8c5ad0dae93c ("igc: Add ethtool support")
>> Signed-off-by: Muhammad Husaini Zulkifli
>> <muhammad.husaini.zulkifli@intel.com>
>> Reviewed-by: Malli C <mallikarjuna.chilakala@intel.com>
>> ---
>> ? drivers/net/ethernet/intel/igc/igc_ethtool.c | 3 +++
>> ? 1 file changed, 3 insertions(+)
>>
>> diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> b/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> index 67a4aed45fc2..8722294ab90c 100644
>> --- a/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> +++ b/drivers/net/ethernet/intel/igc/igc_ethtool.c
>> @@ -1711,6 +1711,9 @@ static int igc_ethtool_get_link_ksettings(struct
>> net_device *netdev,
>> ?????????????????????????????? Autoneg);
>> ????? }
>> +??? /* Set pause flow control settings */
>> +??? ethtool_link_ksettings_add_link_mode(cmd, supported, Pause);
>> +
>> ????? switch (hw->fc.requested_mode) {
>> ????? case igc_fc_full:
>> ????????? ethtool_link_ksettings_add_link_mode(cmd, advertising, Pause);
>>
> Tested-by: Dvora Fuxbrumer <dvorax.fuxbrumer@linux.intel.com>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
Acked-by: Sasha Neftin <sasha.neftin@intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Intel-wired-lan] [PATCH net v1 0/2] igc: Fix Pause Frame Advertising
2021-02-19 16:36 [Intel-wired-lan] [PATCH net v1 0/2] igc: Fix Pause Frame Advertising Muhammad Husaini Zulkifli
2021-02-19 16:36 ` [Intel-wired-lan] [PATCH net v1 1/2] " Muhammad Husaini Zulkifli
2021-02-19 16:36 ` [Intel-wired-lan] [PATCH net v1 2/2] igc: Fix Supported Pause Frame Link Setting Muhammad Husaini Zulkifli
@ 2021-03-03 8:08 ` Dvora Fuxbrumer
2 siblings, 0 replies; 8+ messages in thread
From: Dvora Fuxbrumer @ 2021-03-03 8:08 UTC (permalink / raw)
To: intel-wired-lan
On 19/02/2021 18:36, Muhammad Husaini Zulkifli wrote:
> Hi,
>
> Kindly help to review below patches.
>
> Summary of each patches as per below:
> Patch 1: To fix "Advertised pause frame use" advertising when tx and rx are in off state with AutoNegotiate off.
> Patch 2: To fix "Supported pause frame use" output via ethtool where the bit is not set.
>
> Tested with Intel? Ethernet Controller I225(Rev4).
>
> Thanks.
>
> Muhammad Husaini Zulkifli (2):
> igc: Fix Pause Frame Advertising
> igc: Fix Supported Pause Frame Link Setting
>
> drivers/net/ethernet/intel/igc/igc_ethtool.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> --
> 2.17.1
>
> _______________________________________________
> Intel-wired-lan mailing list
> Intel-wired-lan at osuosl.org
> https://lists.osuosl.org/mailman/listinfo/intel-wired-lan
>
Tested-by: Dvora Fuxbrumer <dvorax.fuxbrumer@linux.intel.com>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2021-03-03 9:26 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-02-19 16:36 [Intel-wired-lan] [PATCH net v1 0/2] igc: Fix Pause Frame Advertising Muhammad Husaini Zulkifli
2021-02-19 16:36 ` [Intel-wired-lan] [PATCH net v1 1/2] " Muhammad Husaini Zulkifli
2021-02-20 17:31 ` Neftin, Sasha
2021-03-03 8:08 ` Dvora Fuxbrumer
2021-02-19 16:36 ` [Intel-wired-lan] [PATCH net v1 2/2] igc: Fix Supported Pause Frame Link Setting Muhammad Husaini Zulkifli
2021-03-03 8:09 ` Dvora Fuxbrumer
2021-03-03 9:26 ` Neftin, Sasha
2021-03-03 8:08 ` [Intel-wired-lan] [PATCH net v1 0/2] igc: Fix Pause Frame Advertising Dvora Fuxbrumer
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.