From: Wen Gong <wgong@codeaurora.org>
To: Pi-Hsun Shih <pihsun@chromium.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH v8 1/4] ath10k: disable TX complete indication of htt for sdio
Date: Tue, 11 Feb 2020 17:46:25 +0800 [thread overview]
Message-ID: <25fd4f59b39c56b2fee208713c7cbc57@codeaurora.org> (raw)
In-Reply-To: <76bce8e3-e05b-ace6-3edd-54f522be3fe6@chromium.org>
On 2020-02-11 15:03, Pi-Hsun Shih wrote:
> Hi,
>
> On 11/28/19 6:30 PM, Wen Gong wrote:
>> ...
>> diff --git a/drivers/net/wireless/ath/ath10k/htt_tx.c
>> b/drivers/net/wireless/ath/ath10k/htt_tx.c
>> index a182c0944cc7..c6c4b2a4d20f 100644
>> --- a/drivers/net/wireless/ath/ath10k/htt_tx.c
>> +++ b/drivers/net/wireless/ath/ath10k/htt_tx.c
>> @@ -543,7 +543,35 @@ void ath10k_htt_tx_free(struct ath10k_htt *htt)
>> void ath10k_htt_htc_tx_complete(struct ath10k *ar, struct sk_buff
>> *skb)
>> {
>> + struct ath10k_htt *htt = &ar->htt;
>> + struct htt_tx_done tx_done = {0};
>> + struct htt_cmd_hdr *htt_hdr;
>> + struct htt_data_tx_desc *desc_hdr;
>> + u16 flags1;
>> +
>> dev_kfree_skb_any(skb);
>> +
>> + if (!htt->disable_tx_comp)
>> + return;
>> +
>> + htt_hdr = (struct htt_cmd_hdr *)skb->data;
>
> skb is already freed on the above line (dev_kfree_skb_any) but is
> still used here, should the dev_kfree_skb_any be moved to the end of
> this function?
>
skb will not freed on the above line, please see this patch
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/drivers/net/wireless/ath/ath10k?h=ath-next&id=30382dd1cf3a141bfaa568ee183c1892090fa79a
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Wen Gong <wgong@codeaurora.org>
To: Pi-Hsun Shih <pihsun@chromium.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH v8 1/4] ath10k: disable TX complete indication of htt for sdio
Date: Tue, 11 Feb 2020 17:46:25 +0800 [thread overview]
Message-ID: <25fd4f59b39c56b2fee208713c7cbc57@codeaurora.org> (raw)
In-Reply-To: <76bce8e3-e05b-ace6-3edd-54f522be3fe6@chromium.org>
On 2020-02-11 15:03, Pi-Hsun Shih wrote:
> Hi,
>
> On 11/28/19 6:30 PM, Wen Gong wrote:
>> ...
>> diff --git a/drivers/net/wireless/ath/ath10k/htt_tx.c
>> b/drivers/net/wireless/ath/ath10k/htt_tx.c
>> index a182c0944cc7..c6c4b2a4d20f 100644
>> --- a/drivers/net/wireless/ath/ath10k/htt_tx.c
>> +++ b/drivers/net/wireless/ath/ath10k/htt_tx.c
>> @@ -543,7 +543,35 @@ void ath10k_htt_tx_free(struct ath10k_htt *htt)
>> void ath10k_htt_htc_tx_complete(struct ath10k *ar, struct sk_buff
>> *skb)
>> {
>> + struct ath10k_htt *htt = &ar->htt;
>> + struct htt_tx_done tx_done = {0};
>> + struct htt_cmd_hdr *htt_hdr;
>> + struct htt_data_tx_desc *desc_hdr;
>> + u16 flags1;
>> +
>> dev_kfree_skb_any(skb);
>> +
>> + if (!htt->disable_tx_comp)
>> + return;
>> +
>> + htt_hdr = (struct htt_cmd_hdr *)skb->data;
>
> skb is already freed on the above line (dev_kfree_skb_any) but is
> still used here, should the dev_kfree_skb_any be moved to the end of
> this function?
>
skb will not freed on the above line, please see this patch
https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/ath.git/commit/drivers/net/wireless/ath/ath10k?h=ath-next&id=30382dd1cf3a141bfaa568ee183c1892090fa79a
next prev parent reply other threads:[~2020-02-11 9:46 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191128103030.6429-1-wgong@codeaurora.org>
2019-11-28 10:30 ` [PATCH v8 1/4] ath10k: disable TX complete indication of htt for sdio Wen Gong
2020-02-11 7:03 ` Pi-Hsun Shih
2020-02-11 7:03 ` Pi-Hsun Shih
2020-02-11 9:46 ` Wen Gong [this message]
2020-02-11 9:46 ` Wen Gong
2020-02-11 11:11 ` Pi-Hsun Shih
2020-02-11 11:11 ` Pi-Hsun Shih
2020-02-12 4:58 ` Wen Gong
2020-02-12 4:58 ` Wen Gong
2020-02-12 5:31 ` Pi-Hsun Shih
2020-02-12 5:31 ` Pi-Hsun Shih
2020-02-12 6:47 ` Wen Gong
2020-02-12 6:47 ` Wen Gong
2020-02-12 7:08 ` Pi-Hsun Shih
2020-02-12 7:08 ` Pi-Hsun Shih
2020-02-12 7:31 ` Wen Gong
2020-02-12 7:31 ` Wen Gong
2020-02-12 7:45 ` Pi-Hsun Shih
2020-02-12 7:45 ` Pi-Hsun Shih
2020-02-12 8:09 ` Wen Gong
2020-02-12 8:09 ` Wen Gong
2019-11-28 10:30 ` [PATCH v8 2/4] ath10k: change ATH10K_SDIO_BUS_REQUEST_MAX_NUM from 64 to 1024 Wen Gong
2019-11-28 10:30 ` [PATCH v8 1/4] ath10k: disable TX complete indication of htt for sdio Wen Gong
2019-11-28 10:30 ` [PATCH v8 2/4] ath10k: change ATH10K_SDIO_BUS_REQUEST_MAX_NUM from 64 to 1024 Wen Gong
2019-11-28 10:30 ` [PATCH v8 3/4] ath10k: add htt TX bundle for sdio Wen Gong
2019-11-28 10:30 ` [PATCH v8 4/4] ath10k: enable alt data of TX path " Wen Gong
2019-11-28 10:30 ` Wen Gong
2019-11-28 10:30 ` [PATCH v8 3/4] ath10k: add htt TX bundle " Wen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25fd4f59b39c56b2fee208713c7cbc57@codeaurora.org \
--to=wgong@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=pihsun@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.