All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Rob Clark <robdclark@gmail.com>, Doug Anderson <dianders@chromium.org>
Cc: dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org,
	Maxime Ripard <maxime@cerno.tech>,
	Stephen Boyd <swboyd@chromium.org>,
	Rob Clark <robdclark@chromium.org>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Robert Foss <robert.foss@linaro.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Jonas Karlman <jonas@kwiboo.se>, David Airlie <airlied@linux.ie>,
	Daniel Vetter <daniel@ffwll.ch>, Sam Ravnborg <sam@ravnborg.org>,
	open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/bridge: sn65dsi86: defer if there is no dsi host
Date: Tue, 07 Dec 2021 21:35:15 +0100	[thread overview]
Message-ID: <2606289.mvXUDI8C0e@jernej-laptop> (raw)
In-Reply-To: <CAD=FV=X81r4eBPYz_v6vju8bpUJX+HWS1vUuO+oC0AJUWsnCRg@mail.gmail.com>

Dne torek, 07. december 2021 ob 21:26:50 CET je Doug Anderson napisal(a):
> Hi,
> 
> On Tue, Dec 7, 2021 at 12:03 PM Rob Clark <robdclark@gmail.com> wrote:
> > From: Rob Clark <robdclark@chromium.org>
> > 
> > Otherwise we don't get another shot at it if the bridge probes before
> > the dsi host is registered.  It seems like this is what *most* (but not
> > all) of the other bridges do.
> > 
> > It looks like this was missed in the conversion to attach dsi host at
> > probe time.
> > 
> > Fixes: c3b75d4734cb ("drm/bridge: sn65dsi86: Register and attach our DSI
> > device at probe") Signed-off-by: Rob Clark <robdclark@chromium.org>
> > ---
> > 
> >  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> > b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index 02b490671f8f..3684e12fbac3
> > 100644
> > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> > @@ -716,7 +716,7 @@ static int ti_sn_attach_host(struct ti_sn65dsi86
> > *pdata)> 
> >         host = of_find_mipi_dsi_host_by_node(pdata->host_node);
> >         if (!host) {
> >         
> >                 DRM_ERROR("failed to find dsi host\n");
> > 
> > -               return -ENODEV;
> > +               return -EPROBE_DEFER;
> 
> Can you delete the DRM_ERROR line?

or use dev_err_probe()

Best regards,
Jernej




WARNING: multiple messages have this Message-ID (diff)
From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Rob Clark <robdclark@gmail.com>, Doug Anderson <dianders@chromium.org>
Cc: Rob Clark <robdclark@chromium.org>,
	Neil Armstrong <narmstrong@baylibre.com>,
	David Airlie <airlied@linux.ie>,
	linux-arm-msm@vger.kernel.org, Jonas Karlman <jonas@kwiboo.se>,
	open list <linux-kernel@vger.kernel.org>,
	dri-devel@lists.freedesktop.org,
	Stephen Boyd <swboyd@chromium.org>,
	Andrzej Hajda <a.hajda@samsung.com>,
	Maxime Ripard <maxime@cerno.tech>,
	Sam Ravnborg <sam@ravnborg.org>,
	Robert Foss <robert.foss@linaro.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Subject: Re: [PATCH] drm/bridge: sn65dsi86: defer if there is no dsi host
Date: Tue, 07 Dec 2021 21:35:15 +0100	[thread overview]
Message-ID: <2606289.mvXUDI8C0e@jernej-laptop> (raw)
In-Reply-To: <CAD=FV=X81r4eBPYz_v6vju8bpUJX+HWS1vUuO+oC0AJUWsnCRg@mail.gmail.com>

Dne torek, 07. december 2021 ob 21:26:50 CET je Doug Anderson napisal(a):
> Hi,
> 
> On Tue, Dec 7, 2021 at 12:03 PM Rob Clark <robdclark@gmail.com> wrote:
> > From: Rob Clark <robdclark@chromium.org>
> > 
> > Otherwise we don't get another shot at it if the bridge probes before
> > the dsi host is registered.  It seems like this is what *most* (but not
> > all) of the other bridges do.
> > 
> > It looks like this was missed in the conversion to attach dsi host at
> > probe time.
> > 
> > Fixes: c3b75d4734cb ("drm/bridge: sn65dsi86: Register and attach our DSI
> > device at probe") Signed-off-by: Rob Clark <robdclark@chromium.org>
> > ---
> > 
> >  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> > b/drivers/gpu/drm/bridge/ti-sn65dsi86.c index 02b490671f8f..3684e12fbac3
> > 100644
> > --- a/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> > +++ b/drivers/gpu/drm/bridge/ti-sn65dsi86.c
> > @@ -716,7 +716,7 @@ static int ti_sn_attach_host(struct ti_sn65dsi86
> > *pdata)> 
> >         host = of_find_mipi_dsi_host_by_node(pdata->host_node);
> >         if (!host) {
> >         
> >                 DRM_ERROR("failed to find dsi host\n");
> > 
> > -               return -ENODEV;
> > +               return -EPROBE_DEFER;
> 
> Can you delete the DRM_ERROR line?

or use dev_err_probe()

Best regards,
Jernej




  reply	other threads:[~2021-12-07 20:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-07 20:09 [PATCH] drm/bridge: sn65dsi86: defer if there is no dsi host Rob Clark
2021-12-07 20:09 ` Rob Clark
2021-12-07 20:26 ` Doug Anderson
2021-12-07 20:26   ` Doug Anderson
2021-12-07 20:35   ` Jernej Škrabec [this message]
2021-12-07 20:35     ` Jernej Škrabec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2606289.mvXUDI8C0e@jernej-laptop \
    --to=jernej.skrabec@gmail.com \
    --cc=a.hajda@samsung.com \
    --cc=airlied@linux.ie \
    --cc=daniel@ffwll.ch \
    --cc=dianders@chromium.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jonas@kwiboo.se \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=maxime@cerno.tech \
    --cc=narmstrong@baylibre.com \
    --cc=robdclark@chromium.org \
    --cc=robdclark@gmail.com \
    --cc=robert.foss@linaro.org \
    --cc=sam@ravnborg.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.