From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Simon Horman <horms@verge.net.au>,
linux-sh@vger.kernel.org, Saugata Das <saugata.das@linaro.org>,
Girish Shivananjappa <girish.shivananjappa@linaro.org>
Subject: Re: [PATCH] mmc: sh_mmcif: Support MMC_SLEEP_AWAKE command
Date: Wed, 20 Jun 2012 15:06:36 +0200 [thread overview]
Message-ID: <2609967.tcqa2xCl8R@avalon> (raw)
In-Reply-To: <CAPDyKFo_my_+xQOKYooNawtJ1b3Ncm2osNg9TMN8YpftXfr+Jg@mail.gmail.com>
Hi Ulf,
On Wednesday 20 June 2012 13:54:33 Ulf Hansson wrote:
> Hi Laurent,
>
> Your issue seem more related to a mmc protocol problem. Likely caused
> by a bad patch for eMMC 4.5 poweroff notify. The patch I refer to is:
> "mmc: core: Fix PowerOff Notify suspend/resume"
>
> You may try to revert this patch and see if the same problem occurs for you.
>
> We are trying to fix the issue inserted by the above commit in a patch
> named: "MMC-4.5 Power OFF Notify Rework", please have a look if you have
> the time.
I think the two issues are othorgonal (but please feel free to tell me if
there's something I'm missing).
The MMCIF controller driver rejects the MMC_SLEEP_AWAKE command
unconditionally, even though it should be accepted, because it happens to
share the command number with an SDIO command (SD_IO_SEND_OP_COND) used to
probe SDIO support. My patch fixes this by accepting the MMC_SLEEP_AWAKE
command but still rejecting the SD_IO_SEND_OP_COND command.
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-mmc@vger.kernel.org,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
Simon Horman <horms@verge.net.au>,
linux-sh@vger.kernel.org, Saugata Das <saugata.das@linaro.org>,
Girish Shivananjappa <girish.shivananjappa@linaro.org>
Subject: Re: [PATCH] mmc: sh_mmcif: Support MMC_SLEEP_AWAKE command
Date: Wed, 20 Jun 2012 13:06:36 +0000 [thread overview]
Message-ID: <2609967.tcqa2xCl8R@avalon> (raw)
In-Reply-To: <CAPDyKFo_my_+xQOKYooNawtJ1b3Ncm2osNg9TMN8YpftXfr+Jg@mail.gmail.com>
Hi Ulf,
On Wednesday 20 June 2012 13:54:33 Ulf Hansson wrote:
> Hi Laurent,
>
> Your issue seem more related to a mmc protocol problem. Likely caused
> by a bad patch for eMMC 4.5 poweroff notify. The patch I refer to is:
> "mmc: core: Fix PowerOff Notify suspend/resume"
>
> You may try to revert this patch and see if the same problem occurs for you.
>
> We are trying to fix the issue inserted by the above commit in a patch
> named: "MMC-4.5 Power OFF Notify Rework", please have a look if you have
> the time.
I think the two issues are othorgonal (but please feel free to tell me if
there's something I'm missing).
The MMCIF controller driver rejects the MMC_SLEEP_AWAKE command
unconditionally, even though it should be accepted, because it happens to
share the command number with an SDIO command (SD_IO_SEND_OP_COND) used to
probe SDIO support. My patch fixes this by accepting the MMC_SLEEP_AWAKE
command but still rejecting the SD_IO_SEND_OP_COND command.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2012-06-20 13:06 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 20:56 [PATCH] mmc: sh_mmcif: Support MMC_SLEEP_AWAKE command Laurent Pinchart
2012-06-12 20:56 ` Laurent Pinchart
2012-06-13 1:12 ` Simon Horman
2012-06-13 1:12 ` Simon Horman
2012-06-13 7:39 ` Laurent Pinchart
2012-06-13 7:39 ` Laurent Pinchart
2012-06-20 6:42 ` Simon Horman
2012-06-20 6:42 ` Simon Horman
2012-06-20 10:51 ` Laurent Pinchart
2012-06-20 10:51 ` Laurent Pinchart
2012-06-13 13:27 ` Guennadi Liakhovetski
2012-06-13 13:27 ` Guennadi Liakhovetski
2012-06-20 6:21 ` Chris Ball
2012-06-20 6:21 ` Chris Ball
2012-06-20 11:54 ` Ulf Hansson
2012-06-20 11:54 ` Ulf Hansson
2012-06-20 13:06 ` Laurent Pinchart [this message]
2012-06-20 13:06 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2609967.tcqa2xCl8R@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=g.liakhovetski@gmx.de \
--cc=girish.shivananjappa@linaro.org \
--cc=horms@verge.net.au \
--cc=linux-mmc@vger.kernel.org \
--cc=linux-sh@vger.kernel.org \
--cc=saugata.das@linaro.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.