From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: "Wiles, Keith" <keith.wiles@intel.com>
Cc: dev@dpdk.org, "Damjan Marion (damarion)" <damarion@cisco.com>,
"viktorin@rehivetech.com" <viktorin@rehivetech.com>,
"Richardson, Bruce" <bruce.richardson@intel.com>,
"Ananyev, Konstantin" <konstantin.ananyev@intel.com>,
"david.marchand@6wind.com" <david.marchand@6wind.com>
Subject: Re: [PATCH] spinlock:move constructor function out of header
Date: Fri, 15 Jul 2016 10:16:48 +0200 [thread overview]
Message-ID: <2619559.1L0JRy07Sv@xps13> (raw)
In-Reply-To: <20AB3D71-1CAA-48BE-A764-3C17C35F0072@intel.com>
2016-07-14 22:45, Wiles, Keith:
> > On Jul 14, 2016, at 2:59 PM, Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> >
> > Thanks Keith for continuing work.
> >
> > 2016-07-14 14:31, Keith Wiles:
> >> lib/librte_eal/bsdapp/eal/Makefile | 1 +
> >> lib/librte_eal/common/arch/arm/rte_spinlock.c | 46 ++++++++++++++++++++++
> >> lib/librte_eal/common/arch/ppc_64/rte_spinlock.c | 46 ++++++++++++++++++++++
> >> lib/librte_eal/common/arch/tile/rte_spinlock.c | 46 ++++++++++++++++++++++
> >> lib/librte_eal/common/arch/x86/rte_spinlock.c | 46 ++++++++++++++++++++++
> >> .../common/include/arch/x86/rte_spinlock.h | 14 ++-----
> >> lib/librte_eal/linuxapp/eal/Makefile | 1 +
> >
> > I am not sure we should add a .c file for each arch, given it is called only
> > from arch/x86/rte_spinlock.h.
>
> I did not like having the .c for everyone, but the previous comment seemed
> to suggest it. I am willing to change it any better method, just let me
> know what you think. I would like just one.
I will make sure it is not needed. In this case, we can keep the original
patch from Damjan and just do some trivial changes. I can make them quickly
before RC3.
> On a side note I have combined the bsdapp and linuxapp into a single
> directory before. It is doable and it eliminates a number of duplicate
> files or code.
Yes patches to remove duplicated code are welcome. But please do not
introduce more #ifdefs. I think it is better to keep separate directories
bsdapp/ and linuxapp/ while increasing the shared code in common/ as
much as possible.
Some functions are really different and are better handled separately.
> Plus a also added support for OS X for DPDK, but I do not have access
> to any NICs with that version yet other then virtual ones.
> I could submit it and may be someone will write the kext to make it work. :-)
Maybe that OS X would deserve a third separate directory.
I guess you wanted it only for dev testing?
Why not just use a Linux or FreeBSD VM?
prev parent reply other threads:[~2016-07-15 8:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 21:31 [PATCH] spinlock:move constructor function out of header Keith Wiles
2016-07-14 21:59 ` Thomas Monjalon
2016-07-14 22:45 ` Wiles, Keith
2016-07-15 8:16 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2619559.1L0JRy07Sv@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=damarion@cisco.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.