From: Thomas Monjalon <thomas.monjalon@6wind.com>
To: Keith Wiles <keith.wiles@intel.com>
Cc: dev@dpdk.org, damarion@cisco.com, viktorin@rehivetech.com,
bruce.richardson@intel.com, konstantin.ananyev@intel.com,
david.marchand@6wind.com
Subject: Re: [PATCH] spinlock:move constructor function out of header
Date: Thu, 14 Jul 2016 14:59:01 -0700 (PDT) [thread overview]
Message-ID: <6049792.6bXVORrbVs@xps13> (raw)
In-Reply-To: <1468531886-34205-1-git-send-email-keith.wiles@intel.com>
Thanks Keith for continuing work.
2016-07-14 14:31, Keith Wiles:
> Moving the rte_rtm_init() constructor routine out of the
> header file and into a new rte_spinlock.c for all archs/platforms.
> Having constructor routines in a header file is not a good
> place to keep these types of functions.
>
> The problem is with linking 3rd party libraries when
> an application is not linked directly to dpdk libraries, which
> in this case causes a missing symbol in the linking phase.
>
> Fixes: ba7468997ea6 ("spinlock: add HTM lock elision for x86")
>
> Originally submitted by Damjan Marion <damarion@cisco.com>
You should keep the original Signed-off and authorship (From: field)
with "git am".
It is also easier to track when using -v2 --in-reply-to='<v1-id>'.
> Signed-off-by: Keith Wiles <keith.wiles@intel.com>
> ---
> lib/librte_eal/bsdapp/eal/Makefile | 1 +
> lib/librte_eal/common/arch/arm/rte_spinlock.c | 46 ++++++++++++++++++++++
> lib/librte_eal/common/arch/ppc_64/rte_spinlock.c | 46 ++++++++++++++++++++++
> lib/librte_eal/common/arch/tile/rte_spinlock.c | 46 ++++++++++++++++++++++
> lib/librte_eal/common/arch/x86/rte_spinlock.c | 46 ++++++++++++++++++++++
> .../common/include/arch/x86/rte_spinlock.h | 14 ++-----
> lib/librte_eal/linuxapp/eal/Makefile | 1 +
I am not sure we should add a .c file for each arch, given it is called only
from arch/x86/rte_spinlock.h.
next prev parent reply other threads:[~2016-07-14 21:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 21:31 [PATCH] spinlock:move constructor function out of header Keith Wiles
2016-07-14 21:59 ` Thomas Monjalon [this message]
2016-07-14 22:45 ` Wiles, Keith
2016-07-15 8:16 ` Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6049792.6bXVORrbVs@xps13 \
--to=thomas.monjalon@6wind.com \
--cc=bruce.richardson@intel.com \
--cc=damarion@cisco.com \
--cc=david.marchand@6wind.com \
--cc=dev@dpdk.org \
--cc=keith.wiles@intel.com \
--cc=konstantin.ananyev@intel.com \
--cc=viktorin@rehivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.