Patch for make install

Patch for make install

[Yves BLUSSEAU]

[-- Attachment #1: Type: text/plain, Size: 268 bytes --]

Hi,

this patch correct installation of headers files on Mac OSX.

Bug:
       cp: ./include/grub/cpu is a directory (not copied).

I have done a make install under OSX and linux after applying the  
patch. Now it works on the 2 systems.


Best Regards
Yves Blusseau


[-- Attachment #2: make_install.patch --]
[-- Type: application/octet-stream, Size: 487 bytes --]

diff --git a/Makefile.in b/Makefile.in
index f82566a..54a05d6 100644
--- a/Makefile.in
+++ b/Makefile.in
@@ -229,7 +229,7 @@ install-local: all
 	    $(INSTALL_DATA) $$dir$$file $(DESTDIR)$(includedir)/$$dest; \
 	  elif test -L "$$dir$$file"; then \
 	    rm -rf $(DESTDIR)$(includedir)/$$dest && \
-	    cp -fP $$dir$$file $(DESTDIR)$(includedir)/$$dest; \
+	    cp -fR $$dir$$file $(DESTDIR)$(includedir)/$$dest; \
 	  fi; \
 	done
 	$(SHELL) $(mkinstalldirs) $(DESTDIR)$(pkgdatadir)

[-- Attachment #3: Type: text/plain, Size: 1 bytes --]

Re: Patch for make install

[Pavel Roskin]

On Tue, 2009-06-30 at 22:20 +0200, Yves BLUSSEAU wrote:
> Hi,
> 
> this patch correct installation of headers files on Mac OSX.
> 
> Bug:
>        cp: ./include/grub/cpu is a directory (not copied).
> 
> I have done a make install under OSX and linux after applying the  
> patch. Now it works on the 2 systems.

Please provide the ChangeLog entry.  It's important that you explain the
patch.

I'd like to have a look how it would affect FreeBSD.  I remember that
there were more problems with header installation on FreeBSD 7.2, but I
didn't have a chance to take a close look.

-- 
Regards,
Pavel Roskin

Re: Patch for make install

[Vladimir 'phcoder' Serbinenko]

Hello

On Wed, Jul 1, 2009 at 2:54 AM, Pavel Roskin<proski@gnu.org> wrote:
> On Tue, 2009-06-30 at 22:20 +0200, Yves BLUSSEAU wrote:
>> Hi,
>>
>> this patch correct installation of headers files on Mac OSX.
>>
>> Bug:
>>        cp: ./include/grub/cpu is a directory (not copied).
>>
>> I have done a make install under OSX and linux after applying the
>> patch. Now it works on the 2 systems.
>
> Please provide the ChangeLog entry.  It's important that you explain the
> patch.
>
> I'd like to have a look how it would affect FreeBSD.  I remember that
> there were more problems with header installation on FreeBSD 7.2, but I
> didn't have a chance to take a close look.
>
Yesterday on IRC when I spoke with Yves I said exactly the same. I
have FreeBSD 8.0-current and will test this patch and whole grub for
regressions today
> --
> Regards,
> Pavel Roskin
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/grub-devel
>



-- 
Regards
Vladimir 'phcoder' Serbinenko

Personal git repository: http://repo.or.cz/w/grub2/phcoder.git

Re: Patch for make install

[Pavel Roskin]

On Tue, 2009-06-30 at 22:20 +0200, Yves BLUSSEAU wrote:
> Hi,
> 
> this patch correct installation of headers files on Mac OSX.
> 
> Bug:
>        cp: ./include/grub/cpu is a directory (not copied).
> 
> I have done a make install under OSX and linux after applying the  
> patch. Now it works on the 2 systems.

Your patch works on FreeBSD 7.2, so I've applied it with my ChangeLog
entry.

-- 
Regards,
Pavel Roskin