Re: [PATCH 1/5] videomode: simplify videomode Kconfig and Makefile

All of lore.kernel.org
 help / color / mirror / Atom feed

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Steffen Trumtrar <s.trumtrar@pengutronix.de>
Subject: Re: [PATCH 1/5] videomode: simplify videomode Kconfig and Makefile
Date: Tue, 12 Mar 2013 13:34:07 +0000	[thread overview]
Message-ID: <2623790.oJdsJXERqZ@avalon> (raw)
In-Reply-To: <1363083578-17062-1-git-send-email-tomi.valkeinen@ti.com>

Hi Tomi,

Thanks for the patch.

On Tuesday 12 March 2013 12:19:34 Tomi Valkeinen wrote:
> This patch simplifies videomode related Kconfig and Makefile. After this
> patch, there's only one non-user selectable Kconfig option left,
> VIDEOMODE_HELPERS. The reasons for the change:
> 
> * Videomode helper functions are not something that should be shown in
>   the kernel configuration options. The related code should just be
>   included if it's needed, i.e. selected by drivers using videomode.
> 
> * There's no need to have separate Kconfig options for videomode and
>   display_timing. First of all, the amount of code for both is quite
>   small. Second, videomode depends on display_timing, and display_timing
>   in itself is not really useful, so both would be included in any case.
> 
> * CONFIG_VIDEOMODE is a bit vague name, and CONFIG_VIDEOMODE_HELPERS
>   describes better what's included.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>

I like that.

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

-- 
Regards,

Laurent Pinchart

WARNING: multiple messages have this Message-ID (diff)

From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tomi Valkeinen <tomi.valkeinen@ti.com>
Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org,
	Steffen Trumtrar <s.trumtrar@pengutronix.de>
Subject: Re: [PATCH 1/5] videomode: simplify videomode Kconfig and Makefile
Date: Tue, 12 Mar 2013 14:34:07 +0100	[thread overview]
Message-ID: <2623790.oJdsJXERqZ@avalon> (raw)
In-Reply-To: <1363083578-17062-1-git-send-email-tomi.valkeinen@ti.com>

Hi Tomi,

Thanks for the patch.

On Tuesday 12 March 2013 12:19:34 Tomi Valkeinen wrote:
> This patch simplifies videomode related Kconfig and Makefile. After this
> patch, there's only one non-user selectable Kconfig option left,
> VIDEOMODE_HELPERS. The reasons for the change:
> 
> * Videomode helper functions are not something that should be shown in
>   the kernel configuration options. The related code should just be
>   included if it's needed, i.e. selected by drivers using videomode.
> 
> * There's no need to have separate Kconfig options for videomode and
>   display_timing. First of all, the amount of code for both is quite
>   small. Second, videomode depends on display_timing, and display_timing
>   in itself is not really useful, so both would be included in any case.
> 
> * CONFIG_VIDEOMODE is a bit vague name, and CONFIG_VIDEOMODE_HELPERS
>   describes better what's included.
> 
> Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti.com>
> Cc: Steffen Trumtrar <s.trumtrar@pengutronix.de>

I like that.

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

-- 
Regards,

Laurent Pinchart

next prev parent reply	other threads:[~2013-03-12 13:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-03-12 10:19 [PATCH 1/5] videomode: simplify videomode Kconfig and Makefile Tomi Valkeinen
2013-03-12 10:19 ` Tomi Valkeinen
2013-03-12 10:19 ` [PATCH 2/5] videomode: combine videomode dmt_flags and data_flags Tomi Valkeinen
2013-03-12 10:19   ` Tomi Valkeinen
2013-03-12 10:19 ` [PATCH 3/5] videomode: create enum for videomode's display flags Tomi Valkeinen
2013-03-12 10:19   ` Tomi Valkeinen
2013-03-12 10:19 ` [PATCH 4/5] videomode: remove timing_entry_index Tomi Valkeinen
2013-03-12 10:19   ` Tomi Valkeinen
2013-03-12 10:19 ` [PATCH 5/5] videomode: rename fields Tomi Valkeinen
2013-03-12 10:19   ` Tomi Valkeinen
2013-03-12 13:37   ` Laurent Pinchart
2013-03-12 13:37     ` Laurent Pinchart
2013-03-12 13:40     ` Tomi Valkeinen
2013-03-12 13:40       ` Tomi Valkeinen
2013-03-18  7:58       ` Daniel Vetter
2013-03-18  8:00         ` Daniel Vetter
2013-03-18 12:28         ` Tomi Valkeinen
2013-03-18 12:28           ` Tomi Valkeinen
2013-03-12 13:53   ` Steffen Trumtrar
2013-03-12 13:53     ` Steffen Trumtrar
2013-03-12 13:34 ` Laurent Pinchart [this message]
2013-03-12 13:34   ` [PATCH 1/5] videomode: simplify videomode Kconfig and Makefile Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2623790.oJdsJXERqZ@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=s.trumtrar@pengutronix.de \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Be sure your reply has a Subject: header at the top and a blank line before the message body.

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.