All of lore.kernel.org
 help / color / mirror / Atom feed
From: Vladimir Testov <vladimir.testov@rosalab.ru>
To: Andrey Borzenkov <arvidjaar@gmail.com>
Cc: The development of GNU GRUB <grub-devel@gnu.org>
Subject: [PATCH] fix selected item's height
Date: Fri, 22 Feb 2013 13:28:45 +0400	[thread overview]
Message-ID: <2625645.NEvtgNsnSc@icedphoenix> (raw)
In-Reply-To: <20130221215607.59adc7b3@opensuse.site>

[-- Attachment #1: Type: text/plain, Size: 525 bytes --]


> selected item box is not really used to layout items. Only to adjust
> where the first item is placed, to allow for full top border to be
> displayed. Patch I just sent also adds space for lower border.

By the way, your patch is not absolutely correct. We should correct selected 
item's height. The formula you have presented do not consider the fact that 
selected item's height is decreased by 1.

Patch included.

-- 
With best regards,
_______________________________
Vladimir Testov, ROSA Laboratory.
www.rosalab.ru

[-- Attachment #2: grub2-fix-selected-item-height.patch --]
[-- Type: text/x-patch, Size: 621 bytes --]

diff -Naur grub-2.00/grub-core/gfxmenu/gui_list.c grub-tmp/grub-core/gfxmenu/gui_list.c
--- grub-2.00/grub-core/gfxmenu/gui_list.c	2011-12-14 14:36:07.000000000 +0400
+++ grub-tmp/grub-core/gfxmenu/gui_list.c	2013-02-22 13:24:01.496967086 +0400
@@ -252,7 +252,7 @@
 	  int cwidth = oviewport.width - 2 * boxpad - 2;
 	  if (selbox->get_border_width)
 	    cwidth -= selbox->get_border_width (selbox);
-	  selbox->set_content_size (selbox, cwidth, item_height - 1);
+	  selbox->set_content_size (selbox, cwidth, item_height);
           selbox->draw (selbox, 0,
                         item_top - sel_toppad);
         }

  reply	other threads:[~2013-02-22  9:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-07 10:07 fixed item-height, item-spacing, max-elements-shown etc Vladimir Testov
2013-02-21 17:56 ` Andrey Borzenkov
2013-02-22  9:28   ` Vladimir Testov [this message]
2013-02-22  9:32   ` Vladimir Testov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2625645.NEvtgNsnSc@icedphoenix \
    --to=vladimir.testov@rosalab.ru \
    --cc=arvidjaar@gmail.com \
    --cc=grub-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.