From: Damien Le Moal <dlemoal@kernel.org>
To: Easwar Hariharan <eahariha@linux.microsoft.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: "Yaron Avizrat" <yaron.avizrat@intel.com>,
"Oded Gabbay" <ogabbay@kernel.org>,
"Julia Lawall" <Julia.Lawall@inria.fr>,
"Nicolas Palix" <nicolas.palix@imag.fr>,
"James Smart" <james.smart@broadcom.com>,
"Dick Kennedy" <dick.kennedy@broadcom.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>, "Chris Mason" <clm@fb.com>,
"Josef Bacik" <josef@toxicpanda.com>,
"David Sterba" <dsterba@suse.com>,
"Ilya Dryomov" <idryomov@gmail.com>,
"Dongsheng Yang" <dongsheng.yang@easystack.cn>,
"Jens Axboe" <axboe@kernel.dk>, "Xiubo Li" <xiubli@redhat.com>,
"Niklas Cassel" <cassel@kernel.org>,
"Carlos Maiolino" <cem@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
"Sebastian Reichel" <sre@kernel.org>,
"Keith Busch" <kbusch@kernel.org>,
"Christoph Hellwig" <hch@lst.de>,
"Sagi Grimberg" <sagi@grimberg.me>, "Frank Li" <Frank.Li@nxp.com>,
"Mark Brown" <broonie@kernel.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
"Selvin Xavier" <selvin.xavier@broadcom.com>,
"Kalesh AP" <kalesh-anakkur.purayil@broadcom.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Leon Romanovsky" <leon@kernel.org>,
cocci@inria.fr, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-sound@vger.kernel.org, linux-btrfs@vger.kernel.org,
ceph-devel@vger.kernel.org, linux-block@vger.kernel.org,
linux-ide@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-pm@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-spi@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
platform-driver-x86@vger.kernel.org,
ibm-acpi-devel@lists.sourceforge.net, linux-rdma@vger.kernel.org
Subject: Re: [PATCH v3 08/16] ata: libata-zpodd: convert timeouts to secs_to_jiffies()
Date: Wed, 26 Feb 2025 11:00:37 +0900 [thread overview]
Message-ID: <2632bed9-4e4a-494a-bb89-d5aac64f854e@kernel.org> (raw)
In-Reply-To: <ff51bcfc-10c8-4461-9f82-ea1d5ed784f8@linux.microsoft.com>
On 2/26/25 5:24 AM, Easwar Hariharan wrote:
> On 2/25/2025 12:17 PM, Easwar Hariharan wrote:
>> Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced
>> secs_to_jiffies(). As the value here is a multiple of 1000, use
>> secs_to_jiffies() instead of msecs_to_jiffies() to avoid the multiplication
>>
>> This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with
>> the following Coccinelle rules:
>>
>> @depends on patch@
>> expression E;
>> @@
>>
>> -msecs_to_jiffies
>> +secs_to_jiffies
>> (E
>> - * \( 1000 \| MSEC_PER_SEC \)
>> )
>>
>> Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com>
>> ---
>
> This was meant to carry Damien's ack once the subject line was fixed[1], but I fixed
> the subject line and missed adding the ack in. Damien, would you like to ack again?
Looks like Andrew already applied the patch, which is fine.
But nevertheless:
Acked-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
WARNING: multiple messages have this Message-ID (diff)
From: Damien Le Moal <dlemoal@kernel.org>
To: Easwar Hariharan <eahariha@linux.microsoft.com>,
Andrew Morton <akpm@linux-foundation.org>
Cc: "Yaron Avizrat" <yaron.avizrat@intel.com>,
"Oded Gabbay" <ogabbay@kernel.org>,
"Julia Lawall" <Julia.Lawall@inria.fr>,
"Nicolas Palix" <nicolas.palix@imag.fr>,
"James Smart" <james.smart@broadcom.com>,
"Dick Kennedy" <dick.kennedy@broadcom.com>,
"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
"Jaroslav Kysela" <perex@perex.cz>,
"Takashi Iwai" <tiwai@suse.com>, "Chris Mason" <clm@fb.com>,
"Josef Bacik" <josef@toxicpanda.com>,
"David Sterba" <dsterba@suse.com>,
"Ilya Dryomov" <idryomov@gmail.com>,
"Dongsheng Yang" <dongsheng.yang@easystack.cn>,
"Jens Axboe" <axboe@kernel.dk>, "Xiubo Li" <xiubli@redhat.com>,
"Niklas Cassel" <cassel@kernel.org>,
"Carlos Maiolino" <cem@kernel.org>,
"Darrick J. Wong" <djwong@kernel.org>,
"Sebastian Reichel" <sre@kernel.org>,
"Keith Busch" <kbusch@kernel.org>,
"Christoph Hellwig" <hch@lst.de>,
"Sagi Grimberg" <sagi@grimberg.me>, "Frank Li" <Frank.Li@nxp.com>,
"Mark Brown" <broonie@kernel.org>,
"Shawn Guo" <shawnguo@kernel.org>,
"Sascha Hauer" <s.hauer@pengutronix.de>,
"Pengutronix Kernel Team" <kernel@pengutronix.de>,
"Fabio Estevam" <festevam@gmail.com>,
"Shyam Sundar S K" <Shyam-sundar.S-k@amd.com>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Henrique de Moraes Holschuh" <hmh@hmh.eng.br>,
"Selvin Xavier" <selvin.xavier@broadcom.com>,
"Kalesh AP" <kalesh-anakkur.purayil@broadcom.com>,
"Jason Gunthorpe" <jgg@ziepe.ca>,
"Leon Romanovsky" <leon@kernel.org>,
cocci@inria.fr, linux-kernel@vger.kernel.org,
linux-scsi@vger.kernel.org, dri-devel@lists.freedesktop.org,
linux-sound@vger.kernel.org, linux-btrfs@vger.kernel.org,
ceph-devel@vger.kernel.org, linux-block@vger.kernel.org,
linux-ide@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-pm@vger.kernel.org, linux-nvme@lists.infradead.org,
linux-spi@vger.kernel.org, imx@lists.linux.dev,
linux-arm-kernel@lists.infradead.org,
platform-driver-x86@vger.kernel.org,
ibm-acpi-devel@lists.sourceforge.net, linux-rdma@vger.kernel.org
Subject: Re: [cocci] [PATCH v3 08/16] ata: libata-zpodd: convert timeouts to secs_to_jiffies()
Date: Wed, 26 Feb 2025 11:00:37 +0900 [thread overview]
Message-ID: <2632bed9-4e4a-494a-bb89-d5aac64f854e@kernel.org> (raw)
In-Reply-To: <ff51bcfc-10c8-4461-9f82-ea1d5ed784f8@linux.microsoft.com>
On 2/26/25 5:24 AM, Easwar Hariharan wrote:
> On 2/25/2025 12:17 PM, Easwar Hariharan wrote:
>> Commit b35108a51cf7 ("jiffies: Define secs_to_jiffies()") introduced
>> secs_to_jiffies(). As the value here is a multiple of 1000, use
>> secs_to_jiffies() instead of msecs_to_jiffies() to avoid the multiplication
>>
>> This is converted using scripts/coccinelle/misc/secs_to_jiffies.cocci with
>> the following Coccinelle rules:
>>
>> @depends on patch@
>> expression E;
>> @@
>>
>> -msecs_to_jiffies
>> +secs_to_jiffies
>> (E
>> - * \( 1000 \| MSEC_PER_SEC \)
>> )
>>
>> Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com>
>> ---
>
> This was meant to carry Damien's ack once the subject line was fixed[1], but I fixed
> the subject line and missed adding the ack in. Damien, would you like to ack again?
Looks like Andrew already applied the patch, which is fine.
But nevertheless:
Acked-by: Damien Le Moal <dlemoal@kernel.org>
--
Damien Le Moal
Western Digital Research
next prev parent reply other threads:[~2025-02-26 2:00 UTC|newest]
Thread overview: 81+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 20:17 [PATCH v3 00/16] Converge on using secs_to_jiffies() part two Easwar Hariharan
2025-02-25 20:17 ` [cocci] " Easwar Hariharan
2025-02-25 20:17 ` [PATCH v3 01/16] coccinelle: misc: secs_to_jiffies: Patch expressions too Easwar Hariharan
2025-02-25 20:17 ` [cocci] " Easwar Hariharan
2025-02-26 8:26 ` Markus Elfring
2025-02-25 20:17 ` [PATCH v3 02/16] scsi: lpfc: convert timeouts to secs_to_jiffies() Easwar Hariharan
2025-02-25 20:17 ` [cocci] " Easwar Hariharan
2025-03-04 2:11 ` Martin K. Petersen
2025-03-04 2:11 ` [cocci] " Martin K. Petersen
2025-02-25 20:17 ` [PATCH v3 03/16] accel/habanalabs: " Easwar Hariharan
2025-02-25 20:17 ` [cocci] " Easwar Hariharan
2025-02-25 20:17 ` [PATCH v3 04/16] ALSA: ac97: " Easwar Hariharan
2025-02-25 20:17 ` [cocci] " Easwar Hariharan
2025-02-26 11:55 ` Markus Elfring
2025-02-25 20:17 ` [PATCH v3 05/16] btrfs: " Easwar Hariharan
2025-02-25 20:17 ` [cocci] " Easwar Hariharan
2025-02-25 20:17 ` [PATCH v3 06/16] rbd: " Easwar Hariharan
2025-02-25 20:17 ` [cocci] " Easwar Hariharan
2025-02-25 21:09 ` Christophe JAILLET
2025-02-25 21:09 ` [cocci] " Christophe JAILLET
2025-02-26 0:02 ` Easwar Hariharan
2025-02-26 0:02 ` [cocci] " Easwar Hariharan
2025-02-26 7:28 ` Daniel Vacek
2025-02-26 7:28 ` [cocci] " Daniel Vacek
2025-02-26 8:10 ` Christophe JAILLET
2025-02-26 8:10 ` [cocci] " Christophe JAILLET
2025-02-26 8:29 ` Daniel Vacek
2025-02-26 8:29 ` [cocci] " Daniel Vacek
2025-02-25 20:17 ` [PATCH v3 07/16] libceph: " Easwar Hariharan
2025-02-25 20:17 ` [cocci] " Easwar Hariharan
2025-02-25 21:25 ` Christophe JAILLET
2025-02-25 21:25 ` [cocci] " Christophe JAILLET
2025-02-25 20:17 ` [PATCH v3 08/16] ata: libata-zpodd: " Easwar Hariharan
2025-02-25 20:17 ` [cocci] " Easwar Hariharan
2025-02-25 20:24 ` Easwar Hariharan
2025-02-25 20:24 ` [cocci] " Easwar Hariharan
2025-02-26 2:00 ` Damien Le Moal [this message]
2025-02-26 2:00 ` Damien Le Moal
2025-02-25 20:17 ` [PATCH v3 09/16] xfs: " Easwar Hariharan
2025-02-25 20:17 ` [cocci] " Easwar Hariharan
2025-02-26 1:03 ` Christoph Hellwig
2025-02-25 20:17 ` [PATCH v3 10/16] power: supply: da9030: " Easwar Hariharan
2025-02-25 20:17 ` [cocci] " Easwar Hariharan
2025-02-25 20:17 ` [PATCH v3 11/16] nvme: " Easwar Hariharan
2025-02-25 20:17 ` [cocci] " Easwar Hariharan
2025-02-26 1:04 ` Christoph Hellwig
2025-02-25 20:17 ` [PATCH v3 12/16] spi: spi-fsl-lpspi: " Easwar Hariharan
2025-02-25 20:17 ` [cocci] " Easwar Hariharan
2025-02-25 20:17 ` [PATCH v3 13/16] spi: spi-imx: " Easwar Hariharan
2025-02-25 20:17 ` [cocci] " Easwar Hariharan
2025-02-25 20:27 ` Marc Kleine-Budde
2025-02-25 20:27 ` [cocci] " Marc Kleine-Budde
2025-02-25 20:17 ` [PATCH v3 14/16] platform/x86/amd/pmf: " Easwar Hariharan
2025-02-25 20:17 ` [cocci] " Easwar Hariharan
2025-03-21 16:08 ` Ilpo Järvinen
2025-03-21 16:08 ` [cocci] " Ilpo Järvinen
2025-02-25 20:17 ` [PATCH v3 15/16] platform/x86: thinkpad_acpi: " Easwar Hariharan
2025-02-25 20:17 ` [cocci] " Easwar Hariharan
2025-03-21 16:06 ` Ilpo Järvinen
2025-03-21 16:06 ` [cocci] " Ilpo Järvinen
2025-02-25 20:17 ` [PATCH v3 16/16] RDMA/bnxt_re: " Easwar Hariharan
2025-02-25 20:17 ` [cocci] " Easwar Hariharan
2025-02-25 20:30 ` (subset) [PATCH v3 00/16] Converge on using secs_to_jiffies() part two Jens Axboe
2025-02-25 20:30 ` [cocci] " Jens Axboe
2025-02-26 1:11 ` Christoph Hellwig
2025-02-26 11:29 ` Mark Brown
2025-02-26 11:29 ` [cocci] " Mark Brown
2025-02-26 20:38 ` Andrew Morton
2025-02-26 20:38 ` [cocci] " Andrew Morton
2025-02-26 22:26 ` Mark Brown
2025-02-26 22:26 ` [cocci] " Mark Brown
2025-02-27 9:02 ` Carlos Maiolino
2025-02-27 9:02 ` [cocci] " Carlos Maiolino
2025-02-26 16:48 ` (subset) " Mark Brown
2025-02-26 16:48 ` [cocci] " Mark Brown
2025-03-11 1:19 ` Martin K. Petersen
2025-03-11 1:19 ` [cocci] " Martin K. Petersen
2025-03-11 2:08 ` Andrew Morton
2025-03-11 2:08 ` [cocci] " Andrew Morton
2025-03-11 2:29 ` Martin K. Petersen
2025-03-11 2:29 ` [cocci] " Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2632bed9-4e4a-494a-bb89-d5aac64f854e@kernel.org \
--to=dlemoal@kernel.org \
--cc=Frank.Li@nxp.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=Julia.Lawall@inria.fr \
--cc=Shyam-sundar.S-k@amd.com \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=broonie@kernel.org \
--cc=cassel@kernel.org \
--cc=cem@kernel.org \
--cc=ceph-devel@vger.kernel.org \
--cc=clm@fb.com \
--cc=cocci@inria.fr \
--cc=dick.kennedy@broadcom.com \
--cc=djwong@kernel.org \
--cc=dongsheng.yang@easystack.cn \
--cc=dri-devel@lists.freedesktop.org \
--cc=dsterba@suse.com \
--cc=eahariha@linux.microsoft.com \
--cc=festevam@gmail.com \
--cc=hch@lst.de \
--cc=hdegoede@redhat.com \
--cc=hmh@hmh.eng.br \
--cc=ibm-acpi-devel@lists.sourceforge.net \
--cc=idryomov@gmail.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=imx@lists.linux.dev \
--cc=james.smart@broadcom.com \
--cc=jgg@ziepe.ca \
--cc=josef@toxicpanda.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
--cc=kbusch@kernel.org \
--cc=kernel@pengutronix.de \
--cc=leon@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=nicolas.palix@imag.fr \
--cc=ogabbay@kernel.org \
--cc=perex@perex.cz \
--cc=platform-driver-x86@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=sagi@grimberg.me \
--cc=selvin.xavier@broadcom.com \
--cc=shawnguo@kernel.org \
--cc=sre@kernel.org \
--cc=tiwai@suse.com \
--cc=xiubli@redhat.com \
--cc=yaron.avizrat@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.