All of lore.kernel.org
 help / color / mirror / Atom feed
From: valdis.kletnieks@vt.edu
To: Gao Xiang <hsiangkao@aol.com>
Cc: Gao Xiang <hsiangkao@gmx.com>,
	arshad hussain <arshad.super@gmail.com>,
	kernelnewbies <kernelnewbies@kernelnewbies.org>,
	linux-erofs@lists.ozlabs.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	miaoxie@huawei.com
Subject: Re: [PATCH 1/1] staging: erofs: Add function comment for erofs/super.c
Date: Wed, 13 Mar 2019 02:41:20 -0400	[thread overview]
Message-ID: <26452.1552459280@turing-police> (raw)
In-Reply-To: <2d0544aa-cc99-f1dd-3b83-9f06a307dfc7@aol.com>

On Wed, 13 Mar 2019 08:48:26 +0800, Gao Xiang said:
(Reversing order of  comments)
> "Release slab Memory" is not a very useful description for this function.

Agreed.

> i_callback is used to free inode structure and other memory related to this inode

However, that's not a bad description at all. :)

(Though I'd consider renaming the function to 'reap_inode_mem()' or something
like that so no description is needed. :)




_______________________________________________
Kernelnewbies mailing list
Kernelnewbies@kernelnewbies.org
https://lists.kernelnewbies.org/mailman/listinfo/kernelnewbies

WARNING: multiple messages have this Message-ID (diff)
From: valdis.kletnieks@vt.edu (valdis.kletnieks@vt.edu)
Subject: [PATCH 1/1] staging: erofs: Add function comment for erofs/super.c
Date: Wed, 13 Mar 2019 02:41:20 -0400	[thread overview]
Message-ID: <26452.1552459280@turing-police> (raw)
In-Reply-To: <2d0544aa-cc99-f1dd-3b83-9f06a307dfc7@aol.com>

On Wed, 13 Mar 2019 08:48:26 +0800, Gao Xiang said:
(Reversing order of  comments)
> "Release slab Memory" is not a very useful description for this function.

Agreed.

> i_callback is used to free inode structure and other memory related to this inode

However, that's not a bad description at all. :)

(Though I'd consider renaming the function to 'reap_inode_mem()' or something
like that so no description is needed. :)

  reply	other threads:[~2019-03-13  6:41 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-12 18:03 [PATCH 1/1] staging: erofs: Add function comment for erofs/super.c arshad hussain
2019-03-12 18:03 ` arshad hussain
2019-03-12 18:40 ` valdis.kletnieks
2019-03-12 18:40   ` valdis.kletnieks
2019-03-12 19:01 ` Greg KH
2019-03-12 19:01   ` Greg KH
2019-03-13  0:48 ` Gao Xiang
2019-03-13  0:48   ` Gao Xiang
2019-03-13  6:41   ` valdis.kletnieks [this message]
2019-03-13  6:41     ` valdis.kletnieks
2019-03-13  6:50     ` Gao Xiang
2019-03-13  6:50       ` Gao Xiang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=26452.1552459280@turing-police \
    --to=valdis.kletnieks@vt.edu \
    --cc=arshad.super@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=hsiangkao@aol.com \
    --cc=hsiangkao@gmx.com \
    --cc=kernelnewbies@kernelnewbies.org \
    --cc=linux-erofs@lists.ozlabs.org \
    --cc=miaoxie@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.