All of lore.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH v2] sh-pfc: Add entries for INTC external IRQs
Date: Tue, 09 Apr 2013 13:28:16 +0000	[thread overview]
Message-ID: <2649778.IYhvDiFtPl@avalon> (raw)
In-Reply-To: <1365504530-32232-1-git-send-email-hechtb+renesas@gmail.com>

Hi Bastian,

Thanks for the patch.

On Tuesday 09 April 2013 12:48:50 Bastian Hecht wrote:
> We add all necessary entries to support the external IRQs from the INTC.
> 
> Signed-off-by: Bastian Hecht <hechtb+renesas@gmail.com>

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> v2:
> - massive sorting
> - introduction of index instead of pointing by port number
> 
>  drivers/pinctrl/sh-pfc/pfc-r8a7740.c |  174 +++++++++++++++++++++++++++++++
>  1 file changed, 174 insertions(+)
> 
> diff --git a/drivers/pinctrl/sh-pfc/pfc-r8a7740.c
> b/drivers/pinctrl/sh-pfc/pfc-r8a7740.c index 21ff7f2..4753f54 100644
> --- a/drivers/pinctrl/sh-pfc/pfc-r8a7740.c
> +++ b/drivers/pinctrl/sh-pfc/pfc-r8a7740.c
> @@ -1658,6 +1674,59 @@ static struct sh_pfc_pin pinmux_pins[] = {

[snip]

> +IRQC_PINS_MUX(9, 1, 210);

[snip]

> +IRQC_PINS_MUX(16, 1, 211);

My version of the datasheet doesn't include pins 210 and 211 in the list of 
multiplexed pins, so I'll trust you on these two. I've checked all the other 
pins.

-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2013-04-09 13:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-09 10:48 [PATCH v2] sh-pfc: Add entries for INTC external IRQs Bastian Hecht
2013-04-09 13:28 ` Laurent Pinchart [this message]
2013-04-10  2:11 ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2649778.IYhvDiFtPl@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.