From: "Heiko Stübner" <heiko@sntech.de>
To: Krzysztof Kozlowski <krzk@kernel.org>, FUKAUMI Naoki <naoki@radxa.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: add dts for Radxa ROCK Pi E v3.0
Date: Sun, 23 Jun 2024 12:43:00 +0200 [thread overview]
Message-ID: <2659620.bgRvk7e4E5@diego> (raw)
In-Reply-To: <9941941CA3B1175A+26e42825-e100-44b7-a565-f1a86ca3fff8@radxa.com>
Hi,
Am Sonntag, 23. Juni 2024, 10:18:58 CEST schrieb FUKAUMI Naoki:
> On 6/23/24 17:07, Krzysztof Kozlowski wrote:
> > On 23/06/2024 09:53, FUKAUMI Naoki wrote:
> >> Radxa ROCK Pi E v3.0 has DDR4 SDRAM instead of DDR3 SDRAM.
> >>
> >> for Linux, this change doesn't make any difference from a device tree
> >> POV. but, for bootloader (U-Boot TPL), it makes a difference.
> >
> > What difference?
>
> U-Boot TPL initialize DDR SDRAM.
>
> https://github.com/RadxaNaoki/u-boot/commit/16d823eb95fe311c82a8ebb31570b59b1c59c43b#diff-03ce6c241f5db74ae87d4d8654bfef5eeb5bc42a9f1ff3cc828b70b3b2ac51d2R4
> https://github.com/RadxaNaoki/u-boot/commit/16d823eb95fe311c82a8ebb31570b59b1c59c43b#diff-31b80303774e7c10b527fb2dbc704b82e6c5ccdc6d53dd4f65861309ce0e7413R4
>
> there is 1 letter difference, ddr"3" and ddr"4".
>
> >> bootloader needs a separeted dts for v3, so I add new dts for it.
> >> dtb can be shared between v3 and prior, so I don't touch Makefile.
> >
> > I don't understand. If you have the same DTB then you do not need second
> > DTS.
>
> 2nd dts is for bootloader. it's not needed for Linux.
but _what_ is this different dt needed for. If it is unchanged from the
first one, why can't you reference that one in u-boot?
Similar to Krzysztof, I don't see _why_ you need a separate devicetree
at all.
Heiko
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip
WARNING: multiple messages have this Message-ID (diff)
From: "Heiko Stübner" <heiko@sntech.de>
To: Krzysztof Kozlowski <krzk@kernel.org>, FUKAUMI Naoki <naoki@radxa.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH] arm64: dts: rockchip: add dts for Radxa ROCK Pi E v3.0
Date: Sun, 23 Jun 2024 12:43:00 +0200 [thread overview]
Message-ID: <2659620.bgRvk7e4E5@diego> (raw)
In-Reply-To: <9941941CA3B1175A+26e42825-e100-44b7-a565-f1a86ca3fff8@radxa.com>
Hi,
Am Sonntag, 23. Juni 2024, 10:18:58 CEST schrieb FUKAUMI Naoki:
> On 6/23/24 17:07, Krzysztof Kozlowski wrote:
> > On 23/06/2024 09:53, FUKAUMI Naoki wrote:
> >> Radxa ROCK Pi E v3.0 has DDR4 SDRAM instead of DDR3 SDRAM.
> >>
> >> for Linux, this change doesn't make any difference from a device tree
> >> POV. but, for bootloader (U-Boot TPL), it makes a difference.
> >
> > What difference?
>
> U-Boot TPL initialize DDR SDRAM.
>
> https://github.com/RadxaNaoki/u-boot/commit/16d823eb95fe311c82a8ebb31570b59b1c59c43b#diff-03ce6c241f5db74ae87d4d8654bfef5eeb5bc42a9f1ff3cc828b70b3b2ac51d2R4
> https://github.com/RadxaNaoki/u-boot/commit/16d823eb95fe311c82a8ebb31570b59b1c59c43b#diff-31b80303774e7c10b527fb2dbc704b82e6c5ccdc6d53dd4f65861309ce0e7413R4
>
> there is 1 letter difference, ddr"3" and ddr"4".
>
> >> bootloader needs a separeted dts for v3, so I add new dts for it.
> >> dtb can be shared between v3 and prior, so I don't touch Makefile.
> >
> > I don't understand. If you have the same DTB then you do not need second
> > DTS.
>
> 2nd dts is for bootloader. it's not needed for Linux.
but _what_ is this different dt needed for. If it is unchanged from the
first one, why can't you reference that one in u-boot?
Similar to Krzysztof, I don't see _why_ you need a separate devicetree
at all.
Heiko
next prev parent reply other threads:[~2024-06-23 10:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-23 7:53 [PATCH] arm64: dts: rockchip: add dts for Radxa ROCK Pi E v3.0 FUKAUMI Naoki
2024-06-23 7:53 ` FUKAUMI Naoki
2024-06-23 8:07 ` Krzysztof Kozlowski
2024-06-23 8:07 ` Krzysztof Kozlowski
2024-06-23 8:18 ` FUKAUMI Naoki
2024-06-23 8:18 ` FUKAUMI Naoki
2024-06-23 10:43 ` Heiko Stübner [this message]
2024-06-23 10:43 ` Heiko Stübner
2024-06-23 11:59 ` Dragan Simic
2024-06-23 11:59 ` Dragan Simic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2659620.bgRvk7e4E5@diego \
--to=heiko@sntech.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=naoki@radxa.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.