From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch
Date: Fri, 29 Jan 2016 11:07:18 +0100 [thread overview]
Message-ID: <2664702.bXd9nOWVFO@wuerfel> (raw)
In-Reply-To: <87vb6c7mug.fsf@belgarion.home>
On Friday 29 January 2016 10:32:07 Robert Jarzmik wrote:
> > This addresses both issues by moving all the definitions into the
> > pxa25x_udc driver itself. It turns out the only difference between
> > them was 'UDCCS_IO_ROF', and that could well be a mistake when it
> > was incorrectly copied from pxa25x to ixp4xx.
> Hi Arnd,
>
> Is there a reason to have chosen to move into pxa25_udc.c instead of
> drivers/usb/gadget/udc/pxa25x_udc.h ? pxa27x_udc has a .h in the same directory
> with register definitions, hence the question.
Yes: The register definitions are only used in a single .c file and
are not an interface between files, so it's better to have them in
the file that uses them.
I could have continued the cleanup and moved the two headers into the
respective drivers as well, but I had to stop somewhere ;-)
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd@arndb.de>
To: Robert Jarzmik <robert.jarzmik@free.fr>
Cc: Felipe Balbi <balbi@kernel.org>, Imre Kaloz <kaloz@openwrt.org>,
Krzysztof Halasa <khalasa@piap.pl>,
Russell King <linux@arm.linux.org.uk>,
Daniel Mack <daniel@zonque.org>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Felipe Balbi <balbi@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-arm-kernel@lists.infradead.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch
Date: Fri, 29 Jan 2016 11:07:18 +0100 [thread overview]
Message-ID: <2664702.bXd9nOWVFO@wuerfel> (raw)
In-Reply-To: <87vb6c7mug.fsf@belgarion.home>
On Friday 29 January 2016 10:32:07 Robert Jarzmik wrote:
> > This addresses both issues by moving all the definitions into the
> > pxa25x_udc driver itself. It turns out the only difference between
> > them was 'UDCCS_IO_ROF', and that could well be a mistake when it
> > was incorrectly copied from pxa25x to ixp4xx.
> Hi Arnd,
>
> Is there a reason to have chosen to move into pxa25_udc.c instead of
> drivers/usb/gadget/udc/pxa25x_udc.h ? pxa27x_udc has a .h in the same directory
> with register definitions, hence the question.
Yes: The register definitions are only used in a single .c file and
are not an interface between files, so it's better to have them in
the file that uses them.
I could have continued the cleanup and moved the two headers into the
respective drivers as well, but I had to stop somewhere ;-)
Arnd
next prev parent reply other threads:[~2016-01-29 10:07 UTC|newest]
Thread overview: 72+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 16:15 [PATCH 0/7] USB changes for rare warnings Arnd Bergmann
2016-01-28 16:15 ` Arnd Bergmann
2016-01-28 16:17 ` [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch Arnd Bergmann
2016-01-28 16:17 ` Arnd Bergmann
2016-01-28 16:17 ` [PATCH 2/7] usb: gadget: pxa25x_udc cleanup Arnd Bergmann
2016-01-28 16:17 ` Arnd Bergmann
2016-01-29 10:13 ` Robert Jarzmik
2016-01-29 10:13 ` Robert Jarzmik
2016-01-28 16:17 ` [PATCH 3/7] usb: gadget: pxa25x_udc: use readl/writel for mmio Arnd Bergmann
2016-01-28 16:17 ` Arnd Bergmann
2016-01-29 10:17 ` Robert Jarzmik
2016-01-29 10:17 ` Robert Jarzmik
2016-01-29 16:18 ` Krzysztof Hałasa
2016-01-29 16:18 ` Krzysztof Hałasa
2016-01-29 17:06 ` Arnd Bergmann
2016-01-29 17:06 ` Arnd Bergmann
2016-02-15 7:33 ` Krzysztof Hałasa
2016-02-15 7:33 ` Krzysztof Hałasa
2016-02-15 9:33 ` Arnd Bergmann
2016-02-15 9:33 ` Arnd Bergmann
2016-02-15 13:51 ` Krzysztof Hałasa
2016-02-15 13:51 ` Krzysztof Hałasa
2016-02-15 16:12 ` Arnd Bergmann
2016-02-15 16:12 ` Arnd Bergmann
2016-02-16 9:26 ` Krzysztof Hałasa
2016-02-16 9:26 ` Krzysztof Hałasa
2016-02-16 11:26 ` Arnd Bergmann
2016-02-16 11:26 ` Arnd Bergmann
2016-02-16 13:24 ` Krzysztof Hałasa
2016-02-16 13:24 ` Krzysztof Hałasa
2016-02-16 13:55 ` Arnd Bergmann
2016-02-16 13:55 ` Arnd Bergmann
2016-02-17 8:36 ` Krzysztof Hałasa
2016-02-17 8:36 ` Krzysztof Hałasa
2016-02-17 10:36 ` Arnd Bergmann
2016-02-17 10:36 ` Arnd Bergmann
2016-02-17 16:14 ` Krzysztof Hałasa
2016-02-17 16:14 ` Krzysztof Hałasa
2016-02-20 20:54 ` Robert Jarzmik
2016-02-20 20:54 ` Robert Jarzmik
2016-01-29 18:03 ` Sergei Shtylyov
2016-01-29 18:03 ` Sergei Shtylyov
2016-01-29 21:02 ` Arnd Bergmann
2016-01-29 21:02 ` Arnd Bergmann
2016-01-29 9:32 ` [PATCH 1/7] usb: gadget: pxa25x_udc: move register definitions from arch Robert Jarzmik
2016-01-29 9:32 ` Robert Jarzmik
2016-01-29 10:07 ` Arnd Bergmann [this message]
2016-01-29 10:07 ` Arnd Bergmann
2016-01-29 15:26 ` Robert Jarzmik
2016-01-29 15:26 ` Robert Jarzmik
2016-01-29 15:55 ` Krzysztof Hałasa
2016-01-29 15:55 ` Krzysztof Hałasa
2016-02-17 15:08 ` Felipe Balbi
2016-02-17 15:08 ` Felipe Balbi
2016-02-17 16:00 ` Arnd Bergmann
2016-02-17 16:00 ` Arnd Bergmann
2016-01-28 16:20 ` [PATCH 4/7] usb: fsl: drop USB_FSL_MPH_DR_OF Kconfig symbol Arnd Bergmann
2016-01-28 16:20 ` Arnd Bergmann
2016-01-28 16:23 ` [PATCH 5/7] usb: isp1301-omap: mark power_up as __maybe_unused Arnd Bergmann
2016-01-28 16:23 ` Arnd Bergmann
2016-01-28 16:23 ` [PATCH 6/7] usb: musb: use %pad format string from dma_addr_t Arnd Bergmann
2016-01-28 16:23 ` Arnd Bergmann
2016-01-28 17:50 ` Tony Lindgren
2016-01-28 17:50 ` Tony Lindgren
2016-01-28 16:23 ` [PATCH 7/7] usb: musb/ux500: remove duplicate check for dma_is_compatible Arnd Bergmann
2016-01-28 16:23 ` Arnd Bergmann
2016-02-03 18:12 ` [PATCH 0/7] USB changes for rare warnings Felipe Balbi
2016-02-03 18:12 ` Felipe Balbi
2016-02-03 19:15 ` Robert Jarzmik
2016-02-03 19:15 ` Robert Jarzmik
2016-02-03 20:49 ` Arnd Bergmann
2016-02-03 20:49 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2664702.bXd9nOWVFO@wuerfel \
--to=arnd@arndb.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.