All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sven Eckelmann <sven@narfation.org>
To: ron minnich <rminnich@gmail.com>
Cc: Sasha Levin <sashal@kernel.org>,
	Boris Brezillon <boris.brezillon@free-electrons.com>,
	Marek Vasut <marek.vasut@gmail.com>,
	Richard Weinberger <richard@nod.at>,
	Ron Minnich <rminnich@google.com>,
	lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Adrian Schmutzler <freifunk@adrianschmutzler.de>,
	jstefek@datto.com,
	Boris Brezillon <boris.brezillon@collabora.com>,
	John Audia <graysky@archlinux.us>,
	Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
	linux-mtd@lists.infradead.org,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons
Date: Fri, 27 Nov 2020 18:05:55 +0100	[thread overview]
Message-ID: <2666350.AiC22s8V5E@sven-edge> (raw)
In-Reply-To: <CAP6exYKEN-sQXGxTC1CSzfyuYmbbMPHKEosCP7DciFTLOhAFCQ@mail.gmail.com>


[-- Attachment #1.1: Type: text/plain, Size: 983 bytes --]

On Friday, 27 November 2020 17:32:02 CET ron minnich wrote:
> I'm a bit worried about how tricky this starts to get. I'm inclined to
> go back to an earlier implementation which used a character that had
> not yet been used (iirc I used [] around the PCI ID in a very early
> version). What if we used, e.g, a single ! and searched for that? It
> need not be !; pick a character. Just something not already in use, as
> the ambiguity around which ':' delimits the device has become an
> issue, as you show.
> 
> Almost nothing in the original patch would change, save the character
> being searched for. By using a character we'd never used, we'd avoid
> breaking existing usage.

What? Doesn't make any sense to me. The mtdparts shown in the the commit 
message is as it is. I cannot simply change it because it is in the control of 
the bootloader - not the linux kernel or me. So I can also not introduce a 
different character like ! for separating things.

KInd regards,
	Sven


[-- Attachment #1.2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Sven Eckelmann <sven@narfation.org>
To: ron minnich <rminnich@gmail.com>
Cc: linux-mtd@lists.infradead.org, John Audia <graysky@archlinux.us>,
	Adrian Schmutzler <freifunk@adrianschmutzler.de>,
	jstefek@datto.com,
	Boris Brezillon <boris.brezillon@free-electrons.com>,
	Richard Weinberger <richard@nod.at>,
	Cyrille Pitchen <cyrille.pitchen@wedev4u.fr>,
	lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Marek Vasut <marek.vasut@gmail.com>,
	Boris Brezillon <boris.brezillon@collabora.com>,
	Ron Minnich <rminnich@google.com>,
	Brian Norris <computersforpeace@gmail.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons
Date: Fri, 27 Nov 2020 18:05:55 +0100	[thread overview]
Message-ID: <2666350.AiC22s8V5E@sven-edge> (raw)
In-Reply-To: <CAP6exYKEN-sQXGxTC1CSzfyuYmbbMPHKEosCP7DciFTLOhAFCQ@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 983 bytes --]

On Friday, 27 November 2020 17:32:02 CET ron minnich wrote:
> I'm a bit worried about how tricky this starts to get. I'm inclined to
> go back to an earlier implementation which used a character that had
> not yet been used (iirc I used [] around the PCI ID in a very early
> version). What if we used, e.g, a single ! and searched for that? It
> need not be !; pick a character. Just something not already in use, as
> the ambiguity around which ':' delimits the device has become an
> issue, as you show.
> 
> Almost nothing in the original patch would change, save the character
> being searched for. By using a character we'd never used, we'd avoid
> breaking existing usage.

What? Doesn't make any sense to me. The mtdparts shown in the the commit 
message is as it is. I cannot simply change it because it is in the control of 
the bootloader - not the linux kernel or me. So I can also not introduce a 
different character like ! for separating things.

KInd regards,
	Sven


[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  reply	other threads:[~2020-11-27 17:07 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29 16:53 [PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons Ronald G. Minnich
2020-04-29 16:53 ` Ronald G. Minnich
2020-11-22  0:14 ` Sven Eckelmann
2020-11-22  0:14   ` Sven Eckelmann
2020-11-27 16:32   ` ron minnich
2020-11-27 16:32     ` ron minnich
2020-11-27 17:05     ` Sven Eckelmann [this message]
2020-11-27 17:05       ` Sven Eckelmann
2020-11-27 17:16       ` ron minnich
2020-11-27 17:16         ` ron minnich
2020-11-27 17:35         ` Sven Eckelmann
2020-11-27 17:35           ` Sven Eckelmann
2020-11-27 18:54           ` ron minnich
2020-11-27 18:54             ` ron minnich
2020-12-07  7:52             ` Sven Eckelmann
2020-12-07  7:52               ` Sven Eckelmann
2020-12-07 15:24               ` ron minnich
2020-12-07 15:24                 ` ron minnich
2020-12-09 21:34                 ` Ron Minnich
2020-12-09 21:34                   ` Ron Minnich
  -- strict thread matches above, loose matches on Subject: below --
2020-09-25  4:21 [PATCH] mtd: spi-nor: controllers: intel-spi: Add support for command line partitions Vignesh Raghavendra
2020-12-23 21:56 ` [PATCH] mtd: parser: cmdline: Support MTD names containing one or more colons Ian Goegebuer
2020-12-23 21:56   ` Ian Goegebuer
2021-01-04  9:08   ` Miquel Raynal
2021-01-04  9:08     ` Miquel Raynal
2021-01-04 16:24     ` Ron Minnich
2021-01-04 16:24       ` Ron Minnich

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2666350.AiC22s8V5E@sven-edge \
    --to=sven@narfation.org \
    --cc=boris.brezillon@collabora.com \
    --cc=boris.brezillon@free-electrons.com \
    --cc=computersforpeace@gmail.com \
    --cc=cyrille.pitchen@wedev4u.fr \
    --cc=dwmw2@infradead.org \
    --cc=freifunk@adrianschmutzler.de \
    --cc=graysky@archlinux.us \
    --cc=jstefek@datto.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=marek.vasut@gmail.com \
    --cc=richard@nod.at \
    --cc=rminnich@gmail.com \
    --cc=rminnich@google.com \
    --cc=sashal@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.