* [PATCH] drm/sysfs: Remove drm_class_device_(un)register()
@ 2026-08-03 13:26 Maíra Canal
2026-08-19 12:11 ` Maíra Canal
2026-08-19 12:26 ` Jani Nikula
0 siblings, 2 replies; 3+ messages in thread
From: Maíra Canal @ 2026-08-03 13:26 UTC (permalink / raw)
To: Thomas Hellström, Christian König, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, kernel-dev, Maíra Canal
The last usage of the functions drm_class_device_register() and
drm_class_device_unregister() was removed in commit ed89fff97382
("drm/ttm: drop sysfs directory").
Remove such functions as they are no longer used.
Signed-off-by: Maíra Canal <mcanal@igalia.com>
---
drivers/gpu/drm/drm_sysfs.c | 32 --------------------------------
drivers/gpu/drm/ttm/ttm_module.c | 1 -
include/drm/drm_sysfs.h | 4 ----
3 files changed, 37 deletions(-)
diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c
index ef4e923a8728..7b16d32b6ff6 100644
--- a/drivers/gpu/drm/drm_sysfs.c
+++ b/drivers/gpu/drm/drm_sysfs.c
@@ -589,35 +589,3 @@ struct device *drm_sysfs_minor_alloc(struct drm_minor *minor)
put_device(kdev);
return ERR_PTR(r);
}
-
-/**
- * drm_class_device_register - register new device with the DRM sysfs class
- * @dev: device to register
- *
- * Registers a new &struct device within the DRM sysfs class. Essentially only
- * used by ttm to have a place for its global settings. Drivers should never use
- * this.
- */
-int drm_class_device_register(struct device *dev)
-{
- if (!drm_class || IS_ERR(drm_class))
- return -ENOENT;
-
- dev->class = drm_class;
- return device_register(dev);
-}
-EXPORT_SYMBOL_GPL(drm_class_device_register);
-
-/**
- * drm_class_device_unregister - unregister device with the DRM sysfs class
- * @dev: device to unregister
- *
- * Unregisters a &struct device from the DRM sysfs class. Essentially only used
- * by ttm to have a place for its global settings. Drivers should never use
- * this.
- */
-void drm_class_device_unregister(struct device *dev)
-{
- return device_unregister(dev);
-}
-EXPORT_SYMBOL_GPL(drm_class_device_unregister);
diff --git a/drivers/gpu/drm/ttm/ttm_module.c b/drivers/gpu/drm/ttm/ttm_module.c
index aa137ead5cc5..3daace105930 100644
--- a/drivers/gpu/drm/ttm/ttm_module.c
+++ b/drivers/gpu/drm/ttm/ttm_module.c
@@ -34,7 +34,6 @@
#include <linux/pgtable.h>
#include <linux/sched.h>
#include <linux/debugfs.h>
-#include <drm/drm_sysfs.h>
#include <drm/ttm/ttm_caching.h>
#include "ttm_module.h"
diff --git a/include/drm/drm_sysfs.h b/include/drm/drm_sysfs.h
index 96a5d858404b..7695873a9456 100644
--- a/include/drm/drm_sysfs.h
+++ b/include/drm/drm_sysfs.h
@@ -3,13 +3,9 @@
#define _DRM_SYSFS_H_
struct drm_device;
-struct device;
struct drm_connector;
struct drm_property;
-int drm_class_device_register(struct device *dev);
-void drm_class_device_unregister(struct device *dev);
-
void drm_sysfs_hotplug_event(struct drm_device *dev);
void drm_sysfs_connector_hotplug_event(struct drm_connector *connector);
void drm_sysfs_connector_property_event(struct drm_connector *connector,
--
2.55.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] drm/sysfs: Remove drm_class_device_(un)register()
2026-08-03 13:26 [PATCH] drm/sysfs: Remove drm_class_device_(un)register() Maíra Canal
@ 2026-08-19 12:11 ` Maíra Canal
2026-08-19 12:26 ` Jani Nikula
1 sibling, 0 replies; 3+ messages in thread
From: Maíra Canal @ 2026-08-19 12:11 UTC (permalink / raw)
To: Thomas Hellström, Christian König, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, kernel-dev
Hi,
Gentle ping for feedback.
Best regards,
- Maíra
On 03/08/26 10:26, Maíra Canal wrote:
> The last usage of the functions drm_class_device_register() and
> drm_class_device_unregister() was removed in commit ed89fff97382
> ("drm/ttm: drop sysfs directory").
>
> Remove such functions as they are no longer used.
>
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
> ---
> drivers/gpu/drm/drm_sysfs.c | 32 --------------------------------
> drivers/gpu/drm/ttm/ttm_module.c | 1 -
> include/drm/drm_sysfs.h | 4 ----
> 3 files changed, 37 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c
> index ef4e923a8728..7b16d32b6ff6 100644
> --- a/drivers/gpu/drm/drm_sysfs.c
> +++ b/drivers/gpu/drm/drm_sysfs.c
> @@ -589,35 +589,3 @@ struct device *drm_sysfs_minor_alloc(struct drm_minor *minor)
> put_device(kdev);
> return ERR_PTR(r);
> }
> -
> -/**
> - * drm_class_device_register - register new device with the DRM sysfs class
> - * @dev: device to register
> - *
> - * Registers a new &struct device within the DRM sysfs class. Essentially only
> - * used by ttm to have a place for its global settings. Drivers should never use
> - * this.
> - */
> -int drm_class_device_register(struct device *dev)
> -{
> - if (!drm_class || IS_ERR(drm_class))
> - return -ENOENT;
> -
> - dev->class = drm_class;
> - return device_register(dev);
> -}
> -EXPORT_SYMBOL_GPL(drm_class_device_register);
> -
> -/**
> - * drm_class_device_unregister - unregister device with the DRM sysfs class
> - * @dev: device to unregister
> - *
> - * Unregisters a &struct device from the DRM sysfs class. Essentially only used
> - * by ttm to have a place for its global settings. Drivers should never use
> - * this.
> - */
> -void drm_class_device_unregister(struct device *dev)
> -{
> - return device_unregister(dev);
> -}
> -EXPORT_SYMBOL_GPL(drm_class_device_unregister);
> diff --git a/drivers/gpu/drm/ttm/ttm_module.c b/drivers/gpu/drm/ttm/ttm_module.c
> index aa137ead5cc5..3daace105930 100644
> --- a/drivers/gpu/drm/ttm/ttm_module.c
> +++ b/drivers/gpu/drm/ttm/ttm_module.c
> @@ -34,7 +34,6 @@
> #include <linux/pgtable.h>
> #include <linux/sched.h>
> #include <linux/debugfs.h>
> -#include <drm/drm_sysfs.h>
> #include <drm/ttm/ttm_caching.h>
>
> #include "ttm_module.h"
> diff --git a/include/drm/drm_sysfs.h b/include/drm/drm_sysfs.h
> index 96a5d858404b..7695873a9456 100644
> --- a/include/drm/drm_sysfs.h
> +++ b/include/drm/drm_sysfs.h
> @@ -3,13 +3,9 @@
> #define _DRM_SYSFS_H_
>
> struct drm_device;
> -struct device;
> struct drm_connector;
> struct drm_property;
>
> -int drm_class_device_register(struct device *dev);
> -void drm_class_device_unregister(struct device *dev);
> -
> void drm_sysfs_hotplug_event(struct drm_device *dev);
> void drm_sysfs_connector_hotplug_event(struct drm_connector *connector);
> void drm_sysfs_connector_property_event(struct drm_connector *connector,
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/sysfs: Remove drm_class_device_(un)register()
2026-08-03 13:26 [PATCH] drm/sysfs: Remove drm_class_device_(un)register() Maíra Canal
2026-08-19 12:11 ` Maíra Canal
@ 2026-08-19 12:26 ` Jani Nikula
1 sibling, 0 replies; 3+ messages in thread
From: Jani Nikula @ 2026-08-19 12:26 UTC (permalink / raw)
To: Maíra Canal, Thomas Hellström, Christian König,
Maxime Ripard, Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, kernel-dev, Maíra Canal
On Mon, 03 Aug 2026, Maíra Canal <mcanal@igalia.com> wrote:
> The last usage of the functions drm_class_device_register() and
> drm_class_device_unregister() was removed in commit ed89fff97382
> ("drm/ttm: drop sysfs directory").
>
> Remove such functions as they are no longer used.
>
> Signed-off-by: Maíra Canal <mcanal@igalia.com>
Reviewed-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/drm_sysfs.c | 32 --------------------------------
> drivers/gpu/drm/ttm/ttm_module.c | 1 -
> include/drm/drm_sysfs.h | 4 ----
> 3 files changed, 37 deletions(-)
>
> diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c
> index ef4e923a8728..7b16d32b6ff6 100644
> --- a/drivers/gpu/drm/drm_sysfs.c
> +++ b/drivers/gpu/drm/drm_sysfs.c
> @@ -589,35 +589,3 @@ struct device *drm_sysfs_minor_alloc(struct drm_minor *minor)
> put_device(kdev);
> return ERR_PTR(r);
> }
> -
> -/**
> - * drm_class_device_register - register new device with the DRM sysfs class
> - * @dev: device to register
> - *
> - * Registers a new &struct device within the DRM sysfs class. Essentially only
> - * used by ttm to have a place for its global settings. Drivers should never use
> - * this.
> - */
> -int drm_class_device_register(struct device *dev)
> -{
> - if (!drm_class || IS_ERR(drm_class))
> - return -ENOENT;
> -
> - dev->class = drm_class;
> - return device_register(dev);
> -}
> -EXPORT_SYMBOL_GPL(drm_class_device_register);
> -
> -/**
> - * drm_class_device_unregister - unregister device with the DRM sysfs class
> - * @dev: device to unregister
> - *
> - * Unregisters a &struct device from the DRM sysfs class. Essentially only used
> - * by ttm to have a place for its global settings. Drivers should never use
> - * this.
> - */
> -void drm_class_device_unregister(struct device *dev)
> -{
> - return device_unregister(dev);
> -}
> -EXPORT_SYMBOL_GPL(drm_class_device_unregister);
> diff --git a/drivers/gpu/drm/ttm/ttm_module.c b/drivers/gpu/drm/ttm/ttm_module.c
> index aa137ead5cc5..3daace105930 100644
> --- a/drivers/gpu/drm/ttm/ttm_module.c
> +++ b/drivers/gpu/drm/ttm/ttm_module.c
> @@ -34,7 +34,6 @@
> #include <linux/pgtable.h>
> #include <linux/sched.h>
> #include <linux/debugfs.h>
> -#include <drm/drm_sysfs.h>
> #include <drm/ttm/ttm_caching.h>
>
> #include "ttm_module.h"
> diff --git a/include/drm/drm_sysfs.h b/include/drm/drm_sysfs.h
> index 96a5d858404b..7695873a9456 100644
> --- a/include/drm/drm_sysfs.h
> +++ b/include/drm/drm_sysfs.h
> @@ -3,13 +3,9 @@
> #define _DRM_SYSFS_H_
>
> struct drm_device;
> -struct device;
> struct drm_connector;
> struct drm_property;
>
> -int drm_class_device_register(struct device *dev);
> -void drm_class_device_unregister(struct device *dev);
> -
> void drm_sysfs_hotplug_event(struct drm_device *dev);
> void drm_sysfs_connector_hotplug_event(struct drm_connector *connector);
> void drm_sysfs_connector_property_event(struct drm_connector *connector,
--
Jani Nikula, Intel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-08-19 12:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-03 13:26 [PATCH] drm/sysfs: Remove drm_class_device_(un)register() Maíra Canal
2026-08-19 12:11 ` Maíra Canal
2026-08-19 12:26 ` Jani Nikula
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.