* Re: [PATCH 1/1] drm: panel-simple: add missing bus flags for Tianma tm070jvhg[30/33]
2023-01-25 14:52 [PATCH 1/1] drm: panel-simple: add missing bus flags for Tianma tm070jvhg[30/33] Alexander Stein
@ 2023-02-24 6:14 ` Alexander Stein
2023-05-09 11:03 ` Alexander Stein
2023-07-05 13:22 ` Alexander Stein
2 siblings, 0 replies; 5+ messages in thread
From: Alexander Stein @ 2023-02-24 6:14 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter
Cc: Markus Niebel, dri-devel
Hi,
a gentle ping
Best regards,
Alexander
Am Mittwoch, 25. Januar 2023, 15:52:15 CET schrieb Alexander Stein:
> From: Markus Niebel <Markus.Niebel@ew.tq-group.com>
>
> The DE signal is active high on this display, fill in the missing
> bus_flags. This aligns panel_desc with its display_timing.
>
> Fixes: 9a2654c0f62a ("drm/panel: Add and fill drm_panel type field")
> Fixes: b3bfcdf8a3b6 ("drm/panel: simple: add Tianma TM070JVHG33")
> Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c
> b/drivers/gpu/drm/panel/panel-simple.c index 065f378bba9d..fbccaf1cb6f2
> 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -3598,6 +3598,7 @@ static const struct panel_desc tianma_tm070jdhg30 = {
> },
> .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> .connector_type = DRM_MODE_CONNECTOR_LVDS,
> + .bus_flags = DRM_BUS_FLAG_DE_HIGH,
> };
>
> static const struct panel_desc tianma_tm070jvhg33 = {
> @@ -3610,6 +3611,7 @@ static const struct panel_desc tianma_tm070jvhg33 = {
> },
> .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> .connector_type = DRM_MODE_CONNECTOR_LVDS,
> + .bus_flags = DRM_BUS_FLAG_DE_HIGH,
> };
>
> static const struct display_timing tianma_tm070rvhg71_timing = {
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] drm: panel-simple: add missing bus flags for Tianma tm070jvhg[30/33]
2023-01-25 14:52 [PATCH 1/1] drm: panel-simple: add missing bus flags for Tianma tm070jvhg[30/33] Alexander Stein
2023-02-24 6:14 ` Alexander Stein
@ 2023-05-09 11:03 ` Alexander Stein
2023-07-05 13:22 ` Alexander Stein
2 siblings, 0 replies; 5+ messages in thread
From: Alexander Stein @ 2023-05-09 11:03 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter
Cc: Markus Niebel, dri-devel
Hello,
Another gentle ping.
Alexander
Am Mittwoch, 25. Januar 2023, 15:52:15 CEST schrieb Alexander Stein:
> From: Markus Niebel <Markus.Niebel@ew.tq-group.com>
>
> The DE signal is active high on this display, fill in the missing
> bus_flags. This aligns panel_desc with its display_timing.
>
> Fixes: 9a2654c0f62a ("drm/panel: Add and fill drm_panel type field")
> Fixes: b3bfcdf8a3b6 ("drm/panel: simple: add Tianma TM070JVHG33")
> Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c
> b/drivers/gpu/drm/panel/panel-simple.c index 065f378bba9d..fbccaf1cb6f2
> 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -3598,6 +3598,7 @@ static const struct panel_desc tianma_tm070jdhg30 = {
> },
> .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> .connector_type = DRM_MODE_CONNECTOR_LVDS,
> + .bus_flags = DRM_BUS_FLAG_DE_HIGH,
> };
>
> static const struct panel_desc tianma_tm070jvhg33 = {
> @@ -3610,6 +3611,7 @@ static const struct panel_desc tianma_tm070jvhg33 = {
> },
> .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> .connector_type = DRM_MODE_CONNECTOR_LVDS,
> + .bus_flags = DRM_BUS_FLAG_DE_HIGH,
> };
>
> static const struct display_timing tianma_tm070rvhg71_timing = {
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] drm: panel-simple: add missing bus flags for Tianma tm070jvhg[30/33]
2023-01-25 14:52 [PATCH 1/1] drm: panel-simple: add missing bus flags for Tianma tm070jvhg[30/33] Alexander Stein
2023-02-24 6:14 ` Alexander Stein
2023-05-09 11:03 ` Alexander Stein
@ 2023-07-05 13:22 ` Alexander Stein
2023-07-05 17:43 ` Sam Ravnborg
2 siblings, 1 reply; 5+ messages in thread
From: Alexander Stein @ 2023-07-05 13:22 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter
Cc: Markus Niebel, dri-devel
Hi,
another gentle ping
Best regards,
Alexander
Am Mittwoch, 25. Januar 2023, 15:52:15 CEST schrieb Alexander Stein:
> From: Markus Niebel <Markus.Niebel@ew.tq-group.com>
>
> The DE signal is active high on this display, fill in the missing
> bus_flags. This aligns panel_desc with its display_timing.
>
> Fixes: 9a2654c0f62a ("drm/panel: Add and fill drm_panel type field")
> Fixes: b3bfcdf8a3b6 ("drm/panel: simple: add Tianma TM070JVHG33")
> Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
> drivers/gpu/drm/panel/panel-simple.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/panel/panel-simple.c
> b/drivers/gpu/drm/panel/panel-simple.c index 065f378bba9d..fbccaf1cb6f2
> 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -3598,6 +3598,7 @@ static const struct panel_desc tianma_tm070jdhg30 = {
> },
> .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> .connector_type = DRM_MODE_CONNECTOR_LVDS,
> + .bus_flags = DRM_BUS_FLAG_DE_HIGH,
> };
>
> static const struct panel_desc tianma_tm070jvhg33 = {
> @@ -3610,6 +3611,7 @@ static const struct panel_desc tianma_tm070jvhg33 = {
> },
> .bus_format = MEDIA_BUS_FMT_RGB888_1X7X4_SPWG,
> .connector_type = DRM_MODE_CONNECTOR_LVDS,
> + .bus_flags = DRM_BUS_FLAG_DE_HIGH,
> };
>
> static const struct display_timing tianma_tm070rvhg71_timing = {
--
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] drm: panel-simple: add missing bus flags for Tianma tm070jvhg[30/33]
2023-07-05 13:22 ` Alexander Stein
@ 2023-07-05 17:43 ` Sam Ravnborg
0 siblings, 0 replies; 5+ messages in thread
From: Sam Ravnborg @ 2023-07-05 17:43 UTC (permalink / raw)
To: Alexander Stein; +Cc: dri-devel, Thierry Reding, Markus Niebel
Hi Alexander,
On Wed, Jul 05, 2023 at 03:22:39PM +0200, Alexander Stein wrote:
> Hi,
>
> another gentle ping
>
> Best regards,
> Alexander
>
> Am Mittwoch, 25. Januar 2023, 15:52:15 CEST schrieb Alexander Stein:
> > From: Markus Niebel <Markus.Niebel@ew.tq-group.com>
> >
> > The DE signal is active high on this display, fill in the missing
> > bus_flags. This aligns panel_desc with its display_timing.
> >
> > Fixes: 9a2654c0f62a ("drm/panel: Add and fill drm_panel type field")
> > Fixes: b3bfcdf8a3b6 ("drm/panel: simple: add Tianma TM070JVHG33")
> > Signed-off-by: Markus Niebel <Markus.Niebel@ew.tq-group.com>
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
Reviewed-by: Sam Ravnborg <sam@ravnborg.org>
I hope someone else will pick it up.
Sam
^ permalink raw reply [flat|nested] 5+ messages in thread