From: Arnd Bergmann <arnd@arndb.de>
To: linaro-acpi@lists.linaro.org
Cc: Suravee Suthikulanit <suravee.suthikulpanit@amd.com>,
Catalin Marinas <catalin.marinas@arm.com>,
herbert@gondor.apana.org.au, netdev@vger.kernel.org,
will.deacon@arm.com, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
davem@davemloft.net, linux-acpi@vger.kernel.org,
Murali Karicheri <m-karicheri2@ti.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
lenb@kernel.org, bhelgaas@google.com,
David Woodhouse <dwmw2@infradead.org>,
linux-arm-kernel@lists.infradead.org,
linux-crypto@vger.kernel.org
Subject: Re: [Linaro-acpi] [V4 PATCH 3/6] pci: Generic function for setting up PCI device DMA coherency
Date: Wed, 20 May 2015 14:02:40 +0200 [thread overview]
Message-ID: <2673003.mTFjFBS7Ob@wuerfel> (raw)
In-Reply-To: <555C7759.3040304@amd.com>
On Wednesday 20 May 2015 07:00:25 Suravee Suthikulanit wrote:
> It seems that there are several places that have similar check. Would it
> be good to convert this into a macro? Something like:
>
> #define OF_NODE_ENABLED(dev) (IS_ENABLED(CONFIG_OF) && dev->of_node)
>
> Thanks all for the review feedback.
>
Better make that an inline function that returns the node:
struct device_node *dev_of_node(struct device *)
{
if (IS_ENABLED(CONFIG_OF))
return dev->of_node;
return NULL;
}
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [Linaro-acpi] [V4 PATCH 3/6] pci: Generic function for setting up PCI device DMA coherency
Date: Wed, 20 May 2015 14:02:40 +0200 [thread overview]
Message-ID: <2673003.mTFjFBS7Ob@wuerfel> (raw)
In-Reply-To: <555C7759.3040304@amd.com>
On Wednesday 20 May 2015 07:00:25 Suravee Suthikulanit wrote:
> It seems that there are several places that have similar check. Would it
> be good to convert this into a macro? Something like:
>
> #define OF_NODE_ENABLED(dev) (IS_ENABLED(CONFIG_OF) && dev->of_node)
>
> Thanks all for the review feedback.
>
Better make that an inline function that returns the node:
struct device_node *dev_of_node(struct device *)
{
if (IS_ENABLED(CONFIG_OF))
return dev->of_node;
return NULL;
}
Arnd
next prev parent reply other threads:[~2015-05-20 12:03 UTC|newest]
Thread overview: 83+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-15 21:23 [V4 PATCH 0/6] ACPI: Introduce support for _CCA object Suravee Suthikulpanit
2015-05-15 21:23 ` Suravee Suthikulpanit
2015-05-15 21:23 ` Suravee Suthikulpanit
2015-05-15 21:23 ` [V4 PATCH 1/6] ACPI / scan: Parse _CCA and setup device coherency Suravee Suthikulpanit
2015-05-15 21:23 ` Suravee Suthikulpanit
2015-05-15 21:23 ` Suravee Suthikulpanit
2015-05-15 23:53 ` Rafael J. Wysocki
2015-05-15 23:53 ` Rafael J. Wysocki
2015-05-18 22:38 ` Suravee Suthikulanit
2015-05-18 22:38 ` Suravee Suthikulanit
2015-05-18 22:38 ` Suravee Suthikulanit
2015-05-19 0:28 ` Rafael J. Wysocki
2015-05-19 0:28 ` Rafael J. Wysocki
2015-05-20 10:01 ` Catalin Marinas
2015-05-20 10:01 ` Catalin Marinas
2015-05-20 11:52 ` Suravee Suthikulanit
2015-05-20 11:52 ` Suravee Suthikulanit
2015-05-20 11:52 ` Suravee Suthikulanit
2015-05-20 12:04 ` [Linaro-acpi] " Arnd Bergmann
2015-05-20 12:04 ` Arnd Bergmann
2015-05-21 13:01 ` Catalin Marinas
2015-05-21 13:01 ` Catalin Marinas
2015-05-21 13:24 ` Arnd Bergmann
2015-05-21 13:24 ` Arnd Bergmann
2015-05-15 21:23 ` [V4 PATCH 2/6] arm64 : Introduce support for ACPI _CCA object Suravee Suthikulpanit
2015-05-15 21:23 ` Suravee Suthikulpanit
2015-05-15 21:23 ` Suravee Suthikulpanit
2015-05-15 21:23 ` Suravee Suthikulpanit
2015-05-16 11:48 ` Paul Bolle
2015-05-16 11:48 ` Paul Bolle
2015-05-16 16:50 ` Suravee Suthikulpanit
2015-05-16 16:50 ` Suravee Suthikulpanit
2015-05-16 16:50 ` Suravee Suthikulpanit
2015-05-20 10:03 ` Catalin Marinas
2015-05-20 10:03 ` Catalin Marinas
2015-05-20 11:51 ` Suravee Suthikulanit
2015-05-20 11:51 ` Suravee Suthikulanit
2015-05-20 11:51 ` Suravee Suthikulanit
2015-05-15 21:23 ` [V4 PATCH 3/6] pci: Generic function for setting up PCI device DMA coherency Suravee Suthikulpanit
2015-05-15 21:23 ` Suravee Suthikulpanit
2015-05-15 21:23 ` Suravee Suthikulpanit
2015-05-15 23:59 ` Rafael J. Wysocki
2015-05-15 23:59 ` Rafael J. Wysocki
2015-05-16 15:12 ` Suthikulpanit, Suravee
2015-05-16 15:12 ` Suthikulpanit, Suravee
2015-05-16 15:12 ` Suthikulpanit, Suravee
2015-05-20 9:24 ` Catalin Marinas
2015-05-20 9:24 ` Catalin Marinas
2015-05-20 9:27 ` Arnd Bergmann
2015-05-20 9:27 ` Arnd Bergmann
2015-05-20 9:34 ` Catalin Marinas
2015-05-20 9:34 ` Catalin Marinas
2015-05-20 12:00 ` Suravee Suthikulanit
2015-05-20 12:00 ` Suravee Suthikulanit
2015-05-20 12:00 ` Suravee Suthikulanit
2015-05-20 12:02 ` Arnd Bergmann [this message]
2015-05-20 12:02 ` [Linaro-acpi] " Arnd Bergmann
2015-05-20 20:46 ` Russell King - ARM Linux
2015-05-20 20:46 ` Russell King - ARM Linux
2015-05-20 9:31 ` Catalin Marinas
2015-05-20 9:31 ` Catalin Marinas
2015-05-16 12:41 ` Bjorn Helgaas
2015-05-16 12:41 ` Bjorn Helgaas
2015-05-16 15:14 ` Suthikulpanit, Suravee
2015-05-16 15:14 ` Suthikulpanit, Suravee
2015-05-16 15:14 ` Suthikulpanit, Suravee
2015-05-16 15:14 ` Suthikulpanit, Suravee
2015-05-15 21:23 ` [V4 PATCH 4/6] device property: Introduces device_dma_is_coherent() Suravee Suthikulpanit
2015-05-15 21:23 ` Suravee Suthikulpanit
2015-05-15 21:23 ` Suravee Suthikulpanit
2015-05-20 10:28 ` Will Deacon
2015-05-20 10:28 ` Will Deacon
2015-05-20 10:28 ` Will Deacon
2015-05-20 21:32 ` Suravee Suthikulanit
2015-05-20 21:32 ` Suravee Suthikulanit
2015-05-20 21:32 ` Suravee Suthikulanit
2015-05-15 21:23 ` [V4 PATCH 5/6] crypto: ccp - Unify coherency checking logic with device_dma_is_coherent() Suravee Suthikulpanit
2015-05-15 21:23 ` Suravee Suthikulpanit
2015-05-15 21:23 ` Suravee Suthikulpanit
2015-05-15 21:23 ` Suravee Suthikulpanit
2015-05-15 21:23 ` [V4 PATCH 6/6] amd-xgbe: " Suravee Suthikulpanit
2015-05-15 21:23 ` Suravee Suthikulpanit
2015-05-15 21:23 ` Suravee Suthikulpanit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2673003.mTFjFBS7Ob@wuerfel \
--to=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=davem@davemloft.net \
--cc=dwmw2@infradead.org \
--cc=herbert@gondor.apana.org.au \
--cc=lenb@kernel.org \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m-karicheri2@ti.com \
--cc=netdev@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=suravee.suthikulpanit@amd.com \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.