Re: [PATCH v4 2/2] dt-bindings: arm: rockchip: Add EmbedFire LubanCat 1

["Heiko Stübner" <heiko@sntech.de>]

Am Mittwoch, 21. Dezember 2022, 11:46:36 CET schrieb ty:
> Dear Kozlowski,
> 
> Sorry that we didn't fully get the idea in your previous comments.
> 
> >
> > On 21/12/2022 06:52, Yuteng Zhong wrote:
> > > from: DHDAXCW <lasstp5011@gmail.com>
> > >
> > > LubanCat 1 is a Rockchip RK3566 SBC based
> > > is developed by EmbedFire Electronics Co., Ltd.
> > > Mini Linux Card Type Cheap Computer Development Board
> >
> > This is a friendly reminder during the review process.
> >
> > It seems my previous comments were not fully addressed. Maybe my
> > feedback got lost between the quotes, maybe you just forgot to apply it.
> > Please go back to the previous discussion and either implement all
> > requested changes or keep discussing them.
> >
> > Thank you.
> 
> Your pervious comment were:
> 
> > Please wrap commit message according to Linux coding style / submission
> > process:
> > https://elixir.bootlin.com/linux/v5.18-rc4/source/Documentation/process/submitting-patches.rst#L586
> 
> So I think there must be something wrong in the message but I didn't
> notice. This message has a `from` line, and the body was wrapped at 75
> columns. Please help me make it better.
> 
> 
> 
> > >
> > > Signed-off-by: Yuteng Zhong <zonyitoo@gmail.com>
> > > Signed-off-by: DHDAXCW <lasstp5011@gmail.com>
> > > ---
> > >  Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++
> > >  1 file changed, 5 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > > index 88ff4422a8c1..84d39a3a8843 100644
> > > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml
> > > @@ -781,6 +781,11 @@ properties:
> > >            - const: rockchip,rk3568-bpi-r2pro
> > >            - const: rockchip,rk3568
> > >
> > > +      - description: EmbedFire LubanCat 1
> > > +        items:
> > > +          - const: embedfire,lubancat-1
> > > +          - const: rockchip,rk3566
> >
> > Here as well.
> 
> This change was addressing the previous comment in V2:
> 
> > This is separate patch. Does not look like properly ordered. Don't add
> > stuff at the end of files/lists.

for context sorting order in that file is alphabetical by description


Heiko



_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip