[PATCH] no need to cast pointer to (void *) when passing it to kfree()

[PATCH] no need to cast pointer to (void *) when passing it to kfree()

[Jesper Juhl]

kfree() takes a void pointer argument, no need to cast.


Signed-off-by: Jesper Juhl <juhl-lkml@dif.dk>

--- linux-2.6.12-rc1-mm4-orig/mm/nommu.c	2005-03-31 21:20:08.000000000 +0200
+++ linux-2.6.12-rc1-mm4/mm/nommu.c	2005-04-04 23:25:23.000000000 +0200
@@ -761,7 +761,7 @@ static void put_vma(struct vm_area_struc
 			if (!(vma->vm_flags & (VM_IO | VM_SHARED)) && vma->vm_start) {
 				realalloc -= kobjsize((void *) vma->vm_start);
 				askedalloc -= vma->vm_end - vma->vm_start;
-				kfree((void *) vma->vm_start);
+				kfree(vma->vm_start);
 			}
 
 			realalloc -= kobjsize(vma);

Re: [PATCH] no need to cast pointer to (void *) when passing it to kfree()

[Jesper Juhl]

On Mon, 4 Apr 2005, Jesper Juhl wrote:

> 
> kfree() takes a void pointer argument, no need to cast.
> 
I'm an idiot, vm_start is an unsigned long, of course it needs to be 
cast.. D'OH!   Don't apply that patch... Don't know what I was thinking.


-- 
Jesper

Re: [PATCH] no need to cast pointer to (void *) when passing it to kfree()

[David Howells]

Jesper Juhl <juhl-lkml@dif.dk> wrote:

> kfree() takes a void pointer argument, no need to cast.

vma->vm_start is unsigned long (unless it's changed since last I looked):

	struct vm_area_struct {
		struct mm_struct * vm_mm;
		unsigned long vm_start;
		unsigned long vm_end;

Davod

Re: [PATCH] no need to cast pointer to (void *) when passing it to kfree()

[Jesper Juhl]

On Tue, 5 Apr 2005, David Howells wrote:

> Date: Tue, 05 Apr 2005 11:04:58 +0100
> From: David Howells <dhowells@redhat.com>
> To: Jesper Juhl <juhl-lkml@dif.dk>
> Cc: linux-kernel <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH] no need to cast pointer to (void *) when passing it to
>     kfree() 
> 
> Jesper Juhl <juhl-lkml@dif.dk> wrote:
> 
> > kfree() takes a void pointer argument, no need to cast.
> 
> vma->vm_start is unsigned long (unless it's changed since last I looked):
> 
As I wrote in the reply I send to my original mail I made a stupid 
mistake. Don't know what I was thinking. Sorry.

-- 
Jesper

Re: [PATCH] no need to cast pointer to (void *) when passing it to kfree()

[Jörn Engel]

On Tue, 5 April 2005 12:39:44 +0200, Jesper Juhl wrote:
> On Tue, 5 Apr 2005, David Howells wrote:
> > Jesper Juhl <juhl-lkml@dif.dk> wrote:
> > 
> > > kfree() takes a void pointer argument, no need to cast.
> > 
> > vma->vm_start is unsigned long (unless it's changed since last I looked):
> > 
> As I wrote in the reply I send to my original mail I made a stupid 
> mistake. Don't know what I was thinking. Sorry.

Your thinking wasn't that bad, just didn't match the language.  As
Linus already noted, C could use a truly transparent data type, for
things like kmalloc, kfree, or the various ->private_data fields in
structs.

Jörn

-- 
The cost of changing business rules is much more expensive for software
than for a secretaty.
-- unknown