From: "James (song wei)" <jsong@novell.com>
To: xen-devel@lists.xensource.com
Subject: Re: add the two command to add or delete the usb device instead of do it in QEMU console
Date: Sun, 13 Dec 2009 18:41:12 -0800 (PST) [thread overview]
Message-ID: <26772284.post@talk.nabble.com> (raw)
In-Reply-To: <20091213210931.GF16033@reaktio.net>
Yes, you are right. Sorry, I'll send the patch.
Pasi Kärkkäinen wrote:
>
> On Tue, Oct 20, 2009 at 01:26:19AM -0600, James Song wrote:
>> I rewrite the patch, pls check. I also put those as attachments.
>>
>> Thanks,
>> -James
>>
>> Signed-off-by: James Song Wei <[1]jsong@novell.com>
>>
>
>> diff -r 0705efd9c69e tools/python/xen/xend/server/SrvDomain.py
>> --- a/tools/python/xen/xend/server/SrvDomain.py Fri Oct 16 09:04:53
>> 2009
>> +0100
>> +++ b/tools/python/xen/xend/server/SrvDomain.py Mon Oct 19 10:15:06
>> 2009
>> +0800
>> @@ -225,6 +225,19 @@
>> self.acceptCommand(req)
>> return self.xd.domain_reset(self.dom.getName())
>>
>> + def op_usb_add(self, op, req):
>> + self.acceptCommand(req)
>> + return req.threadRequest(self.do_usb_add, op, req)
>> +
>> + def do_usb_add(self, _, req):
>> + return self.xd.domain_usb_add(self.dom.getName(), req)
>> +
>> + def op_usb_del(self, op, req):
>> + self.acceptCommand(req)
>> + return req.threadRequest(self.do_usb_add, op, req)
>> +
>> + def do_usb_del(self, _, req):
>> + return self.xd.domain_usb_add(self.dom.getName(), req)
>>
>
> Hello,
>
> Shouldn't op_usb_del() use do_usb_del() and do_usb_del() use
> domain_usb_del() ?
>
> Or did I miss something?
>
> -- Pasi
>
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xensource.com
> http://lists.xensource.com/xen-devel
>
>
--
View this message in context: http://old.nabble.com/add-the-two-command-to-add-or-delete-the-usb-device-instead-of-do-it-in-QEMU-console-tp25970825p26772284.html
Sent from the Xen - Dev mailing list archive at Nabble.com.
next prev parent reply other threads:[~2009-12-14 2:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-20 7:26 add the two command to add or delete the usb device instead of do it in QEMU console James Song
2009-10-27 15:23 ` Pasi Kärkkäinen
2009-12-13 21:09 ` Pasi Kärkkäinen
2009-12-14 2:41 ` James (song wei) [this message]
-- strict thread matches above, loose matches on Subject: below --
2009-10-15 8:12 James Song
2009-10-15 8:46 ` Keir Fraser
2009-10-19 2:48 ` James Song
2009-10-19 14:36 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26772284.post@talk.nabble.com \
--to=jsong@novell.com \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.