From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Omar Ramirez Luna <omar.luna@linaro.org>
Cc: Tony Lindgren <tony@atomide.com>,
Benoit Cousson <b-cousson@ti.com>,
Ohad Ben-Cohen <ohad@wizery.com>,
Joerg Roedel <joerg.roedel@amd.com>,
Russell King <linux@arm.linux.org.uk>,
Rajendra Nayak <rnayak@ti.com>,
Peter Ujfalusi <peter.ujfalusi@ti.com>,
devicetree-discuss@lists.ozlabs.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-omap@vger.kernel.org
Subject: Re: [PATCH v2 1/9] ARM: OMAP: iommu: fix including iommu.h without IOMMU_API selected
Date: Wed, 19 Sep 2012 11:35:36 +0200 [thread overview]
Message-ID: <2682570.BmY78BED3q@avalon> (raw)
In-Reply-To: <1347479152-588-2-git-send-email-omar.luna@linaro.org>
On Wednesday 12 September 2012 14:45:44 Omar Ramirez Luna wrote:
> If included without IOMMU_API being selected it will break
> compilation:
>
> arch/arm/plat-omap/include/plat/iommu.h:
> In function 'dev_to_omap_iommu':
> arch/arm/plat-omap/include/plat/iommu.h:148:
> error: 'struct dev_archdata' has no member named 'iommu'
>
> This will be seen when hwmod includes iommu.h to get the
> structure for attributes. Also needed for tidspbridge
> incremental migration to use iommu code.
>
> Cc: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Omar Ramirez Luna <omar.luna@linaro.org>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
I had the same patch in my tree already :-)
> ---
> arch/arm/plat-omap/include/plat/iommu.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/plat-omap/include/plat/iommu.h
> b/arch/arm/plat-omap/include/plat/iommu.h index 88be3e6..e58d571 100644
> --- a/arch/arm/plat-omap/include/plat/iommu.h
> +++ b/arch/arm/plat-omap/include/plat/iommu.h
> @@ -126,6 +126,7 @@ struct omap_iommu_arch_data {
> struct omap_iommu *iommu_dev;
> };
>
> +#ifdef CONFIG_IOMMU_API
> /**
> * dev_to_omap_iommu() - retrieves an omap iommu object from a user device
> * @dev: iommu client device
> @@ -136,6 +137,7 @@ static inline struct omap_iommu
> *dev_to_omap_iommu(struct device *dev)
>
> return arch_data->iommu_dev;
> }
> +#endif
>
> /* IOMMU errors */
> #define OMAP_IOMMU_ERR_TLB_MISS (1 << 0)
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/9] ARM: OMAP: iommu: fix including iommu.h without IOMMU_API selected
Date: Wed, 19 Sep 2012 11:35:36 +0200 [thread overview]
Message-ID: <2682570.BmY78BED3q@avalon> (raw)
In-Reply-To: <1347479152-588-2-git-send-email-omar.luna@linaro.org>
On Wednesday 12 September 2012 14:45:44 Omar Ramirez Luna wrote:
> If included without IOMMU_API being selected it will break
> compilation:
>
> arch/arm/plat-omap/include/plat/iommu.h:
> In function 'dev_to_omap_iommu':
> arch/arm/plat-omap/include/plat/iommu.h:148:
> error: 'struct dev_archdata' has no member named 'iommu'
>
> This will be seen when hwmod includes iommu.h to get the
> structure for attributes. Also needed for tidspbridge
> incremental migration to use iommu code.
>
> Cc: Tony Lindgren <tony@atomide.com>
> Signed-off-by: Omar Ramirez Luna <omar.luna@linaro.org>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
I had the same patch in my tree already :-)
> ---
> arch/arm/plat-omap/include/plat/iommu.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm/plat-omap/include/plat/iommu.h
> b/arch/arm/plat-omap/include/plat/iommu.h index 88be3e6..e58d571 100644
> --- a/arch/arm/plat-omap/include/plat/iommu.h
> +++ b/arch/arm/plat-omap/include/plat/iommu.h
> @@ -126,6 +126,7 @@ struct omap_iommu_arch_data {
> struct omap_iommu *iommu_dev;
> };
>
> +#ifdef CONFIG_IOMMU_API
> /**
> * dev_to_omap_iommu() - retrieves an omap iommu object from a user device
> * @dev: iommu client device
> @@ -136,6 +137,7 @@ static inline struct omap_iommu
> *dev_to_omap_iommu(struct device *dev)
>
> return arch_data->iommu_dev;
> }
> +#endif
>
> /* IOMMU errors */
> #define OMAP_IOMMU_ERR_TLB_MISS (1 << 0)
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2012-09-19 9:35 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-12 19:45 [PATCH v2 0/9] OMAP: iommu: hwmod, reset handling and runtime PM Omar Ramirez Luna
2012-09-12 19:45 ` Omar Ramirez Luna
2012-09-12 19:45 ` [PATCH v2 1/9] ARM: OMAP: iommu: fix including iommu.h without IOMMU_API selected Omar Ramirez Luna
2012-09-12 19:45 ` Omar Ramirez Luna
2012-09-19 9:35 ` Laurent Pinchart [this message]
2012-09-19 9:35 ` Laurent Pinchart
2012-09-19 21:01 ` Paul Walmsley
2012-09-19 21:01 ` Paul Walmsley
2012-09-12 19:45 ` [PATCH v2 4/9] ARM: OMAP3/4: iommu: migrate to hwmod framework Omar Ramirez Luna
2012-09-12 19:45 ` Omar Ramirez Luna
[not found] ` <1347479152-588-1-git-send-email-omar.luna-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-09-12 19:45 ` [PATCH v2 2/9] ARM: OMAP3: hwmod data: add mmu data for iva and isp Omar Ramirez Luna
2012-09-12 19:45 ` Omar Ramirez Luna
2012-09-12 19:45 ` Omar Ramirez Luna
[not found] ` <1347479152-588-3-git-send-email-omar.luna-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-09-19 21:35 ` Paul Walmsley
2012-09-19 21:35 ` Paul Walmsley
2012-09-19 21:35 ` Paul Walmsley
2012-09-21 0:30 ` Paul Walmsley
2012-09-21 0:30 ` Paul Walmsley
2012-09-21 0:30 ` Paul Walmsley
2012-09-12 19:45 ` [PATCH v2 3/9] ARM: OMAP4: hwmod data: add mmu hwmod for ipu and dsp Omar Ramirez Luna
2012-09-12 19:45 ` Omar Ramirez Luna
2012-09-12 19:45 ` Omar Ramirez Luna
[not found] ` <1347479152-588-4-git-send-email-omar.luna-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-09-19 20:59 ` Paul Walmsley
2012-09-19 20:59 ` Paul Walmsley
2012-09-19 20:59 ` Paul Walmsley
2012-09-19 21:20 ` Cousson, Benoit
2012-09-19 21:20 ` Cousson, Benoit
2012-09-19 21:20 ` Cousson, Benoit
2012-09-19 21:31 ` Paul Walmsley
2012-09-19 21:31 ` Paul Walmsley
2012-09-12 19:45 ` [PATCH v2 5/9] ARM: OMAP3/4: iommu: adapt to runtime pm Omar Ramirez Luna
2012-09-12 19:45 ` Omar Ramirez Luna
2012-09-12 19:45 ` Omar Ramirez Luna
2012-09-12 19:45 ` [PATCH v2 6/9] ARM: OMAP: iommu: pm runtime save and restore context Omar Ramirez Luna
2012-09-12 19:45 ` Omar Ramirez Luna
2012-09-12 19:45 ` Omar Ramirez Luna
2012-09-12 19:45 ` [PATCH v2 7/9] ARM: OMAP: iommu: optimize save and restore routines Omar Ramirez Luna
2012-09-12 19:45 ` Omar Ramirez Luna
[not found] ` <1347479152-588-8-git-send-email-omar.luna-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
2012-09-18 18:04 ` Tony Lindgren
2012-09-18 18:04 ` Tony Lindgren
2012-09-18 18:04 ` Tony Lindgren
2012-09-19 0:53 ` Omar Ramirez Luna
2012-09-19 0:53 ` Omar Ramirez Luna
2012-09-12 19:45 ` [PATCH v2 8/9] ARM: OMAP: iommu: add device tree support Omar Ramirez Luna
2012-09-12 19:45 ` Omar Ramirez Luna
2012-10-02 21:25 ` Matt Porter
2012-10-02 21:25 ` Matt Porter
2012-10-03 21:13 ` Omar Ramirez Luna
2012-10-03 21:13 ` Omar Ramirez Luna
2012-09-12 19:45 ` [PATCH v2 9/9] arm/dts: OMAP3/4: Add iommu nodes Omar Ramirez Luna
2012-09-12 19:45 ` Omar Ramirez Luna
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2682570.BmY78BED3q@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=b-cousson@ti.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=joerg.roedel@amd.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=ohad@wizery.com \
--cc=omar.luna@linaro.org \
--cc=peter.ujfalusi@ti.com \
--cc=rnayak@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.