All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Weinberger <richard@nod.at>
To: Mukesh Ojha <mojha@codeaurora.org>
Cc: linux-kernel@vger.kernel.org, Yue Haibing <yuehaibing@huawei.com>,
	adrian.hunter@intel.com, linux-mtd@lists.infradead.org,
	dedekind1@gmail.com
Subject: Re: [PATCH -next] ubifs: remove unused function __ubifs_shash_final
Date: Wed, 20 Mar 2019 21:18:58 +0100	[thread overview]
Message-ID: <2691086.gDEv9kBeKS@blindfold> (raw)
In-Reply-To: <97289b81-ed73-002a-504d-2e82fad153e7@codeaurora.org>

Am Mittwoch, 20. März 2019, 21:05:37 CET schrieb Mukesh Ojha:
> 
> On 3/20/2019 7:39 PM, Yue Haibing wrote:
> > From: YueHaibing <yuehaibing@huawei.com>
> >
> > There is no callers in tree, and can be removed.
> >
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > ---
> >   fs/ubifs/auth.c | 18 ------------------
> >   1 file changed, 18 deletions(-)
> >
> > diff --git a/fs/ubifs/auth.c b/fs/ubifs/auth.c
> > index 5bf5fd0..2a40ccce 100644
> > --- a/fs/ubifs/auth.c
> > +++ b/fs/ubifs/auth.c
> > @@ -147,24 +147,6 @@ struct shash_desc *__ubifs_hash_get_desc(const struct ubifs_info *c)
> >   }
> >   
> >   /**
> > - * __ubifs_shash_final - finalize shash
> > - * @c: UBIFS file-system description object
> > - * @desc: the descriptor
> > - * @out: the output hash
> > - *
> > - * Simple wrapper around crypto_shash_final(), safe to be called with
> > - * disabled authentication.
> > - */
> > -int __ubifs_shash_final(const struct ubifs_info *c, struct shash_desc *desc,
> > -			u8 *out)
> > -{
> > -	if (ubifs_authenticated(c))
> > -		return crypto_shash_final(desc, out);
> > -
> > -	return 0;
> > -}
> > -
> > -/**
> >    * ubifs_bad_hash - Report hash mismatches
> >    * @c: UBIFS file-system description object
> >    * @node: the node
> 
> 
> 
> Looks fine to be removed.
> 
> Acked-by: Mukesh Ojha <mojha@codeaurora.org>

I guess you mean Reviewed-by?

Thanks,
//richard




______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: Richard Weinberger <richard@nod.at>
To: Mukesh Ojha <mojha@codeaurora.org>
Cc: Yue Haibing <yuehaibing@huawei.com>,
	dedekind1@gmail.com, adrian.hunter@intel.com,
	linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org
Subject: Re: [PATCH -next] ubifs: remove unused function __ubifs_shash_final
Date: Wed, 20 Mar 2019 21:18:58 +0100	[thread overview]
Message-ID: <2691086.gDEv9kBeKS@blindfold> (raw)
In-Reply-To: <97289b81-ed73-002a-504d-2e82fad153e7@codeaurora.org>

Am Mittwoch, 20. März 2019, 21:05:37 CET schrieb Mukesh Ojha:
> 
> On 3/20/2019 7:39 PM, Yue Haibing wrote:
> > From: YueHaibing <yuehaibing@huawei.com>
> >
> > There is no callers in tree, and can be removed.
> >
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > ---
> >   fs/ubifs/auth.c | 18 ------------------
> >   1 file changed, 18 deletions(-)
> >
> > diff --git a/fs/ubifs/auth.c b/fs/ubifs/auth.c
> > index 5bf5fd0..2a40ccce 100644
> > --- a/fs/ubifs/auth.c
> > +++ b/fs/ubifs/auth.c
> > @@ -147,24 +147,6 @@ struct shash_desc *__ubifs_hash_get_desc(const struct ubifs_info *c)
> >   }
> >   
> >   /**
> > - * __ubifs_shash_final - finalize shash
> > - * @c: UBIFS file-system description object
> > - * @desc: the descriptor
> > - * @out: the output hash
> > - *
> > - * Simple wrapper around crypto_shash_final(), safe to be called with
> > - * disabled authentication.
> > - */
> > -int __ubifs_shash_final(const struct ubifs_info *c, struct shash_desc *desc,
> > -			u8 *out)
> > -{
> > -	if (ubifs_authenticated(c))
> > -		return crypto_shash_final(desc, out);
> > -
> > -	return 0;
> > -}
> > -
> > -/**
> >    * ubifs_bad_hash - Report hash mismatches
> >    * @c: UBIFS file-system description object
> >    * @node: the node
> 
> 
> 
> Looks fine to be removed.
> 
> Acked-by: Mukesh Ojha <mojha@codeaurora.org>

I guess you mean Reviewed-by?

Thanks,
//richard




  reply	other threads:[~2019-03-20 20:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-20 14:09 [PATCH -next] ubifs: remove unused function __ubifs_shash_final Yue Haibing
2019-03-20 14:09 ` Yue Haibing
2019-03-20 20:05 ` Mukesh Ojha
2019-03-20 20:05   ` Mukesh Ojha
2019-03-20 20:18   ` Richard Weinberger [this message]
2019-03-20 20:18     ` Richard Weinberger
2019-03-21  7:54     ` Mukesh Ojha
2019-03-21  7:54       ` Mukesh Ojha
2019-03-21  8:09       ` Richard Weinberger
2019-03-21  8:09         ` Richard Weinberger
2019-03-22  6:59         ` Mukesh Ojha
2019-03-22  6:59           ` Mukesh Ojha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2691086.gDEv9kBeKS@blindfold \
    --to=richard@nod.at \
    --cc=adrian.hunter@intel.com \
    --cc=dedekind1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=mojha@codeaurora.org \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.