From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tony Prisk <linux@prisktech.co.nz>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
linux-sh@vger.kernel.org, Simon Horman <horms@verge.net.au>,
Phil Edworthy <phil.edworthy@renesas.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
devicetree-discuss@lists.ozlabs.org,
Magnus Damm <magnus.damm@gmail.com>,
Paul Mundt <lethal@linux-sh.org>,
Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Subject: Re: [PATCH 1/9] sh-pfc: Add OF support
Date: Mon, 07 Jan 2013 18:56:19 +0000 [thread overview]
Message-ID: <2696178.tZLZqFqVI9@avalon> (raw)
In-Reply-To: <1357261926.25326.2.camel@gitbox>
Hi Tony,
On Friday 04 January 2013 14:12:06 Tony Prisk wrote:
> On Fri, 2013-01-04 at 01:40 +0100, Laurent Pinchart wrote:
> > +- #gpio-cells: Should be 2. The first cell is the pin number and the
> > second cell
> > + is used to specify optional parameters (currently unused).
>
> ...
>
> > + gpio: pfc@e6050000 {
> > + compatible = "renesas,pfc-sh73a0";
> > + reg = <0xe6050000 0x8000>,
> > + <0xe605801c 0x1c>;
> > + gpio-controller;
> > + #gpio-cells = <2>;
> > + };
> > +
> > +Example 2: A GPIO LED node that references a GPIO
> > +
> > + leds {
> > + compatible = "gpio-leds";
> > + led1 {
> > + gpios = <&gpio 20 1>; /* Active low */
> > + };
> > + };
> > +
>
> The second cell of gpio is '(currently unused)' but the example shows it
> being used?
My bad. The second cell can be used to specify that the GPIO is active low.
I'll fix the documentation accordingly.
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tony Prisk <linux@prisktech.co.nz>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
linux-sh@vger.kernel.org, Simon Horman <horms@verge.net.au>,
Phil Edworthy <phil.edworthy@renesas.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
devicetree-discuss@lists.ozlabs.org,
Magnus Damm <magnus.damm@gmail.com>,
Paul Mundt <lethal@linux-sh.org>,
Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>,
Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Subject: Re: [PATCH 1/9] sh-pfc: Add OF support
Date: Mon, 07 Jan 2013 19:56:19 +0100 [thread overview]
Message-ID: <2696178.tZLZqFqVI9@avalon> (raw)
In-Reply-To: <1357261926.25326.2.camel@gitbox>
Hi Tony,
On Friday 04 January 2013 14:12:06 Tony Prisk wrote:
> On Fri, 2013-01-04 at 01:40 +0100, Laurent Pinchart wrote:
> > +- #gpio-cells: Should be 2. The first cell is the pin number and the
> > second cell
> > + is used to specify optional parameters (currently unused).
>
> ...
>
> > + gpio: pfc@e6050000 {
> > + compatible = "renesas,pfc-sh73a0";
> > + reg = <0xe6050000 0x8000>,
> > + <0xe605801c 0x1c>;
> > + gpio-controller;
> > + #gpio-cells = <2>;
> > + };
> > +
> > +Example 2: A GPIO LED node that references a GPIO
> > +
> > + leds {
> > + compatible = "gpio-leds";
> > + led1 {
> > + gpios = <&gpio 20 1>; /* Active low */
> > + };
> > + };
> > +
>
> The second cell of gpio is '(currently unused)' but the example shows it
> being used?
My bad. The second cell can be used to specify that the GPIO is active low.
I'll fix the documentation accordingly.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-01-07 18:56 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-04 0:40 [PATCH 0/9] SH pinctrl DT support Laurent Pinchart
2013-01-04 0:40 ` [PATCH 1/9] sh-pfc: Add OF support Laurent Pinchart
2013-01-04 0:40 ` Laurent Pinchart
2013-01-04 1:12 ` Tony Prisk
2013-01-04 1:12 ` Tony Prisk
2013-01-07 18:56 ` Laurent Pinchart [this message]
2013-01-07 18:56 ` Laurent Pinchart
-- strict thread matches above, loose matches on Subject: below --
2013-02-13 3:29 [PATCH v2.1 0/9] SH pinctrl DT support Simon Horman
2013-02-13 3:29 ` [PATCH 1/9] sh-pfc: Add OF support Simon Horman
2013-02-13 3:29 ` Simon Horman
2013-02-13 3:29 ` Simon Horman
2013-02-15 19:37 ` Linus Walleij
2013-02-15 19:37 ` Linus Walleij
2013-02-15 19:37 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2696178.tZLZqFqVI9@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=g.liakhovetski@gmx.de \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=lethal@linux-sh.org \
--cc=linux-sh@vger.kernel.org \
--cc=linux@prisktech.co.nz \
--cc=magnus.damm@gmail.com \
--cc=nobuhiro.iwamatsu.yj@renesas.com \
--cc=phil.edworthy@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.