All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
	Samuel Holland <samuel@sholland.org>,
	linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 14/17] pmdomain: sunxi: Move Kconfig option to the pmdomain subsystem
Date: Thu, 14 Sep 2023 17:07:39 +0200	[thread overview]
Message-ID: <2696832.mvXUDI8C0e@jernej-laptop> (raw)
In-Reply-To: <20230914111912.586764-1-ulf.hansson@linaro.org>

Dne četrtek, 14. september 2023 ob 13:19:12 CEST je Ulf Hansson napisal(a):
> The Kconfig option belongs closer to the corresponding implementation,
> hence let's move it from the soc subsystem to the pmdomain subsystem.
> 
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> Cc: Samuel Holland <samuel@sholland.org>
> Cc: <linux-sunxi@lists.linux.dev>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej

> ---
>  drivers/pmdomain/Kconfig       |  1 +
>  drivers/pmdomain/sunxi/Kconfig | 10 ++++++++++
>  drivers/soc/sunxi/Kconfig      |  9 ---------
>  3 files changed, 11 insertions(+), 9 deletions(-)
>  create mode 100644 drivers/pmdomain/sunxi/Kconfig
> 
> diff --git a/drivers/pmdomain/Kconfig b/drivers/pmdomain/Kconfig
> index 67049ebf7265..39f358f27f2e 100644
> --- a/drivers/pmdomain/Kconfig
> +++ b/drivers/pmdomain/Kconfig
> @@ -13,5 +13,6 @@ source "drivers/pmdomain/rockchip/Kconfig"
>  source "drivers/pmdomain/samsung/Kconfig"
>  source "drivers/pmdomain/st/Kconfig"
>  source "drivers/pmdomain/starfive/Kconfig"
> +source "drivers/pmdomain/sunxi/Kconfig"
> 
>  endmenu
> diff --git a/drivers/pmdomain/sunxi/Kconfig b/drivers/pmdomain/sunxi/Kconfig
> new file mode 100644
> index 000000000000..17781bf8d86d
> --- /dev/null
> +++ b/drivers/pmdomain/sunxi/Kconfig
> @@ -0,0 +1,10 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +
> +config SUN20I_PPU
> +	bool "Allwinner D1 PPU power domain driver"
> +	depends on ARCH_SUNXI || COMPILE_TEST
> +	depends on PM
> +	select PM_GENERIC_DOMAINS
> +	help
> +	  Say y to enable the PPU power domain driver. This saves power
> +	  when certain peripherals, such as the video engine, are idle.
> diff --git a/drivers/soc/sunxi/Kconfig b/drivers/soc/sunxi/Kconfig
> index c5070914fc6a..8aecbc9b1976 100644
> --- a/drivers/soc/sunxi/Kconfig
> +++ b/drivers/soc/sunxi/Kconfig
> @@ -19,12 +19,3 @@ config SUNXI_SRAM
>  	  Say y here to enable the SRAM controller support. This
>  	  device is responsible on mapping the SRAM in the sunXi SoCs
>  	  whether to the CPU/DMA, or to the devices.
> -
> -config SUN20I_PPU
> -	bool "Allwinner D1 PPU power domain driver"
> -	depends on ARCH_SUNXI || COMPILE_TEST
> -	depends on PM
> -	select PM_GENERIC_DOMAINS
> -	help
> -	  Say y to enable the PPU power domain driver. This saves power
> -	  when certain peripherals, such as the video engine, are idle.





WARNING: multiple messages have this Message-ID (diff)
From: "Jernej Škrabec" <jernej.skrabec@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>, Olof Johansson <olof@lixom.net>,
	Ulf Hansson <ulf.hansson@linaro.org>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
	linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
	Samuel Holland <samuel@sholland.org>,
	linux-sunxi@lists.linux.dev
Subject: Re: [PATCH 14/17] pmdomain: sunxi: Move Kconfig option to the pmdomain subsystem
Date: Thu, 14 Sep 2023 17:07:39 +0200	[thread overview]
Message-ID: <2696832.mvXUDI8C0e@jernej-laptop> (raw)
In-Reply-To: <20230914111912.586764-1-ulf.hansson@linaro.org>

Dne četrtek, 14. september 2023 ob 13:19:12 CEST je Ulf Hansson napisal(a):
> The Kconfig option belongs closer to the corresponding implementation,
> hence let's move it from the soc subsystem to the pmdomain subsystem.
> 
> Cc: Chen-Yu Tsai <wens@csie.org>
> Cc: Jernej Skrabec <jernej.skrabec@gmail.com>
> Cc: Samuel Holland <samuel@sholland.org>
> Cc: <linux-sunxi@lists.linux.dev>
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

Acked-by: Jernej Skrabec <jernej.skrabec@gmail.com>

Best regards,
Jernej

> ---
>  drivers/pmdomain/Kconfig       |  1 +
>  drivers/pmdomain/sunxi/Kconfig | 10 ++++++++++
>  drivers/soc/sunxi/Kconfig      |  9 ---------
>  3 files changed, 11 insertions(+), 9 deletions(-)
>  create mode 100644 drivers/pmdomain/sunxi/Kconfig
> 
> diff --git a/drivers/pmdomain/Kconfig b/drivers/pmdomain/Kconfig
> index 67049ebf7265..39f358f27f2e 100644
> --- a/drivers/pmdomain/Kconfig
> +++ b/drivers/pmdomain/Kconfig
> @@ -13,5 +13,6 @@ source "drivers/pmdomain/rockchip/Kconfig"
>  source "drivers/pmdomain/samsung/Kconfig"
>  source "drivers/pmdomain/st/Kconfig"
>  source "drivers/pmdomain/starfive/Kconfig"
> +source "drivers/pmdomain/sunxi/Kconfig"
> 
>  endmenu
> diff --git a/drivers/pmdomain/sunxi/Kconfig b/drivers/pmdomain/sunxi/Kconfig
> new file mode 100644
> index 000000000000..17781bf8d86d
> --- /dev/null
> +++ b/drivers/pmdomain/sunxi/Kconfig
> @@ -0,0 +1,10 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +
> +config SUN20I_PPU
> +	bool "Allwinner D1 PPU power domain driver"
> +	depends on ARCH_SUNXI || COMPILE_TEST
> +	depends on PM
> +	select PM_GENERIC_DOMAINS
> +	help
> +	  Say y to enable the PPU power domain driver. This saves power
> +	  when certain peripherals, such as the video engine, are idle.
> diff --git a/drivers/soc/sunxi/Kconfig b/drivers/soc/sunxi/Kconfig
> index c5070914fc6a..8aecbc9b1976 100644
> --- a/drivers/soc/sunxi/Kconfig
> +++ b/drivers/soc/sunxi/Kconfig
> @@ -19,12 +19,3 @@ config SUNXI_SRAM
>  	  Say y here to enable the SRAM controller support. This
>  	  device is responsible on mapping the SRAM in the sunXi SoCs
>  	  whether to the CPU/DMA, or to the devices.
> -
> -config SUN20I_PPU
> -	bool "Allwinner D1 PPU power domain driver"
> -	depends on ARCH_SUNXI || COMPILE_TEST
> -	depends on PM
> -	select PM_GENERIC_DOMAINS
> -	help
> -	  Say y to enable the PPU power domain driver. This saves power
> -	  when certain peripherals, such as the video engine, are idle.





_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-09-14 15:07 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-14 11:19 [PATCH 14/17] pmdomain: sunxi: Move Kconfig option to the pmdomain subsystem Ulf Hansson
2023-09-14 11:19 ` Ulf Hansson
2023-09-14 15:07 ` Jernej Škrabec [this message]
2023-09-14 15:07   ` Jernej Škrabec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2696832.mvXUDI8C0e@jernej-laptop \
    --to=jernej.skrabec@gmail.com \
    --cc=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=olof@lixom.net \
    --cc=samuel@sholland.org \
    --cc=ulf.hansson@linaro.org \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.