Re: [PATCH mptcp-next v4 0/7] BPF path manager, part 3

[Matthieu Baerts <matttbe@kernel.org>]

Hi Geliang,

On 16/01/2025 08:26, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
> 
> v4:
>  - add a new patch, "add a build check for userspace_pm_dump_addr" as
>    Matt suggested.
>  - patch 4, fix a warning here reported by CI:
>    WARNING: line length of 84 exceeds 80 columns
>    #27: FILE: net/mptcp/pm_userspace.c:468:
> 
> v3:
>  - drop "mptcp: update address type of get_local_id".
> 
> v2:
>  - a new patch "hold msk lock before removing id 0 address"
> 
> Drop the patch "mptcp: reuse sending nlmsg code in dump_addr", add a new
> helper mptcp_pm_genl_fill_addr() to save the duplicated code.
> 
> Define struct mptcp_pm_addr_id_bitmap in protocol.h, instead of defining
> mptcp_pm_addr_id_bitmap_t in include/net/mptcp.h, since get_addr() and
> dump_addr() interfaces of BPF userspace pm is dropped as Matt suggested.

Thank you for the patches!

I have a few suggestions, please see my comments on the individual patches.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.