From: Matthieu Baerts <matttbe@kernel.org>
To: Geliang Tang <geliang@kernel.org>, mptcp@lists.linux.dev
Cc: Geliang Tang <tanggeliang@kylinos.cn>
Subject: Re: [PATCH mptcp-next v4 3/7] mptcp: add struct mptcp_pm_addr_id_bitmap
Date: Thu, 23 Jan 2025 12:40:42 +0100 [thread overview]
Message-ID: <5caed8de-3332-46fc-a38c-16f66dc9ad1d@kernel.org> (raw)
In-Reply-To: <30d07c758cfb06aeb312fe37238ce60fc120da13.1737012165.git.tanggeliang@kylinos.cn>
Hi Geliang,
On 16/01/2025 08:26, Geliang Tang wrote:
> From: Geliang Tang <tanggeliang@kylinos.cn>
>
> To simplify the use of bitmap in BPF, a new type for MPTCP userspace
> pm id bitmap, struct mptcp_pm_addr_id_bitmap is defined. Because
> there's no way to use DECLARE_BITMAP macro in BPF program, and it's
> not easy to reimplement it in BPF.
OK, I got that this is needed in BPF, but: why do you need it in the BPF PM?
I guess it is not for the dump_addr interface, right? If yes, then maybe
you don't need that, see my comment on the previous patch.
If not, what is it for?
I can understand that it might be needed to have a bitmap per msk to
handle the different address IDs. But then why is it needed to change
the code in pm_userspace.c, especially in mptcp_userspace_pm_dump_addr?
Cheers,
Matt
--
Sponsored by the NGI0 Core fund.
next prev parent reply other threads:[~2025-01-23 11:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-16 7:26 [PATCH mptcp-next v4 0/7] BPF path manager, part 3 Geliang Tang
2025-01-16 7:26 ` [PATCH mptcp-next v4 1/7] mptcp: add mptcp_pm_genl_fill_addr helper Geliang Tang
2025-01-23 11:37 ` Matthieu Baerts
2025-01-16 7:26 ` [PATCH mptcp-next v4 2/7] mptcp: add a build check for userspace_pm_dump_addr Geliang Tang
2025-01-23 11:37 ` Matthieu Baerts
2025-01-16 7:26 ` [PATCH mptcp-next v4 3/7] mptcp: add struct mptcp_pm_addr_id_bitmap Geliang Tang
2025-01-23 11:40 ` Matthieu Baerts [this message]
2025-01-16 7:26 ` [PATCH mptcp-next v4 4/7] mptcp: drop inet6_sk in mptcp_nl_find_ssk Geliang Tang
2025-01-23 11:40 ` Matthieu Baerts
2025-01-16 7:26 ` [PATCH mptcp-next v4 5/7] mptcp: drop match in userspace_pm_append_new_local_addr Geliang Tang
2025-01-23 11:41 ` Matthieu Baerts
2025-01-16 7:26 ` [PATCH mptcp-next v4 6/7] mptcp: hold msk lock before removing id 0 address Geliang Tang
2025-01-23 11:43 ` Matthieu Baerts
2025-01-16 7:26 ` [PATCH mptcp-next v4 7/7] mptcp: change is_backup interfaces as get_flags Geliang Tang
2025-01-23 11:45 ` Matthieu Baerts
2025-01-16 8:34 ` [PATCH mptcp-next v4 0/7] BPF path manager, part 3 MPTCP CI
2025-01-23 11:34 ` Matthieu Baerts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5caed8de-3332-46fc-a38c-16f66dc9ad1d@kernel.org \
--to=matttbe@kernel.org \
--cc=geliang@kernel.org \
--cc=mptcp@lists.linux.dev \
--cc=tanggeliang@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.