All of lore.kernel.org
 help / color / mirror / Atom feed
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux@ew.tq-group.com
Subject: Re: [PATCH 1/1] ARM: dts: imx6ul: tqma6ul + mba6ulx: Fix pinctrl node names
Date: Mon, 18 Mar 2024 10:35:18 +0100	[thread overview]
Message-ID: <2727312.mvXUDI8C0e@steina-w> (raw)
In-Reply-To: <20240317162214.ssspjf2xfpid32k6@pengutronix.de>

Hi Marco,

Am Sonntag, 17. März 2024, 17:22:14 CET schrieb Marco Felsch:
> Hi Alexander,
> 
> just a minor, please see below.
> 
> On 24-03-14, Alexander Stein wrote:
> > imx6ul pinctrl nodes end with 'grp'. Fix node names.
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> >  arch/arm/boot/dts/nxp/imx/imx6ul-tqma6ul-common.dtsi | 2 +-
> >  arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi               | 6 +++---
> >  2 files changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul-tqma6ul-common.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ul-tqma6ul-common.dtsi
> > index 57e647fc3237..f04c6f71f538 100644
> > --- a/arch/arm/boot/dts/nxp/imx/imx6ul-tqma6ul-common.dtsi
> > +++ b/arch/arm/boot/dts/nxp/imx/imx6ul-tqma6ul-common.dtsi
> > @@ -202,7 +202,7 @@ MX6UL_PAD_UART2_RX_DATA__GPIO1_IO21	0x4001b8b0
> >  		>;
> >  	};
> >  
> > -	pinctrl_pmic: pmic {
> > +	pinctrl_pmic: grp {
> 			^
> 			pmicgrp

Nice catch. Will be fixed in v2. Thanks.

Best regards,
Alexander

>  
> >  		fsl,pins = <
> >  			/* PMIC irq */
> >  			MX6UL_PAD_CSI_DATA03__GPIO4_IO24	0x1b099
> > diff --git a/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi b/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
> > index e78d0a7d8cd2..5258ef81e6c7 100644
> > --- a/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
> > +++ b/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
> > @@ -505,7 +505,7 @@ MX6UL_PAD_CSI_HSYNC__UART6_DCE_CTS	0x1b0b1
> >  		>;
> >  	};
> >  
> > -	pinctrl_uart6dte: uart6dte {
> > +	pinctrl_uart6dte: uart6dtegrp {
> >  		fsl,pins = <
> >  			MX6UL_PAD_CSI_PIXCLK__UART6_DTE_TX	0x1b0b1
> >  			MX6UL_PAD_CSI_MCLK__UART6_DTE_RX	0x1b0b1
> > @@ -537,7 +537,7 @@ MX6UL_PAD_UART1_RTS_B__GPIO1_IO19	0x0001b099
> >  		>;
> >  	};
> >  
> > -	pinctrl_usdhc1_100mhz: usdhc1grp100mhz {
> > +	pinctrl_usdhc1_100mhz: usdhc1-100mhzgrp {
> >  		fsl,pins = <
> >  			MX6UL_PAD_SD1_CLK__USDHC1_CLK		0x00017069
> >  			MX6UL_PAD_SD1_CMD__USDHC1_CMD		0x000170b9
> > @@ -552,7 +552,7 @@ MX6UL_PAD_UART1_RTS_B__GPIO1_IO19	0x0001b099
> >  		>;
> >  	};
> >  
> > -	pinctrl_usdhc1_200mhz: usdhc1grp200mhz {
> > +	pinctrl_usdhc1_200mhz: usdhc1-200mhzgrp {
> >  		fsl,pins = <
> >  			MX6UL_PAD_SD1_CLK__USDHC1_CLK		0x00017069
> >  			MX6UL_PAD_SD1_CMD__USDHC1_CMD		0x000170f9
> 


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/



WARNING: multiple messages have this Message-ID (diff)
From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: Marco Felsch <m.felsch@pengutronix.de>
Cc: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>,
	Pengutronix Kernel Team <kernel@pengutronix.de>,
	Fabio Estevam <festevam@gmail.com>,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org, linux@ew.tq-group.com
Subject: Re: [PATCH 1/1] ARM: dts: imx6ul: tqma6ul + mba6ulx: Fix pinctrl node names
Date: Mon, 18 Mar 2024 10:35:18 +0100	[thread overview]
Message-ID: <2727312.mvXUDI8C0e@steina-w> (raw)
In-Reply-To: <20240317162214.ssspjf2xfpid32k6@pengutronix.de>

Hi Marco,

Am Sonntag, 17. März 2024, 17:22:14 CET schrieb Marco Felsch:
> Hi Alexander,
> 
> just a minor, please see below.
> 
> On 24-03-14, Alexander Stein wrote:
> > imx6ul pinctrl nodes end with 'grp'. Fix node names.
> > 
> > Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> > ---
> >  arch/arm/boot/dts/nxp/imx/imx6ul-tqma6ul-common.dtsi | 2 +-
> >  arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi               | 6 +++---
> >  2 files changed, 4 insertions(+), 4 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/nxp/imx/imx6ul-tqma6ul-common.dtsi b/arch/arm/boot/dts/nxp/imx/imx6ul-tqma6ul-common.dtsi
> > index 57e647fc3237..f04c6f71f538 100644
> > --- a/arch/arm/boot/dts/nxp/imx/imx6ul-tqma6ul-common.dtsi
> > +++ b/arch/arm/boot/dts/nxp/imx/imx6ul-tqma6ul-common.dtsi
> > @@ -202,7 +202,7 @@ MX6UL_PAD_UART2_RX_DATA__GPIO1_IO21	0x4001b8b0
> >  		>;
> >  	};
> >  
> > -	pinctrl_pmic: pmic {
> > +	pinctrl_pmic: grp {
> 			^
> 			pmicgrp

Nice catch. Will be fixed in v2. Thanks.

Best regards,
Alexander

>  
> >  		fsl,pins = <
> >  			/* PMIC irq */
> >  			MX6UL_PAD_CSI_DATA03__GPIO4_IO24	0x1b099
> > diff --git a/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi b/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
> > index e78d0a7d8cd2..5258ef81e6c7 100644
> > --- a/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
> > +++ b/arch/arm/boot/dts/nxp/imx/mba6ulx.dtsi
> > @@ -505,7 +505,7 @@ MX6UL_PAD_CSI_HSYNC__UART6_DCE_CTS	0x1b0b1
> >  		>;
> >  	};
> >  
> > -	pinctrl_uart6dte: uart6dte {
> > +	pinctrl_uart6dte: uart6dtegrp {
> >  		fsl,pins = <
> >  			MX6UL_PAD_CSI_PIXCLK__UART6_DTE_TX	0x1b0b1
> >  			MX6UL_PAD_CSI_MCLK__UART6_DTE_RX	0x1b0b1
> > @@ -537,7 +537,7 @@ MX6UL_PAD_UART1_RTS_B__GPIO1_IO19	0x0001b099
> >  		>;
> >  	};
> >  
> > -	pinctrl_usdhc1_100mhz: usdhc1grp100mhz {
> > +	pinctrl_usdhc1_100mhz: usdhc1-100mhzgrp {
> >  		fsl,pins = <
> >  			MX6UL_PAD_SD1_CLK__USDHC1_CLK		0x00017069
> >  			MX6UL_PAD_SD1_CMD__USDHC1_CMD		0x000170b9
> > @@ -552,7 +552,7 @@ MX6UL_PAD_UART1_RTS_B__GPIO1_IO19	0x0001b099
> >  		>;
> >  	};
> >  
> > -	pinctrl_usdhc1_200mhz: usdhc1grp200mhz {
> > +	pinctrl_usdhc1_200mhz: usdhc1-200mhzgrp {
> >  		fsl,pins = <
> >  			MX6UL_PAD_SD1_CLK__USDHC1_CLK		0x00017069
> >  			MX6UL_PAD_SD1_CMD__USDHC1_CMD		0x000170f9
> 


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2024-03-18  9:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-14 15:00 [PATCH 1/1] ARM: dts: imx6ul: tqma6ul + mba6ulx: Fix pinctrl node names Alexander Stein
2024-03-14 15:00 ` Alexander Stein
2024-03-17 16:22 ` Marco Felsch
2024-03-17 16:22   ` Marco Felsch
2024-03-18  9:35   ` Alexander Stein [this message]
2024-03-18  9:35     ` Alexander Stein

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2727312.mvXUDI8C0e@steina-w \
    --to=alexander.stein@ew.tq-group.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=festevam@gmail.com \
    --cc=imx@lists.linux.dev \
    --cc=kernel@pengutronix.de \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@ew.tq-group.com \
    --cc=m.felsch@pengutronix.de \
    --cc=robh@kernel.org \
    --cc=s.hauer@pengutronix.de \
    --cc=shawnguo@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.