From: Christian Lamparter <chunkeey@googlemail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Kalle Valo <kvalo@codeaurora.org>,
Christian Lamparter <chunkeey@googlemail.com>,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
b43-dev@lists.infradead.org, Nicolai Stange <nicstange@gmail.com>,
Ben Greear <greearb@candelatech.com>,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: [PATCH 2/4] carl9170: fix debugfs crashes
Date: Sun, 18 Sep 2016 14:49:33 +0200 [thread overview]
Message-ID: <2731122.i7AxIUFRZe@debian64> (raw)
In-Reply-To: <20160918101455.GA8410@kroah.com>
On Sunday, September 18, 2016 12:14:55 PM CEST Greg KH wrote:
> On Sun, Sep 18, 2016 at 10:54:18AM +0300, Kalle Valo wrote:
> > Greg KH <gregkh@linuxfoundation.org> writes:
> >
> > > On Sat, Sep 17, 2016 at 09:43:02PM +0200, Christian Lamparter wrote:
> > >> Ben Greear reported:
> > >> > I see lots of instability as soon as I load up the carl9710 NIC.
> > >> > My application is going to be poking at it's debugfs files...
> > >> >
> > >> > BUG: KASAN: slab-out-of-bounds in carl9170_debugfs_read+0xd5/0x2a0
> > >> > [carl9170] at addr ffff8801bc1208b0
> > >> > Read of size 8 by task btserver/5888
> > >> > =======================================================================
> > >> > BUG kmalloc-256 (Tainted: G W ): kasan: bad access detected
> > >> > -----------------------------------------------------------------------
> > >> >
> > >> > INFO: Allocated in seq_open+0x50/0x100 age=2690 cpu=2 pid=772
> > >> >...
> > >>
> > >> This breakage was caused by the introduction of intermediate
> > >> fops in debugfs by commit 9fd4dcece43a
> > >> ("debugfs: prevent access to possibly dead file_operations at file open")
> > >
> > > Because of this, these should all be backported to 4.7-stable, and
> > > 4.8-stable, right?
Ok, only b43legacy has debugfs enabled by default. For b43 and carl9170
debugfs support is usually disabled.
Greg, would you take these four patches "as is" for -stable
or do you want a "minimal version" which just replaces the
dfops = container_of(file->f_op, ...
with
dfops = container_of(file->f_path.dentry->d_fsdata, ...
in the three drivers for -stable?
> > Via which tree should these go, Greg's or mine?
>
> I'll take it if you ack it, as it's a debugfs issue.
For carl9170: Ben Greear has reported:
"I have verified this fixes my problem in the 4.7 kernel."
But this was with a preliminary/minimal version so I didn't
add the tested-by tag.
As for b43, I'll see if I have a working b43 in my collection
somewhere to confirm the issue and the fix. Question is, do
you want to wait or not?
Regards,
Christian
WARNING: multiple messages have this Message-ID (diff)
From: Christian Lamparter <chunkeey@googlemail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Kalle Valo <kvalo@codeaurora.org>,
Christian Lamparter <chunkeey@googlemail.com>,
linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
b43-dev@lists.infradead.org, Nicolai Stange <nicstange@gmail.com>,
Ben Greear <greearb@candelatech.com>,
Larry Finger <Larry.Finger@lwfinger.net>
Subject: Re: [PATCH 2/4] carl9170: fix debugfs crashes
Date: Sun, 18 Sep 2016 14:49:33 +0200 [thread overview]
Message-ID: <2731122.i7AxIUFRZe@debian64> (raw)
In-Reply-To: <20160918101455.GA8410@kroah.com>
On Sunday, September 18, 2016 12:14:55 PM CEST Greg KH wrote:
> On Sun, Sep 18, 2016 at 10:54:18AM +0300, Kalle Valo wrote:
> > Greg KH <gregkh@linuxfoundation.org> writes:
> >
> > > On Sat, Sep 17, 2016 at 09:43:02PM +0200, Christian Lamparter wrote:
> > >> Ben Greear reported:
> > >> > I see lots of instability as soon as I load up the carl9710 NIC.
> > >> > My application is going to be poking at it's debugfs files...
> > >> >
> > >> > BUG: KASAN: slab-out-of-bounds in carl9170_debugfs_read+0xd5/0x2a0
> > >> > [carl9170] at addr ffff8801bc1208b0
> > >> > Read of size 8 by task btserver/5888
> > >> > =======================================================================
> > >> > BUG kmalloc-256 (Tainted: G W ): kasan: bad access detected
> > >> > -----------------------------------------------------------------------
> > >> >
> > >> > INFO: Allocated in seq_open+0x50/0x100 age=2690 cpu=2 pid=772
> > >> >...
> > >>
> > >> This breakage was caused by the introduction of intermediate
> > >> fops in debugfs by commit 9fd4dcece43a
> > >> ("debugfs: prevent access to possibly dead file_operations at file open")
> > >
> > > Because of this, these should all be backported to 4.7-stable, and
> > > 4.8-stable, right?
Ok, only b43legacy has debugfs enabled by default. For b43 and carl9170
debugfs support is usually disabled.
Greg, would you take these four patches "as is" for -stable
or do you want a "minimal version" which just replaces the
dfops = container_of(file->f_op, ...
with
dfops = container_of(file->f_path.dentry->d_fsdata, ...
in the three drivers for -stable?
> > Via which tree should these go, Greg's or mine?
>
> I'll take it if you ack it, as it's a debugfs issue.
For carl9170: Ben Greear has reported:
"I have verified this fixes my problem in the 4.7 kernel."
But this was with a preliminary/minimal version so I didn't
add the tested-by tag.
As for b43, I'll see if I have a working b43 in my collection
somewhere to confirm the issue and the fix. Question is, do
you want to wait or not?
Regards,
Christian
next prev parent reply other threads:[~2016-09-18 12:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-17 19:43 [PATCH 1/4] debugfs: introduce a public file_operations accessor Christian Lamparter
2016-09-17 19:43 ` [PATCH 2/4] carl9170: fix debugfs crashes Christian Lamparter
2016-09-17 21:45 ` Greg KH
2016-09-17 21:45 ` Greg KH
2016-09-18 7:54 ` Kalle Valo
2016-09-18 7:54 ` Kalle Valo
2016-09-18 10:14 ` Greg KH
2016-09-18 10:14 ` Greg KH
2016-09-18 12:49 ` Christian Lamparter [this message]
2016-09-18 12:49 ` Christian Lamparter
2016-09-18 16:44 ` Greg KH
2016-09-18 16:44 ` Greg KH
2016-09-19 20:12 ` Christian Lamparter
2016-09-19 20:12 ` Christian Lamparter
2016-09-20 6:50 ` Greg KH
2016-09-20 6:50 ` Greg KH
2016-09-18 16:57 ` Kalle Valo
2016-09-18 16:57 ` Kalle Valo
2016-09-21 10:13 ` Greg KH
2016-09-21 10:13 ` Greg KH
2016-09-21 16:29 ` Christian Lamparter
2016-09-21 16:29 ` Christian Lamparter
2016-09-21 16:49 ` [PATCH v2] " Christian Lamparter
2016-09-17 19:43 ` [PATCH 3/4] b43: fix debugfs crash Christian Lamparter
2016-09-17 19:43 ` Christian Lamparter
2016-09-17 19:43 ` [PATCH 4/4] b43legacy: " Christian Lamparter
2016-09-17 19:43 ` Christian Lamparter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2731122.i7AxIUFRZe@debian64 \
--to=chunkeey@googlemail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=b43-dev@lists.infradead.org \
--cc=greearb@candelatech.com \
--cc=gregkh@linuxfoundation.org \
--cc=kvalo@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nicstange@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.