From: Heiko Stuebner <heiko@sntech.de>
To: Shawn Lin <shawn.lin@rock-chips.com>
Cc: linux-clk@vger.kernel.org, linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 2/3] clk: rockchip: Fix wrong parent for SDMMC phase clock for rk3228
Date: Fri, 23 Mar 2018 08:51:40 +0100 [thread overview]
Message-ID: <2742343.qouzS0Ddo7@phil> (raw)
In-Reply-To: <1521599960-34381-2-git-send-email-shawn.lin@rock-chips.com>
Am Mittwoch, 21. März 2018, 03:39:19 CET schrieb Shawn Lin:
> commit c420c1e4db22 ("clk: rockchip: Prevent calculating mmc phase
> if clock rate is zero") catches one gremlin again for clk-rk3228.c
> that the parent of SDMMC phase clock should be sclk_sdmmc0, but not
> sclk_sdmmc. However, I don't like the name of sclk_sdmmc0, so I now
> rename it to be sclk_sdmmc.
>
> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
applied to my clk-branch after adapting the commit message a bit,
so that it is less about personal taste and highlights the discrepancy
in the manual between clk_sdmmc0 and hclk_sdmmc (without 0)
and we thus standardize on the one without 0.
Heiko
WARNING: multiple messages have this Message-ID (diff)
From: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
To: Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH 2/3] clk: rockchip: Fix wrong parent for SDMMC phase clock for rk3228
Date: Fri, 23 Mar 2018 08:51:40 +0100 [thread overview]
Message-ID: <2742343.qouzS0Ddo7@phil> (raw)
In-Reply-To: <1521599960-34381-2-git-send-email-shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
Am Mittwoch, 21. März 2018, 03:39:19 CET schrieb Shawn Lin:
> commit c420c1e4db22 ("clk: rockchip: Prevent calculating mmc phase
> if clock rate is zero") catches one gremlin again for clk-rk3228.c
> that the parent of SDMMC phase clock should be sclk_sdmmc0, but not
> sclk_sdmmc. However, I don't like the name of sclk_sdmmc0, so I now
> rename it to be sclk_sdmmc.
>
> Signed-off-by: Shawn Lin <shawn.lin-TNX95d0MmH7DzftRWevZcw@public.gmane.org>
applied to my clk-branch after adapting the commit message a bit,
so that it is less about personal taste and highlights the discrepancy
in the manual between clk_sdmmc0 and hclk_sdmmc (without 0)
and we thus standardize on the one without 0.
Heiko
next prev parent reply other threads:[~2018-03-23 7:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 2:39 [PATCH 1/3] clk: rockchip: Fix wrong parents for MMC phase clock for rk3328 Shawn Lin
2018-03-21 2:39 ` Shawn Lin
2018-03-21 2:39 ` [PATCH 2/3] clk: rockchip: Fix wrong parent for SDMMC phase clock for rk3228 Shawn Lin
2018-03-21 2:39 ` Shawn Lin
2018-03-23 7:51 ` Heiko Stuebner [this message]
2018-03-23 7:51 ` Heiko Stuebner
2018-03-21 2:39 ` [PATCH 3/3] clk: rockchip: Correct the behaviour of restoring cached phase Shawn Lin
2018-03-21 2:39 ` Shawn Lin
2018-03-23 8:19 ` Heiko Stuebner
2018-03-23 8:19 ` Heiko Stuebner
2018-03-23 8:18 ` [PATCH 1/3] clk: rockchip: Fix wrong parents for MMC phase clock for rk3328 Heiko Stuebner
2018-03-23 8:18 ` Heiko Stuebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2742343.qouzS0Ddo7@phil \
--to=heiko@sntech.de \
--cc=linux-clk@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=shawn.lin@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.