* [PATCH] ARM: multi_v7_defconfig: Change RTC_DRV_HYM8563 to builtin
@ 2016-01-09 19:28 ` Sjoerd Simons
0 siblings, 0 replies; 6+ messages in thread
From: Sjoerd Simons @ 2016-01-09 19:28 UTC (permalink / raw)
To: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
arm-DgEjT+Ai2ygdnm+yROfE0A
Cc: Heiko Stuebner, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Apart from providing an RTC the hym8563 chip on some rockchip boards
(e.g. rock2 square and firefly) also provide the 32khz clock used by the
SoCs thermal sensors.
Switch the driver from a module to builtin such that the thermal
protection can work even if modules aren't used/loaded.
Signed-off-by: Sjoerd Simons <sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
---
arch/arm/configs/multi_v7_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index f6e104d..0fcb1dd 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -650,7 +650,7 @@ CONFIG_EDAC_HIGHBANK_L2=y
CONFIG_RTC_CLASS=y
CONFIG_RTC_DRV_AS3722=y
CONFIG_RTC_DRV_DS1307=y
-CONFIG_RTC_DRV_HYM8563=m
+CONFIG_RTC_DRV_HYM8563=y
CONFIG_RTC_DRV_MAX8907=y
CONFIG_RTC_DRV_MAX8997=m
CONFIG_RTC_DRV_MAX77686=y
--
2.7.0.rc3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] ARM: multi_v7_defconfig: Change RTC_DRV_HYM8563 to builtin
@ 2016-01-09 19:28 ` Sjoerd Simons
0 siblings, 0 replies; 6+ messages in thread
From: Sjoerd Simons @ 2016-01-09 19:28 UTC (permalink / raw)
To: linux-arm-kernel
Apart from providing an RTC the hym8563 chip on some rockchip boards
(e.g. rock2 square and firefly) also provide the 32khz clock used by the
SoCs thermal sensors.
Switch the driver from a module to builtin such that the thermal
protection can work even if modules aren't used/loaded.
Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
---
arch/arm/configs/multi_v7_defconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig
index f6e104d..0fcb1dd 100644
--- a/arch/arm/configs/multi_v7_defconfig
+++ b/arch/arm/configs/multi_v7_defconfig
@@ -650,7 +650,7 @@ CONFIG_EDAC_HIGHBANK_L2=y
CONFIG_RTC_CLASS=y
CONFIG_RTC_DRV_AS3722=y
CONFIG_RTC_DRV_DS1307=y
-CONFIG_RTC_DRV_HYM8563=m
+CONFIG_RTC_DRV_HYM8563=y
CONFIG_RTC_DRV_MAX8907=y
CONFIG_RTC_DRV_MAX8997=m
CONFIG_RTC_DRV_MAX77686=y
--
2.7.0.rc3
^ permalink raw reply related [flat|nested] 6+ messages in thread
[parent not found: <1452367683-11160-1-git-send-email-sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>]
* Re: [PATCH] ARM: multi_v7_defconfig: Change RTC_DRV_HYM8563 to builtin
2016-01-09 19:28 ` Sjoerd Simons
@ 2016-01-09 19:33 ` Heiko Stuebner
-1 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2016-01-09 19:33 UTC (permalink / raw)
To: Sjoerd Simons, arm-DgEjT+Ai2ygdnm+yROfE0A
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Am Samstag, 9. Januar 2016, 20:28:02 schrieb Sjoerd Simons:
> Apart from providing an RTC the hym8563 chip on some rockchip boards
> (e.g. rock2 square and firefly) also provide the 32khz clock used by the
> SoCs thermal sensors.
>
> Switch the driver from a module to builtin such that the thermal
> protection can work even if modules aren't used/loaded.
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
Personally I'm ok with the reasoning for requiring rtc to be build in,
but I guess others might disagree. Nevertheless
Acked-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
and we'll let armsoc-people decide ;-) .
Ideally we would do the same for the rk808 rtc as well - as it is exactly
the same argument / case.
Heiko
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: multi_v7_defconfig: Change RTC_DRV_HYM8563 to builtin
@ 2016-01-09 19:33 ` Heiko Stuebner
0 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2016-01-09 19:33 UTC (permalink / raw)
To: linux-arm-kernel
Am Samstag, 9. Januar 2016, 20:28:02 schrieb Sjoerd Simons:
> Apart from providing an RTC the hym8563 chip on some rockchip boards
> (e.g. rock2 square and firefly) also provide the 32khz clock used by the
> SoCs thermal sensors.
>
> Switch the driver from a module to builtin such that the thermal
> protection can work even if modules aren't used/loaded.
>
> Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
Personally I'm ok with the reasoning for requiring rtc to be build in,
but I guess others might disagree. Nevertheless
Acked-by: Heiko Stuebner <heiko@sntech.de>
and we'll let armsoc-people decide ;-) .
Ideally we would do the same for the rk808 rtc as well - as it is exactly
the same argument / case.
Heiko
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] ARM: multi_v7_defconfig: Change RTC_DRV_HYM8563 to builtin
2016-01-09 19:33 ` Heiko Stuebner
@ 2016-01-09 22:45 ` Heiko Stuebner
-1 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2016-01-09 22:45 UTC (permalink / raw)
To: Sjoerd Simons
Cc: linux-rockchip-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r,
arm-DgEjT+Ai2ygdnm+yROfE0A,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
Am Samstag, 9. Januar 2016, 20:33:51 schrieb Heiko Stuebner:
> Am Samstag, 9. Januar 2016, 20:28:02 schrieb Sjoerd Simons:
> > Apart from providing an RTC the hym8563 chip on some rockchip boards
> > (e.g. rock2 square and firefly) also provide the 32khz clock used by the
> > SoCs thermal sensors.
> >
> > Switch the driver from a module to builtin such that the thermal
> > protection can work even if modules aren't used/loaded.
> >
> > Signed-off-by: Sjoerd Simons <sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
>
> Personally I'm ok with the reasoning for requiring rtc to be build in,
> but I guess others might disagree. Nevertheless
>
> Acked-by: Heiko Stuebner <heiko-4mtYJXux2i+zQB+pC5nmwQ@public.gmane.org>
>
> and we'll let armsoc-people decide ;-) .
>
>
> Ideally we would do the same for the rk808 rtc as well - as it is exactly
> the same argument / case.
just so nobody gets the wrong idea, on the rk808, the needed clkout is
separate in CONFIG_COMMON_CLK_RK808, not in the rtc. Still currently build
as module, so depending on if we can build-in the hym8563, we should change
the rk808-clkout accordingly.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] ARM: multi_v7_defconfig: Change RTC_DRV_HYM8563 to builtin
@ 2016-01-09 22:45 ` Heiko Stuebner
0 siblings, 0 replies; 6+ messages in thread
From: Heiko Stuebner @ 2016-01-09 22:45 UTC (permalink / raw)
To: linux-arm-kernel
Am Samstag, 9. Januar 2016, 20:33:51 schrieb Heiko Stuebner:
> Am Samstag, 9. Januar 2016, 20:28:02 schrieb Sjoerd Simons:
> > Apart from providing an RTC the hym8563 chip on some rockchip boards
> > (e.g. rock2 square and firefly) also provide the 32khz clock used by the
> > SoCs thermal sensors.
> >
> > Switch the driver from a module to builtin such that the thermal
> > protection can work even if modules aren't used/loaded.
> >
> > Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
>
> Personally I'm ok with the reasoning for requiring rtc to be build in,
> but I guess others might disagree. Nevertheless
>
> Acked-by: Heiko Stuebner <heiko@sntech.de>
>
> and we'll let armsoc-people decide ;-) .
>
>
> Ideally we would do the same for the rk808 rtc as well - as it is exactly
> the same argument / case.
just so nobody gets the wrong idea, on the rk808, the needed clkout is
separate in CONFIG_COMMON_CLK_RK808, not in the rtc. Still currently build
as module, so depending on if we can build-in the hym8563, we should change
the rk808-clkout accordingly.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-01-09 22:45 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-01-09 19:28 [PATCH] ARM: multi_v7_defconfig: Change RTC_DRV_HYM8563 to builtin Sjoerd Simons
2016-01-09 19:28 ` Sjoerd Simons
[not found] ` <1452367683-11160-1-git-send-email-sjoerd.simons-ZGY8ohtN/8pPYcu2f3hruQ@public.gmane.org>
2016-01-09 19:33 ` Heiko Stuebner
2016-01-09 19:33 ` Heiko Stuebner
2016-01-09 22:45 ` Heiko Stuebner
2016-01-09 22:45 ` Heiko Stuebner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.